chore: fix flaky memorydiagnoser tests on macos (#2813)

filzrev · web-flow · commit 7250970347cf · 2025-07-21T19:00:48.000-04:00
diff --git a/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs b/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs
@@ -244,11 +244,14 @@ public void AllocationQuantumIsNotAnIssueForNetCore21Plus(IToolchain toolchain)
         {
             long objectAllocationOverhead = IntPtr.Size * 2; // pointer to method table + object header word
             long arraySizeOverhead = IntPtr.Size; // array length
+            int warmupCount = OsDetector.IsMacOS()
+                ? 5  // Workaround setting for macos. https://github.com/dotnet/BenchmarkDotNet/issues/2779
+                : 0; // Other OS don't need warmup
 
             AssertAllocations(toolchain, typeof(TimeConsuming), new Dictionary<string, long>
             {
                 { nameof(TimeConsuming.SixtyFourBytesArray), 64 + objectAllocationOverhead + arraySizeOverhead }
-            }, warmupCount: 2);
+            }, warmupCount: warmupCount);
         }
 
         public class MultiThreadedAllocation

Original file line number	Diff line number	Diff line change
`@@ -244,11 +244,14 @@ public void AllocationQuantumIsNotAnIssueForNetCore21Plus(IToolchain toolchain)`
`244`	`244`	`{`
`245`	`245`	`long objectAllocationOverhead = IntPtr.Size * 2; // pointer to method table + object header word`
`246`	`246`	`long arraySizeOverhead = IntPtr.Size; // array length`
	`247`	`+ int warmupCount = OsDetector.IsMacOS()`
	`248`	`+ ? 5 // Workaround setting for macos. https://github.com/dotnet/BenchmarkDotNet/issues/2779`
	`249`	`+ : 0; // Other OS don't need warmup`
`247`	`250`
`248`	`251`	`AssertAllocations(toolchain, typeof(TimeConsuming), new Dictionary<string, long>`
`249`	`252`	`{`
`250`	`253`	`{ nameof(TimeConsuming.SixtyFourBytesArray), 64 + objectAllocationOverhead + arraySizeOverhead }`
`251`		`- }, warmupCount: 2);`
	`254`	`+ }, warmupCount: warmupCount);`
`252`	`255`	`}`
`253`	`256`
`254`	`257`	`public class MultiThreadedAllocation`