use ImmutableConfig when doing apples-to-apples comparison (#2193)

adamsitnik · web-flow · commit 8b6159139280 · 2022-11-10T17:00:14.000+01:00
diff --git a/src/BenchmarkDotNet/Running/BenchmarkSwitcher.cs b/src/BenchmarkDotNet/Running/BenchmarkSwitcher.cs
@@ -114,7 +114,7 @@ internal IEnumerable<Summary> RunWithDirtyAssemblyResolveHelper(string[] args, I
 
             if (effectiveConfig.Options.HasFlag(ConfigOptions.ApplesToApples))
             {
-                return ApplesToApples(effectiveConfig, benchmarksToFilter, logger, options);
+                return ApplesToApples(ImmutableConfigBuilder.Create(effectiveConfig), benchmarksToFilter, logger, options);
             }
 
             var filteredBenchmarks = TypeFilter.Filter(effectiveConfig, benchmarksToFilter);
@@ -140,7 +140,7 @@ private static void PrintList(ILogger nonNullLogger, IConfig effectiveConfig, IR
             printer.Print(testNames, nonNullLogger);
         }
 
-        private IEnumerable<Summary> ApplesToApples(ManualConfig effectiveConfig, IReadOnlyList<Type> benchmarksToFilter, ILogger logger, CommandLineOptions options)
+        private IEnumerable<Summary> ApplesToApples(ImmutableConfig effectiveConfig, IReadOnlyList<Type> benchmarksToFilter, ILogger logger, CommandLineOptions options)
         {
             var jobs = effectiveConfig.GetJobs().ToArray();
             if (jobs.Length <= 1)

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ internal IEnumerable<Summary> RunWithDirtyAssemblyResolveHelper(string[] args, I`
`114`	`114`
`115`	`115`	`if (effectiveConfig.Options.HasFlag(ConfigOptions.ApplesToApples))`
`116`	`116`	`{`
`117`		`- return ApplesToApples(effectiveConfig, benchmarksToFilter, logger, options);`
	`117`	`+ return ApplesToApples(ImmutableConfigBuilder.Create(effectiveConfig), benchmarksToFilter, logger, options);`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`var filteredBenchmarks = TypeFilter.Filter(effectiveConfig, benchmarksToFilter);`
`@@ -140,7 +140,7 @@ private static void PrintList(ILogger nonNullLogger, IConfig effectiveConfig, IR`
`140`	`140`	`printer.Print(testNames, nonNullLogger);`
`141`	`141`	`}`
`142`	`142`
`143`		`- private IEnumerable<Summary> ApplesToApples(ManualConfig effectiveConfig, IReadOnlyList<Type> benchmarksToFilter, ILogger logger, CommandLineOptions options)`
	`143`	`+ private IEnumerable<Summary> ApplesToApples(ImmutableConfig effectiveConfig, IReadOnlyList<Type> benchmarksToFilter, ILogger logger, CommandLineOptions options)`
`144`	`144`	`{`
`145`	`145`	`var jobs = effectiveConfig.GetJobs().ToArray();`
`146`	`146`	`if (jobs.Length <= 1)`