Always fail if dotnet command failed. (#2535)

timcassell · web-flow · commit 924ca6d51460 · 2025-05-02T16:51:45.000-04:00
diff --git a/src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommandResult.cs b/src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommandResult.cs
@@ -35,7 +35,7 @@ public static DotNetCliCommandResult Failure(TimeSpan time, string standardError
 
         [PublicAPI]
         public BuildResult ToBuildResult(GenerateResult generateResult)
-            => IsSuccess || File.Exists(generateResult.ArtifactsPaths.ExecutablePath) // dotnet cli could have successfully built the program, but returned 1 as exit code because it had some warnings
+            => IsSuccess
                 ? BuildResult.Success(generateResult)
                 : BuildResult.Failure(generateResult, AllInformation);
     }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public static DotNetCliCommandResult Failure(TimeSpan time, string standardError`
`35`	`35`
`36`	`36`	`[PublicAPI]`
`37`	`37`	`public BuildResult ToBuildResult(GenerateResult generateResult)`
`38`		`- => IsSuccess \|\| File.Exists(generateResult.ArtifactsPaths.ExecutablePath) // dotnet cli could have successfully built the program, but returned 1 as exit code because it had some warnings`
	`38`	`+ => IsSuccess`
`39`	`39`	`? BuildResult.Success(generateResult)`
`40`	`40`	`: BuildResult.Failure(generateResult, AllInformation);`
`41`	`41`	`}`