Dont redirect standard input for WASM (#1689)

* Don't redirect standard input with Wasm.

* Apply suggestions from code review

Co-authored-by: Adam Sitnik <[email protected]>

Author: Nathan Ricci

src/BenchmarkDotNet/Loggers/SynchronousProcessOutputLoggerWithDiagnoser.cs

@@ -3,6 +3,7 @@
 using System.Diagnostics;
 using BenchmarkDotNet.Diagnosers;
 using BenchmarkDotNet.Engines;
+using BenchmarkDotNet.Environments;
 using BenchmarkDotNet.Running;
 
 namespace BenchmarkDotNet.Loggers
@@ -18,7 +19,7 @@ public SynchronousProcessOutputLoggerWithDiagnoser(ILogger logger, Process proce
         {
             if (!process.StartInfo.RedirectStandardOutput)
                 throw new NotSupportedException("set RedirectStandardOutput to true first");
-            if (!process.StartInfo.RedirectStandardInput)
+            if (!(process.StartInfo.RedirectStandardInput || benchmarkCase.GetRuntime() is WasmRuntime))
                 throw new NotSupportedException("set RedirectStandardInput to true first");
 
             this.logger = logger;
@@ -54,7 +55,11 @@ internal void ProcessInput()
                 else if (Engine.Signals.TryGetSignal(line, out var signal))
                 {
                     diagnoser?.Handle(signal, diagnoserActionParameters);
-                    process.StandardInput.WriteLine(Engine.Signals.Acknowledgment);
+
+                    if (process.StartInfo.RedirectStandardInput)
+                    {
+                        process.StandardInput.WriteLine(Engine.Signals.Acknowledgment);
+                    }
 
                     if (signal == HostSignal.AfterAll)
                     {
@@ -70,4 +75,4 @@ internal void ProcessInput()
             }
         }
     }
-}
+}

src/BenchmarkDotNet/Running/BenchmarkCase.cs

@@ -1,8 +1,10 @@
 using System;
 using System.Linq;
 using BenchmarkDotNet.Configs;
+using BenchmarkDotNet.Environments;
 using BenchmarkDotNet.Jobs;
 using BenchmarkDotNet.Parameters;
+using BenchmarkDotNet.Portability;
 
 namespace BenchmarkDotNet.Running
 {
@@ -26,6 +28,10 @@ private BenchmarkCase(Descriptor descriptor, Job job, ParameterInstances paramet
             Config = config;
         }
 
+        public Runtime GetRuntime() => Job.Environment.HasValue(EnvironmentMode.RuntimeCharacteristic)
+                ? Job.Environment.Runtime
+                : RuntimeInformation.GetCurrentRuntime();
+
         public void Dispose() => Parameters.Dispose();
 
         public int CompareTo(BenchmarkCase other) => string.Compare(FolderInfo, other.FolderInfo, StringComparison.Ordinal);
@@ -37,4 +43,4 @@ private BenchmarkCase(Descriptor descriptor, Job job, ParameterInstances paramet
         public static BenchmarkCase Create(Descriptor descriptor, Job job, ParameterInstances parameters, ImmutableConfig config)
             => new BenchmarkCase(descriptor, job.MakeSettingsUserFriendly(descriptor), parameters, config);
     }
-}
+}

src/BenchmarkDotNet/Toolchains/Executor.cs

@@ -98,9 +98,7 @@ private ProcessStartInfo CreateStartInfo(BenchmarkCase benchmarkCase, ArtifactsP
 
             string exePath = artifactsPaths.ExecutablePath;
 
-            var runtime = benchmarkCase.Job.Environment.HasValue(EnvironmentMode.RuntimeCharacteristic)
-                ? benchmarkCase.Job.Environment.Runtime
-                : RuntimeInformation.GetCurrentRuntime();
+            var runtime = benchmarkCase.GetRuntime();
             // TODO: use resolver
 
             switch (runtime)
@@ -117,6 +115,7 @@ private ProcessStartInfo CreateStartInfo(BenchmarkCase benchmarkCase, ArtifactsP
                     break;
                 case WasmRuntime wasm:
                     start.FileName = wasm.JavaScriptEngine;
+                    start.RedirectStandardInput = false;
                     start.Arguments = $"{wasm.JavaScriptEngineArguments} runtime.js -- --run {artifactsPaths.ProgramName}.dll {args} ";
                     start.WorkingDirectory = artifactsPaths.BinariesDirectoryPath;
                     break;
@@ -151,4 +150,4 @@ private string GetMonoArguments(Job job, string exePath, string args, IResolver
             return builder.ToString();
         }
     }
-}
+}