Fix deadlock in GetDotNetSdkVersion (#2622)

Korexio · web-flow · commit c8105aab564d · 2024-08-22T14:09:16.000-04:00
* Fix deadlock in GetDotNetSdkVersion

* Remove newline at the end of file
diff --git a/src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommandExecutor.cs b/src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommandExecutor.cs
@@ -56,7 +56,7 @@ public static DotNetCliCommandResult Execute(DotNetCliCommand parameters)
 
         internal static string? GetDotNetSdkVersion()
         {
-            using (var process = new Process { StartInfo = BuildStartInfo(customDotNetCliPath: null, workingDirectory: string.Empty, arguments: "--version") })
+            using (var process = new Process { StartInfo = BuildStartInfo(customDotNetCliPath: null, workingDirectory: string.Empty, arguments: "--version", redirectStandardError: false) })
             using (new ConsoleExitHandler(process, NullLogger.Instance))
             {
                 try

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public static DotNetCliCommandResult Execute(DotNetCliCommand parameters)`
`56`	`56`
`57`	`57`	`internal static string? GetDotNetSdkVersion()`
`58`	`58`	`{`
`59`		`- using (var process = new Process { StartInfo = BuildStartInfo(customDotNetCliPath: null, workingDirectory: string.Empty, arguments: "--version") })`
	`59`	`+ using (var process = new Process { StartInfo = BuildStartInfo(customDotNetCliPath: null, workingDirectory: string.Empty, arguments: "--version", redirectStandardError: false) })`
`60`	`60`	`using (new ConsoleExitHandler(process, NullLogger.Instance))`
`61`	`61`	`{`
`62`	`62`	`try`