Skip to content

Commit e72ddfb

Browse files
authored
Fix add missing culuture info to ToString in RatioStyle (#1610)
RatioPrecisionTestWithBaseline(testDataKey: "Trend") is passing now for computers with different culture info
1 parent 641ffd5 commit e72ddfb

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/BenchmarkDotNet/Columns/BaselineRatioColumn.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,16 @@ public override string GetValue(Summary summary, BenchmarkCase benchmarkCase, St
6868
return isBaseline
6969
? "baseline"
7070
: ratio.Mean >= 1.0
71-
? "+" + ((ratio.Mean - 1.0) * 100).ToString(advancedPrecision ? "N1" : "N0") + "%"
72-
: "-" + ((1.0 - ratio.Mean) * 100).ToString(advancedPrecision ? "N1" : "N0") + "%";
71+
? "+" + ((ratio.Mean - 1.0) * 100).ToString(advancedPrecision ? "N1" : "N0", cultureInfo) + "%"
72+
: "-" + ((1.0 - ratio.Mean) * 100).ToString(advancedPrecision ? "N1" : "N0", cultureInfo) + "%";
7373
case RatioStyle.Trend:
7474
return isBaseline
7575
? "baseline"
7676
: ratio.Mean >= 1.0
77-
? ratio.Mean.ToString(advancedPrecision ? "N3" : "N2") + "x slower"
77+
? ratio.Mean.ToString(advancedPrecision ? "N3" : "N2", cultureInfo) + "x slower"
7878
: invertedRatio == null
7979
? "NA"
80-
: invertedRatio.Mean.ToString(advancedPrecision ? "N3" : "N2") + "x faster";
80+
: invertedRatio.Mean.ToString(advancedPrecision ? "N3" : "N2", cultureInfo) + "x faster";
8181
default:
8282
throw new ArgumentOutOfRangeException(nameof(summary), ratioStyle, "RatioStyle is not supported");
8383
}

0 commit comments

Comments
 (0)