chore: Suppress XmlException thrown internally on AppConfigGenerator::Generate method
#2817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filzrev
force-pushed
the
chore-suppress-exeption-thrown-when-nulltextreader
branch
from
cf21588 to
49be942
Compare
timcassell
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add extra check logics to avoid issue that
XmlExceptionis internally thrown whenTextReader.Nullis passed toAppConfigGenerator::Generatemethod.Background
When
Break on Exception thrownsetting is enabled on debugger attached environment.It's always interrupted by
XmlExceptionis thrown onAppConfigGenerator::Generatemethod.This PR fix this issue. By modifing code not throw exceptions on normal execution path.
Additional Changes
#nullable enablesetting onAppConfigGenerator.cs