Allow equals sign in value for parsed KVP Pairs

kkukshtel · kkukshtel · commit d63e495a199e · 2023-09-18T14:53:53.000-04:00
Splits the parsed substring into two parts around only the boundary of the first equals sign.
diff --git a/sources/ClangSharpPInvokeGenerator/Program.cs b/sources/ClangSharpPInvokeGenerator/Program.cs
@@ -852,9 +852,9 @@ private static void ParseKeyValuePairs(IEnumerable<string> keyValuePairs, List<s
 
         foreach (var keyValuePair in keyValuePairs)
         {
-            var parts = keyValuePair.Split('=');
+            var parts = keyValuePair.Split('=',2);
 
-            if (parts.Length != 2)
+            if (parts.Length < 2)
             {
                 errorList.Add($"Error: Invalid key/value pair argument: {keyValuePair}. Expected 'name=value'");
                 continue;

Original file line number	Diff line number	Diff line change
`@@ -852,9 +852,9 @@ private static void ParseKeyValuePairs(IEnumerable<string> keyValuePairs, List<s`
`852`	`852`
`853`	`853`	`foreach (var keyValuePair in keyValuePairs)`
`854`	`854`	`{`
`855`		`- var parts = keyValuePair.Split('=');`
	`855`	`+ var parts = keyValuePair.Split('=',2);`
`856`	`856`
`857`		`- if (parts.Length != 2)`
	`857`	`+ if (parts.Length < 2)`
`858`	`858`	`{`
`859`	`859`	`errorList.Add($"Error: Invalid key/value pair argument: {keyValuePair}. Expected 'name=value'");`
`860`	`860`	`continue;`