Fix warnings

Author: tom-englert

src/BasicSample/AssemblyInfo.cs

@@ -1,10 +1,5 @@
+using System;
 using System.Windows;
 
-[assembly: ThemeInfo(
-    ResourceDictionaryLocation.None, //where theme specific resource dictionaries are located
-                                     //(used if a resource is not found in the page,
-                                     // or application resource dictionaries)
-    ResourceDictionaryLocation.SourceAssembly //where the generic resource dictionary is located
-                                              //(used if a resource is not found in the page,
-                                              // app, or any theme specific resource dictionaries)
-)]
+[assembly: CLSCompliant(true)]
+[assembly: ThemeInfo(ResourceDictionaryLocation.None, ResourceDictionaryLocation.SourceAssembly)]

src/BasicSample/DataItem.cs

@@ -1,4 +1,6 @@
-namespace BasicSample
+#pragma warning disable CA5394 // Do not use insecure randomness
+
+namespace BasicSample
 {
     using System;
     using System.Windows;

src/BasicSample/DataProvider.cs

@@ -4,7 +4,7 @@
     using System.Collections.ObjectModel;
     using System.Linq;
 
-    public class DataProvider
+    public static class DataProvider
     {
         /// <summary>
         /// Provide a simple list of 100 random items.

src/DataGridExtensions/ColumnStyles.cs

@@ -59,14 +59,15 @@ private static void Columns_CollectionChanged(DataGridColumnStyleCollection styl
             if (args.Action != NotifyCollectionChangedAction.Add)
                 return;
 
-            var column = (DataGridColumn?)args.NewItems![0];
+            if (args.NewItems?[0] is not DataGridColumn column)
+                return;
 
             ApplyStyle(styles, column);
         }
 
-        private static void ApplyStyle(DataGridColumnStyleCollection styles, DependencyObject? column)
+        private static void ApplyStyle(DataGridColumnStyleCollection styles, DependencyObject column)
         {
-            var columnType = column?.GetType();
+            var columnType = column.GetType();
 
             var style = styles.FirstOrDefault(s => s.ColumnType == columnType);
             if (style == null)

src/DataGridExtensions/DataGridFilterColumn.cs

@@ -242,9 +242,9 @@ internal static bool Matches(this DataGridColumn? column, DataGrid dataGrid, obj
         /// Examines the property path and returns the objects value for this column.
         /// Filtering is applied on the SortMemberPath, this is the path used to create the binding.
         /// </summary>
-        internal static object? GetCellContentData(this DataGridColumn? column, object? item)
+        internal static object? GetCellContentData(this DataGridColumn column, object? item)
         {
-            var propertyPath = column?.SortMemberPath;
+            var propertyPath = column.SortMemberPath;
             if (item == null || string.IsNullOrEmpty(propertyPath))
             {
                 return null;

src/DataGridExtensions/ListBoxSelectAllBehavior.cs

@@ -72,18 +72,11 @@ private void ListBox_SelectionChanged(object? sender, EventArgs? e)
             {
                 _isListBoxUpdating = true;
 
-                if (listBox.Items.Count == listBox.SelectedItems.Count)
-                {
-                    AreAllFilesSelected = true;
-                }
-                else if (listBox.SelectedItems.Count == 0)
-                {
-                    AreAllFilesSelected = false;
-                }
-                else
-                {
-                    AreAllFilesSelected = null;
-                }
+                AreAllFilesSelected = listBox.Items.Count == listBox.SelectedItems.Count
+                    ? true
+                    : listBox.SelectedItems.Count == 0
+                        ? false
+                        : null;
             }
             finally
             {

src/DataGridExtensionsSample/AssemblyInfo.cs

@@ -0,0 +1,5 @@
+using System;
+using System.Windows;
+
+[assembly: CLSCompliant(false)]
+[assembly: ThemeInfo(ResourceDictionaryLocation.None, ResourceDictionaryLocation.SourceAssembly)]

src/DataGridExtensionsSample/Controls/FilterWithPopupControl.xaml.cs

@@ -84,31 +84,31 @@ private void Filter_Changed()
             Maximum = filter.Max;
         }
 
-        public class ContentFilter : IContentFilter
-        {
-            public ContentFilter(double min, double max)
-            {
-                Min = min;
-                Max = max;
-            }
+    }
 
-            public double Min { get; }
+    public class ContentFilter : IContentFilter
+    {
+        public ContentFilter(double min, double max)
+        {
+            Min = min;
+            Max = max;
+        }
 
-            public double Max { get; }
+        public double Min { get; }
 
-            public bool IsMatch(object? value)
-            {
-                if (value == null)
-                    return false;
+        public double Max { get; }
 
-                if (!double.TryParse(value.ToString(), out var number))
-                {
-                    return false;
-                }
+        public bool IsMatch(object? value)
+        {
+            if (value == null)
+                return false;
 
-                return (number >= Min) && (number <= Max);
+            if (!double.TryParse(value.ToString(), out var number))
+            {
+                return false;
             }
-        }
 
+            return (number >= Min) && (number <= Max);
+        }
     }
 }

src/DataGridExtensionsSample/Controls/IntegerGreatherThanFilterControl.xaml.cs

@@ -52,9 +52,9 @@ private void Filter_Changed(object newValue)
             textBox.Text = (newValue as ContentFilter)?.Value ?? string.Empty;
         }
 
-        class ContentFilter : IContentFilter
+        private class ContentFilter : IContentFilter
         {
-            readonly int _threshold;
+            private readonly int _threshold;
 
             public ContentFilter(int threshold)
             {

src/DataGridExtensionsSample/Infrastructure/DataItem.cs

@@ -1,4 +1,6 @@
-namespace DataGridExtensionsSample.Infrastructure
+#pragma warning disable CA5394 // Do not use insecure randomness
+
+namespace DataGridExtensionsSample.Infrastructure
 {
     using System;
     using System.Windows;