Merge pull request #871 from dotnet/fix870

AArnott · web-flow · commit 4c54ddd354f5 · 2022-12-05T13:38:40.000-07:00
Fix ArgumentNullException thrown when reading empty strings from git database
diff --git a/src/NerdBank.GitVersioning/ManagedGit/GitRepository.cs b/src/NerdBank.GitVersioning/ManagedGit/GitRepository.cs
@@ -719,6 +719,11 @@ private static bool TryConvertHexStringToByteArray(string hexString, Span<byte>
         /// </returns>
         public static unsafe string GetString(ReadOnlySpan<byte> bytes)
         {
+            if (bytes.Length == 0)
+            {
+                return string.Empty;
+            }
+
             fixed (byte* pBytes = bytes)
             {
                 return Encoding.GetString(pBytes, bytes.Length);

Original file line number	Diff line number	Diff line change
`@@ -719,6 +719,11 @@ private static bool TryConvertHexStringToByteArray(string hexString, Span<byte>`
`719`	`719`	`/// </returns>`
`720`	`720`	`public static unsafe string GetString(ReadOnlySpan<byte> bytes)`
`721`	`721`	`{`
	`722`	`+ if (bytes.Length == 0)`
	`723`	`+ {`
	`724`	`+ return string.Empty;`
	`725`	`+ }`
	`726`	`+`
`722`	`727`	`fixed (byte* pBytes = bytes)`
`723`	`728`	`{`
`724`	`729`	`return Encoding.GetString(pBytes, bytes.Length);`