Bump node.js to v20 (#1235)

Author: AArnott

.github/workflows/build.yml

@@ -50,6 +50,12 @@ jobs:
         Invoke-WebRequest -Uri "https://dot.net/v1/dotnet-install.ps1" -OutFile dotnet-install.ps1
         & .\dotnet-install.ps1 -Architecture x86 -Version 9.0.101 -InstallDir "C:\Program Files (x86)\dotnet\" -NoPath -Verbose
       if: runner.os == 'Windows'
+    - name: ⚙ Install node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version: 20.x
+        cache: yarn
+        cache-dependency-path: src/nerdbank-gitversioning.npm/yarn.lock
     - name: ⚙️ Set pipeline variables based on source
       run: tools/variables/_define.ps1
       shell: pwsh

CONTRIBUTING.md

@@ -10,7 +10,7 @@ It is highly recommended that anyone contributing to this library use the same
 software.
 
 1. [Visual Studio 2022][VS]
-2. [Node.js][NodeJs] v16 (v18 breaks our build)
+2. [Node.js][NodeJs] v20 (oldest LTS)
 
 ### Optional additional software
 

src/nerdbank-gitversioning.npm/package.json

@@ -4,7 +4,7 @@
   "description": "Stamps your NPM packages with semver 2.0 compliant git commit specific version information.",
   "author": {
     "name": "Andrew Arnott",
-    "email": "andrewarnott@gmail.com",
+    "email": "andrewarnott@live.com",
     "url": "http://blog.nerdbank.net/"
   },
   "bin": {
@@ -24,7 +24,7 @@
     "versioning"
   ],
   "devDependencies": {
-    "@types/node": "18.19.111",
+    "@types/node": "20.19.10",
     "del": "8.0.0",
     "gulp": "5.0.1",
     "gulp-cli": "3.1.0",

src/nerdbank-gitversioning.npm/yarn.lock

@@ -59,12 +59,12 @@
   resolved "https://registry.yarnpkg.com/@sindresorhus/merge-streams/-/merge-streams-2.3.0.tgz#719df7fb41766bc143369eaa0dd56d8dc87c9958"
   integrity sha512-LtoMMhxAlorcGhmFYI+LhPgbPZCkgP6ra1YL604EeF6U98pLlQ3iWIGMdWSC+vWmPBWBNgmDBAhnAobLROJmwg==
 
-"@types/node@18.19.111":
-  version "18.19.111"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-18.19.111.tgz#e95b89efc24cc625834b43bcd70bd5591a5dfba5"
-  integrity sha512-90sGdgA+QLJr1F9X79tQuEut0gEYIfkX9pydI4XGRgvFo9g2JWswefI+WUSUHPYVBHYSEfTEqBxA5hQvAZB3Mw==
+"@types/node@20.19.10":
+  version "20.19.10"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-20.19.10.tgz#8bee5d6fa97221d50d767fa5707a3dd6503e8f19"
+  integrity sha512-iAFpG6DokED3roLSP0K+ybeDdIX6Bc0Vd3mLW5uDqThPWtNos3E+EqOM11mPQHKzfWHqEBuLjIlsBQQ8CsISmQ==
   dependencies:
-    undici-types "~5.26.4"
+    undici-types "~6.21.0"
 
 acorn@^6.4.1:
   version "6.4.2"
@@ -2083,10 +2083,10 @@ undertaker@^2.0.0:
     last-run "^2.0.0"
     undertaker-registry "^2.0.0"
 
-undici-types@~5.26.4:
-  version "5.26.5"
-  resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-5.26.5.tgz#bcd539893d00b56e964fd2657a4866b221a65617"
-  integrity sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==
+undici-types@~6.21.0:
+  version "6.21.0"
+  resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-6.21.0.tgz#691d00af3909be93a7faa13be61b3a5b50ef12cb"
+  integrity sha512-iwDZqg0QAGrg9Rav5H4n0M64c3mkR59cJ6wQp+7C4nI0gsmExaedaYLNO44eT4AtBBwjbTiGPMlt2Md0T9H9JQ==
 
 unicorn-magic@^0.1.0:
   version "0.1.0"