Apply disposal pattern to the new dispose methods

Author: AArnott

src/NerdBank.GitVersioning/GitContext.cs

@@ -246,7 +246,10 @@ private protected static void FindGitPaths(string path, out string gitDirectory,
             }
         }
 
-        /// <inheritdoc />
+        /// <summary>
+        /// Disposes of native and managed resources associated by this object.
+        /// </summary>
+        /// <param name="disposing"><see langword="true" /> to dispose managed and native resources; <see langword="false" /> to only dispose of native resources.</param>
         protected virtual void Dispose(bool disposing)
         {
         }

src/NerdBank.GitVersioning/Managed/ManagedGitContext.cs

@@ -122,7 +122,12 @@ public override string GetShortUniqueCommitId(int minLength)
         /// <inheritdoc/>
         protected override void Dispose(bool disposing)
         {
-            this.Repository.Dispose();
+            if (disposing)
+            {
+                this.Repository.Dispose();
+            }
+
+            base.Dispose(disposing);
         }
 
         /// <summary>

src/NerdBank.GitVersioning/ManagedGit/GitPackCache.cs

@@ -54,7 +54,17 @@ public abstract class GitPackCache : IDisposable
         public abstract Stream Add(long offset, Stream stream);
 
         /// <inheritdoc/>
-        public virtual void Dispose()
+        public void Dispose()
+        {
+            this.Dispose(true);
+            GC.SuppressFinalize(this);
+        }
+
+        /// <summary>
+        /// Disposes of native and managed resources associated by this object.
+        /// </summary>
+        /// <param name="disposing"><see langword="true" /> to dispose managed and native resources; <see langword="false" /> to only dispose of native resources.</param>
+        protected virtual void Dispose(bool disposing)
         {
         }
     }

src/NerdBank.GitVersioning/ManagedGit/GitPackMemoryCache.cs

@@ -58,15 +58,20 @@ public override void GetCacheStatistics(StringBuilder builder)
         }
 
         /// <inheritdoc/>
-        public override void Dispose()
+        protected override void Dispose(bool disposing)
         {
-            while (this.cache.Count > 0)
+            if (disposing)
             {
-                var key = this.cache.Keys.First();
-                var stream = this.cache[key];
-                stream.Dispose();
-                this.cache.Remove(key);
+                while (this.cache.Count > 0)
+                {
+                    var key = this.cache.Keys.First();
+                    var stream = this.cache[key];
+                    stream.Dispose();
+                    this.cache.Remove(key);
+                }
             }
+
+            base.Dispose(disposing);
         }
     }
 }

src/NerdBank.GitVersioning/ManagedGit/GitPackMemoryCacheStream.cs

@@ -101,8 +101,13 @@ public override void Write(byte[] buffer, int offset, int count)
 
         protected override void Dispose(bool disposing)
         {
-            this.stream.Dispose();
-            this.cacheStream.Dispose();
+            if (disposing)
+            {
+                this.stream.Dispose();
+                this.cacheStream.Dispose();
+            }
+
+            base.Dispose(disposing);
         }
 
         private void DisposeStreamIfRead()

src/NerdBank.GitVersioning/ManagedGit/MemoryMappedStream.cs

@@ -144,8 +144,13 @@ public override void Write(byte[] buffer, int offset, int count)
         /// <inheritdoc/>
         protected override void Dispose(bool disposing)
         {
-            this.accessor.SafeMemoryMappedViewHandle.ReleasePointer();
-            this.disposed = true;
+            if (disposing)
+            {
+                this.accessor.SafeMemoryMappedViewHandle.ReleasePointer();
+                this.disposed = true;
+            }
+
+            base.Dispose(disposing);
         }
     }
 }