Skip to content

Commit 9db531a

Browse files
committed
Use SemVer 2.0 for NPM packages
This has been around and supported for at least six years in NPM. Fixes #236
1 parent 6a77c77 commit 9db531a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/NerdBank.GitVersioning.Tests/VersionOracleTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ public void DefaultNuGetPackageVersionIsSemVer1NonPublicRelease()
193193
}
194194

195195
[Fact]
196-
public void NpmPackageVersionIsSemVer1()
196+
public void NpmPackageVersionIsSemVer2()
197197
{
198198
VersionOptions workingCopyVersion = new VersionOptions
199199
{
@@ -204,7 +204,7 @@ public void NpmPackageVersionIsSemVer1()
204204
this.InitializeSourceControl();
205205
var oracle = VersionOracle.Create(this.RepoPath);
206206
oracle.PublicRelease = true;
207-
Assert.Equal("7.8.9-foo-25", oracle.NpmPackageVersion);
207+
Assert.Equal("7.8.9-foo.25", oracle.NpmPackageVersion);
208208
}
209209

210210
[Fact]

src/NerdBank.GitVersioning/VersionOracle.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ public IDictionary<string, string> CloudBuildVersionVars
340340
/// <summary>
341341
/// Gets the version to use for NPM packages.
342342
/// </summary>
343-
public string NpmPackageVersion => this.SemVer1;
343+
public string NpmPackageVersion => this.SemVer2;
344344

345345
/// <summary>
346346
/// Gets a SemVer 1.0 compliant string that represents this version, including the -gCOMMITID suffix

src/nerdbank-gitversioning.npm/ts/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ export async function setPackageVersion(packageDirectory?: string, srcDirectory?
6666
packageDirectory = packageDirectory || '.';
6767
srcDirectory = srcDirectory || packageDirectory;
6868
const gitVersion = await getVersion(srcDirectory);
69-
console.log(`Setting package version to ${gitVersion.semVer1}`);
70-
var result = await execAsync(`npm version ${gitVersion.semVer1} --no-git-tag-version`, { cwd: packageDirectory });
69+
console.log(`Setting package version to ${gitVersion.npmPackageVersion}`);
70+
var result = await execAsync(`npm version ${gitVersion.npmPackageVersion} --no-git-tag-version`, { cwd: packageDirectory });
7171
if (result.stderr) {
7272
console.log(result.stderr);
7373
}

0 commit comments

Comments
 (0)