Merge pull request #700 from dotnet/fix140

Suppress CA2243 in generated AssemblyInfo file

Author: AArnott

src/NerdBank.GitVersioning.Tests/AssemblyInfoTest.cs

@@ -57,6 +57,8 @@ public void FSharpGenerator(bool? thisAssemblyClass)
 // </auto-generated>
 //------------------------------------------------------------------------------
 
+#nowarn ""CA2243""
+
 namespace AssemblyInfo
 [<assembly: System.Reflection.AssemblyVersionAttribute(""1.3.0.0"")>]
 [<assembly: System.Reflection.AssemblyFileVersionAttribute(""1.3.1.0"")>]
@@ -133,6 +135,8 @@ public void CSharpGenerator(bool? thisAssemblyClass)
 // </auto-generated>
 //------------------------------------------------------------------------------
 
+#pragma warning disable CA2243
+
 [assembly: System.Reflection.AssemblyVersionAttribute(""1.3.0.0"")]
 [assembly: System.Reflection.AssemblyFileVersionAttribute(""1.3.1.0"")]
 [assembly: System.Reflection.AssemblyInformationalVersionAttribute("""")]
@@ -188,6 +192,8 @@ public void VisualBasicGenerator(bool? thisAssemblyClass)
 ' </auto-generated>
 '------------------------------------------------------------------------------
 
+#Disable Warning CA2243
+
 <Assembly: System.Reflection.AssemblyVersionAttribute(""1.3.0.0"")>
 <Assembly: System.Reflection.AssemblyFileVersionAttribute(""1.3.1.0"")>
 <Assembly: System.Reflection.AssemblyInformationalVersionAttribute("""")>

src/Nerdbank.GitVersioning.Tasks/AssemblyVersionInfo.cs

@@ -315,6 +315,8 @@ public string BuildCode()
             {
                 this.generator.AddComment(FileHeaderComment);
                 this.generator.AddBlankLine();
+                this.generator.AddAnalysisSuppressions();
+                this.generator.AddBlankLine();
                 this.generator.EmitNamespaceIfRequired(this.RootNamespace ?? "AssemblyInfo");
                 this.GenerateAssemblyAttributes();
 
@@ -545,6 +547,13 @@ internal CodeGenerator()
                 this.codeBuilder = new StringBuilder();
             }
 
+            protected virtual IEnumerable<string> WarningCodesToSuppress { get; } = new string[]
+            {
+                "CA2243", // Attribute string literals should parse correctly
+            };
+
+            internal abstract void AddAnalysisSuppressions();
+
             internal abstract void AddComment(string comment);
 
             internal abstract void DeclareAttribute(Type type, string arg);
@@ -586,6 +595,11 @@ protected void AddCodeComment(string comment, string token)
 
         private class FSharpCodeGenerator : CodeGenerator
         {
+            internal override void AddAnalysisSuppressions()
+            {
+                this.codeBuilder.AppendLine($"#nowarn {string.Join(" ", this.WarningCodesToSuppress.Select(c => $"\"{c}\""))}");
+            }
+
             internal override void AddComment(string comment)
             {
                 this.AddCodeComment(comment, "//");
@@ -636,6 +650,11 @@ internal override void StartThisAssemblyClass()
 
         private class CSharpCodeGenerator : CodeGenerator
         {
+            internal override void AddAnalysisSuppressions()
+            {
+                this.codeBuilder.AppendLine($"#pragma warning disable {string.Join(", ", this.WarningCodesToSuppress)}");
+            }
+
             internal override void AddComment(string comment)
             {
                 this.AddCodeComment(comment, "//");
@@ -680,6 +699,11 @@ internal override void EndThisAssemblyClass()
 
         private class VisualBasicCodeGenerator : CodeGenerator
         {
+            internal override void AddAnalysisSuppressions()
+            {
+                this.codeBuilder.AppendLine($"#Disable Warning {string.Join(", ", this.WarningCodesToSuppress)}");
+            }
+
             internal override void AddComment(string comment)
             {
                 this.AddCodeComment(comment, "'");