Merge pull request #844 from dotnet/renovate/major-eslint-monorepo

Update dependency eslint to v9

Author: AArnott

.github/workflows/build.yml

@@ -58,10 +58,10 @@ jobs:
       run: dotnet publish -c Release -r ${{ matrix.rid }}-x64 -warnaserror
       working-directory: test/NativeAOTCompatibility
 
-    - name: ⚙️ Use Node.js 16.x
+    - name: ⚙️ Use Node.js 20.x
       uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
       with:
-        node-version: 16.x
+        node-version: 20.x
     - name: ⚙️ yarn
       run: |
         npm install -g yarn@1.x

src/nerdbank-streams/.eslintrc.json

@@ -0,0 +1,46 @@
+const typescriptEslint = require('@typescript-eslint/eslint-plugin')
+const prettier = require('eslint-plugin-prettier')
+const tsParser = require('@typescript-eslint/parser')
+const prettierConfig = require('eslint-config-prettier')
+
+module.exports = [
+	{
+		files: ['**/*.ts'],
+		languageOptions: {
+			parser: tsParser,
+			parserOptions: {
+				ecmaVersion: 6,
+				sourceType: 'module',
+			},
+		},
+		plugins: {
+			'@typescript-eslint': typescriptEslint,
+			prettier: prettier,
+		},
+		rules: {
+			'@typescript-eslint/semi': 'off',
+			curly: 'warn',
+			'object-curly-spacing': 'off',
+			eqeqeq: 'warn',
+			'no-throw-literal': 'error',
+			'no-unexpected-multiline': 'error',
+			semi: 'off',
+			'prettier/prettier': [
+				'error',
+				{
+					printWidth: 160,
+					semi: false,
+					singleQuote: true,
+					trailingComma: 'es5',
+					useTabs: true,
+					endOfLine: 'auto',
+					arrowParens: 'avoid',
+				},
+			],
+			...prettierConfig.rules,
+		},
+	},
+	{
+		ignores: ['out/**', 'dist/**', '**/*.d.ts'],
+	},
+]

src/nerdbank-streams/eslint.config.js

@@ -38,7 +38,7 @@
     "@types/promise": "7.1.30",
     "@typescript-eslint/eslint-plugin": "5.62.0",
     "@typescript-eslint/parser": "5.62.0",
-    "eslint": "8.57.1",
+    "eslint": "9.39.2",
     "eslint-config-prettier": "10.1.8",
     "eslint-plugin-import": "2.32.0",
     "eslint-plugin-jsx-a11y": "6.10.2",

src/nerdbank-streams/package.json

@@ -1,7 +1,6 @@
 import { Duplex, PassThrough } from 'stream'
 
 export class FullDuplexStream {
-	// eslint-disable-next-line @typescript-eslint/naming-convention
 	public static CreatePair(): { first: Duplex; second: Duplex } {
 		const pass1 = new PassThrough()
 		const pass2 = new PassThrough()
@@ -11,7 +10,6 @@ export class FullDuplexStream {
 		}
 	}
 
-	// eslint-disable-next-line @typescript-eslint/naming-convention
 	public static Splice(readable: NodeJS.ReadableStream, writable: NodeJS.WritableStream): Duplex {
 		const duplex = new Duplex({
 			write(chunk, encoding, callback) {

src/nerdbank-streams/src/FullDuplexStream.ts

@@ -63,7 +63,7 @@ export abstract class MultiplexingStream implements IDisposableObservable {
 	 * @param cancellationToken A token whose cancellation aborts the handshake with the remote end.
 	 * @returns The multiplexing stream, once the handshake is complete.
 	 */
-	// eslint-disable-next-line @typescript-eslint/naming-convention
+
 	public static async CreateAsync(
 		stream: NodeJS.ReadWriteStream,
 		options?: MultiplexingStreamOptions,
@@ -108,7 +108,7 @@ export abstract class MultiplexingStream implements IDisposableObservable {
 	 * @param options Options to customize the behavior of the stream.
 	 * @returns The multiplexing stream.
 	 */
-	// eslint-disable-next-line @typescript-eslint/naming-convention
+
 	public static Create(stream: NodeJS.ReadWriteStream, options?: MultiplexingStreamOptions): MultiplexingStream {
 		options ??= { protocolMajorVersion: 3 }
 		options.protocolMajorVersion ??= 3
@@ -130,7 +130,7 @@ export abstract class MultiplexingStream implements IDisposableObservable {
 	/**
 	 * The encoding used for characters in control frames.
 	 */
-	// eslint-disable-next-line @typescript-eslint/naming-convention
+
 	static readonly ControlFrameEncoding = 'utf-8'
 
 	protected readonly _completionSource = new Deferred<void>()

src/nerdbank-streams/src/MultiplexingStream.ts

@@ -13,18 +13,18 @@ export interface QualifiedChannelId {
  */
 export enum ChannelSource {
 	/** The channel was offered by this MultiplexingStream instance to the other party. */
-	// eslint-disable-next-line @typescript-eslint/naming-convention
+
 	Local = 1,
 
 	/** The channel was offered to this MultiplexingStream instance by the other party. */
-	// eslint-disable-next-line @typescript-eslint/naming-convention
+
 	Remote = -1,
 
 	/**
 	 * The channel was seeded during construction via the Options.SeededChannels collection.
 	 * This channel is to be accepted by both parties.
 	 */
-	// eslint-disable-next-line @typescript-eslint/naming-convention
+
 	Seeded = 0,
 }
 

src/nerdbank-streams/src/QualifiedChannelId.ts

@@ -12,7 +12,6 @@ import { MultiplexingStream } from '../MultiplexingStream'
 		let procExited: Deferred<any>
 		const spawnOptions: SpawnOptions = {
 			env: {
-				// eslint-disable-next-line @typescript-eslint/naming-convention
 				DOTNET_SKIP_FIRST_TIME_EXPERIENCE: '1', // prevent warnings in stdout that corrupt our interop stream.
 			},
 		}