WebSocketStream graceful closure

[lostmsu]

I have a client that writes text to a WebSocket line by line. Server uses new StreamReader(serverSocket.AsStream()) + ReadLine calls to read this text.

The issue is if I explicitly close the connection on the client side using CloseOutputAsync(NormalClosure, "Done", CancellationToken.None) ReadLine on the server fails with IOException "The remote end closed the connection".

What I expected, however, was null return from ReadLine (I guess consequentially, I expected WebSocketStream.Read call to return 0 when graceful close message received.

I was wondering if this is a bug, or just a case of leaky abstraction.

Documentation for NetworkStream.Read says 0 is returned if the remote party performed a graceful shutdown.

[AArnott]

or just a case of leaky abstraction.

I'd say this. But I agree with you a 0 byte read would be preferable, particularly for a normal shutdown.

I'd accept a PR if you can offer a fix.