Memory leak in 3.0.2

[ks0thish]

We migrate DocumentFormat.OpenXml - 3.0.2 recently and notice Cellvalue and cell memory are not dispose after xl has been generated

is there is any way to clear this?

[ks0thish]

Attaching detailed SS is this Excepted?

[twsouthwick]

Can you share a repro of what you're doing? Have you tried with 3.2.0?

[ks0thish]

using (SpreadsheetDocument document = SpreadsheetDocument.Create(exportRequest.Stream!, SpreadsheetDocumentType.Workbook))
            {
                WorkbookPart workbookPart = document.AddWorkbookPart();
                workbookPart.Workbook = new Workbook();

                WorkbookStylesPart wbsp = workbookPart.AddNewPart<WorkbookStylesPart>();
                wbsp.Stylesheet = GenerateStylesheet(exportRequest.DateOnly);
                wbsp.Stylesheet.Save();

                Sheets sheets = workbookPart.Workbook.AppendChild(new Sheets());

                int rowCount = 0;
                int sheetCount = 1;
                int totalCols = GetColumnCount(exportRequest);

                // Fix 1: Changed to use worksheetPart for OpenXmlWriter creation
                var sheetDataWithColumnInfo = AddWorkSheet(workbookPart, sheets, exportRequest, sheetCount, columnsToInclude, out OpenXmlWriter oxw);

                while (HasNextRow(exportRequest, rowCount))
                {
                    oxw.WriteStartElement(new Row());

                    for (int count = 0; count < totalCols; count++)
                    {
                        if (sheetDataWithColumnInfo.ColumnNumbers!.Contains(count))
                        {
                            Cell cell = new Cell();
                            Type fieldType = GetFieldType(exportRequest, rowCount, count);

                            if (reader != null)
                            {
                                AssignCellValue(cell, reader, count, fieldType, isEncryptedDb, isUserNameEncoded, encodedColumns);
                            }
                            else
                            {
                                AssignCellValue(cell, exportRequest.DataList!.ElementAt(rowCount)!, count, fieldType, isEncryptedDb, isUserNameEncoded, encodedColumns!);
                            }

                            oxw.WriteElement(cell);
                        }
                    }

                    oxw.WriteEndElement(); // Close the row
                    rowCount++;

                    // Fix 2: Close and create new sheet after hitting row limit
                    if (rowCount % 1048570 == 0)
                    {
                        oxw.WriteEndElement(); // Close SheetData
                        oxw.WriteEndElement(); // Close Worksheet
                        oxw.Close(); // Close the OpenXmlWriter for the current sheet

                        sheetCount++;
                        sheetDataWithColumnInfo = AddWorkSheet(workbookPart, sheets, exportRequest, sheetCount, columnsToInclude, out oxw); // Start new sheet
                    }
                }

                // Close last sheet properly
                oxw.WriteEndElement(); // Close SheetData
                oxw.WriteEndElement(); // Close Worksheet
                oxw.Close(); // Final close
                oxw.Dispose();
                // Fix 6: Explicitly save the workbook
                workbookPart.Workbook.Save();
            }


            private void AssignCellValue(Cell cell, IDataReader reader, int count, Type fieldType, bool isEncryptedDb, bool isUserNameEncoded = false, List<string>? encodedColumns = null)
        {
            if (!reader.IsDBNull(count))
            {
                if (fieldType == typeof(int))
                {
                    cell.DataType = CellValues.Number;
                    cell.CellValue = new CellValue(reader.GetInt32(count));
                }
                else if (fieldType == typeof(decimal))
                {
                    cell.DataType = CellValues.Number;
                    cell.CellValue = new CellValue(reader.GetDecimal(count));
                }
                else if (fieldType == typeof(double))
                {
                    cell.DataType = CellValues.Number;
                    cell.CellValue = new CellValue(reader.GetDouble(count));
                }
                else if (fieldType == typeof(float))
                {
                    cell.DataType = CellValues.Number;
                    cell.CellValue = new CellValue(reader.GetFloat(count));
                }
                else if (fieldType == typeof(DateTime))
                {
                    cell.DataType = CellValues.Number;
                    cell.CellValue = new CellValue(reader.GetDateTime(count).ToOADate());
                    cell.StyleIndex = 1;
                }
                else if (fieldType == typeof(bool))
                {
                    cell.DataType = CellValues.Boolean;
                    cell.CellValue = new CellValue(reader.GetBoolean(count));
                }
                else
                {
                    cell.DataType = CellValues.String;

                        cell.CellValue = new CellValue(value);

                }
            }
            else
            {
                cell.DataType = CellValues.String;
                cell.CellValue = new CellValue("-");
                if (fieldType == typeof(int) || fieldType == typeof(decimal) || fieldType == typeof(float))
                {
                    cell.StyleIndex = 3;
                }
            }
        }

        private void AssignCellValue(Cell cell, Dictionary<string, object> item, int count, Type fieldType, bool isEncryptedDb, bool isUserNameEncoded = false, List<string>? encodedColumns = null)
        {
            cell.DataType = CellValues.String;
            var value = item.ElementAt(count).Value;
            string? cellValue;
            if(value != null)
            {
                cellValue = Convert.ToString(value);
            }
            else
            {
                cellValue = string.Empty;
            }
            var header = item.ElementAt(count).Key;
                cell.CellValue = new CellValue(cellValue!);

        }`

@twsouthwick added my code

[twsouthwick]

Does it repro on 3.3.0?

[ks0thish]

@twsouthwick NO we are using 3.0.2

[twsouthwick]

Since you're saying it doesn't repro on 3.3.0, please update to that