Add IKeyboard.IsScancodePressed and implement it on backends

Author: ThomasMiz

src/Input/Silk.NET.Input.Common/Interfaces/IKeyboard.cs

@@ -28,6 +28,13 @@ public interface IKeyboard : IInputDevice
         /// <returns>Whether or not the key is pressed.</returns>
         bool IsKeyPressed(Key key);
 
+        /// <summary>
+        /// Checks if a specific scancode is pressed.
+        /// </summary>
+        /// <param name="scancode">The scancode to check.</param>
+        /// <returns>Whether or not the scancode is pressed.</returns>
+        bool IsScancodePressed(int scancode);
+
         /// <summary>
         /// Called when a key is pressed.
         /// </summary>

src/Input/Silk.NET.Input.Common/PublicAPI/netstandard2.1/PublicAPI.Unshipped.txt

@@ -1 +1,2 @@
 #nullable enable
+Silk.NET.Input.IKeyboard.IsScancodePressed(int scancode) -> bool

src/Input/Silk.NET.Input.Glfw/GlfwKeyboard.cs

@@ -18,6 +18,8 @@ internal class GlfwKeyboard : IKeyboard, IGlfwSubscriber
         private unsafe WindowHandle* _handle;
         private GlfwCallbacks.CharCallback? _char;
         private GlfwCallbacks.KeyCallback? _key;
+        private List<int> _scancodesDown = new List<int>();
+
         public string Name { get; } = "Silk.NET Keyboard (via GLFW)";
         public int Index { get; } = 0;
         public bool IsConnected { get; } = true;
@@ -31,6 +33,8 @@ public unsafe string ClipboardText
         public unsafe bool IsKeyPressed
             (Key key) => GlfwProvider.GLFW.Value.GetKey(_handle, ConvertKey(key)) == (int) InputAction.Press;
 
+        public unsafe bool IsScancodePressed(int scancode) => _scancodesDown.Contains(scancode);
+
         public event Action<IKeyboard, Key, int>? KeyDown;
         public event Action<IKeyboard, Key, int>? KeyUp;
         public event Action<IKeyboard, char>? KeyChar;
@@ -49,13 +53,22 @@ public unsafe void Subscribe(GlfwEvents events)
             _handle = events.Handle;
             events.Char += _char = (_, c) => KeyChar?.Invoke(this, (char) c);
             events.Key += _key = (_, key, code, action, mods) =>
-                (action switch
+            {
+                Action<IKeyboard, Key, int>? evt = null;
+                switch(action)
                 {
-                    InputAction.Press => KeyDown,
-                    InputAction.Release => KeyUp,
-                    InputAction.Repeat => null,
-                    _ => null
-                })?.Invoke(this, ConvertKey(key), code);
+                    case InputAction.Press:
+                        evt = KeyDown;
+                        _scancodesDown.Add(code);
+                        break;
+                    case InputAction.Release:
+                        evt = KeyUp;
+                        _scancodesDown.Remove(code);
+                        break;
+                }
+
+                evt?.Invoke(this, ConvertKey(key), code);
+            };
         }
 
         public void Unsubscribe(GlfwEvents events)

src/Input/Silk.NET.Input.Sdl/SdlKeyboard.cs

@@ -9,7 +9,7 @@ namespace Silk.NET.Input.Sdl
     internal partial class SdlKeyboard : IKeyboard, ISdlDevice
     {
         private readonly SdlInputContext _ctx;
-        private List<Key> _keysDown = new List<Key>();
+        private List<Scancode> _scancodesDown = new List<Scancode>();
 
         public SdlKeyboard(SdlInputContext ctx)
         {
@@ -27,7 +27,8 @@ public string ClipboardText
             get => _ctx.Sdl.GetClipboardTextS();
             set => _ctx.Sdl.SetClipboardText(value);
         }
-        public bool IsKeyPressed(Key key) => _keysDown.Contains(key);
+        public bool IsKeyPressed(Key key) => _scancodesDown.Any(x => _keyMap.TryGetValue(x, out Key skey) && key == skey);
+        public bool IsScancodePressed(int scancode) => _scancodesDown.Contains((Scancode) scancode);
         public event Action<IKeyboard, Key, int>? KeyDown;
         public event Action<IKeyboard, Key, int>? KeyUp;
         public event Action<IKeyboard, char>? KeyChar;
@@ -46,13 +47,13 @@ public unsafe void DoEvent(Event @event)
                         if (_keyMap.TryGetValue(@event.Key.Keysym.Scancode, out var key))
                         {
                             keyDown = key;
-                            _keysDown.Add(keyDown);
                         }
                         else
                         {
                             keyDown = Key.Unknown;
                         }
 
+                        _scancodesDown.Add(@event.Key.Keysym.Scancode);
                         KeyDown?.Invoke(this, keyDown, (int) @event.Key.Keysym.Scancode);
                     }
 
@@ -66,13 +67,13 @@ public unsafe void DoEvent(Event @event)
                         if (_keyMap.TryGetValue(@event.Key.Keysym.Scancode, out var key))
                         {
                             keyUp = key;
-                            _keysDown.Remove(keyUp);
                         }
                         else
                         {
                             keyUp = Key.Unknown;
                         }
 
+                        _scancodesDown.Remove(@event.Key.Keysym.Scancode);
                         KeyUp?.Invoke(this, keyUp, (int) @event.Key.Keysym.Scancode);
                     }