Build improvements, dynamic Windows SDK resolution, bugfixes (#661)

* Build improvements & dynamic Windows SDK resolution (backport from 3.0)

* Changes to some code formatting

* Fix build errors

* Fix build error

* Enhanced typedef-powered renaming

* Fix #652

* Marshal generic pointers in COM vtable wrapper functions

* String generation improvements (fixes #630)

* Sanity check, remove JetBrains.Annotations

Author: Perksey

src/infrastructure/Silk.NET.NUKE/Build.cs

@@ -4,7 +4,7 @@
 using System.Linq;
 using System.Runtime.InteropServices;
 using System.Threading.Tasks;
-using JetBrains.Annotations;
+
 using Nuke.Common;
 using Nuke.Common.Execution;
 using Nuke.Common.IO;
@@ -92,7 +92,7 @@ bool HasDesktopMsBuild
 
     [Solution] readonly Solution Solution;
 
-    [CanBeNull] Dictionary<string, (Solution Solution, bool UseDesktopMSBuild)> SolutionsValue;
+    Dictionary<string, (Solution Solution, bool UseDesktopMSBuild)>? SolutionsValue;
 
     Dictionary<string, (Solution Solution, bool UseDesktopMSBuild)> Solutions
         => SolutionsValue ??= Projects.ProcessSolution(Solution, FeatureSets, HasDesktopMsBuild);
@@ -157,7 +157,7 @@ Dictionary<string, object> ProcessedMsbuildProperties
                             "extension) to the AllowedExclusions array in the NUKE Build.cs file."
                         );
 
-                        missedOut.Add(file);
+                        missedOut.Add(Path.GetRelativePath(RootDirectory, file));
                     }
                 }
 
@@ -180,6 +180,7 @@ Dictionary<string, object> ProcessedMsbuildProperties
         (
             () =>
             {
+                var outputs = Enumerable.Empty<Output>();
                 if (!HasProcessedSolutions)
                 {
                     var slnDir = Path.Combine(Solution.Directory!, "build", "sln");
@@ -202,21 +203,27 @@ Dictionary<string, object> ProcessedMsbuildProperties
                     Logger.Info($"Cleaning feature set \"{key}\" ({sln})");
                     if (useDesktopMsBuild)
                     {
-                        MSBuild
+                        outputs = outputs.Concat
                         (
-                            s => s.SetTargets("Clean")
-                                .SetMaxCpuCount(Environment.ProcessorCount)
-                                .SetProperties(ProcessedMsbuildProperties)
-                                .SetTargetPath(sln)
+                            MSBuild
+                            (
+                                s => s.SetTargets("Clean")
+                                    .SetMaxCpuCount(Environment.ProcessorCount)
+                                    .SetProperties(ProcessedMsbuildProperties)
+                                    .SetTargetPath(sln)
+                            )
                         );
                     }
                     else
                     {
-                        DotNetClean
+                        outputs = outputs.Concat
                         (
-                            s => s.SetProject(sln)
-                                .SetConfiguration(Configuration)
-                                .SetProperties(ProcessedMsbuildProperties)
+                            DotNetClean
+                            (
+                                s => s.SetProject(sln)
+                                    .SetConfiguration(Configuration)
+                                    .SetProperties(ProcessedMsbuildProperties)
+                            )
                         );
                     }
                 }
@@ -228,12 +235,21 @@ Dictionary<string, object> ProcessedMsbuildProperties
 
                 Directory.CreateDirectory(RootDirectory / "build" / "output_packages");
 
-                var silkDroid = SourceDirectory / "Windowing" / "Android" / "SilkDroid";
-                using var process = RuntimeInformation.IsOSPlatform(OSPlatform.Linux)
-                    ? StartProcess("bash", "-c \"./gradlew clean\"", silkDroid)
-                    : StartProcess("cmd", "/c \".\\gradlew clean\"", silkDroid);
-                process.AssertZeroExitCode();
-                return process.Output;
+                if (FeatureSets.Any(x => x.Equals("native", StringComparison.OrdinalIgnoreCase)))
+                {
+                    var silkDroid = SourceDirectory / "Windowing" / "Android" / "SilkDroid";
+                    using var process = RuntimeInformation.IsOSPlatform(OSPlatform.Linux)
+                        ? StartProcess("bash", "-c \"./gradlew clean\"", silkDroid)
+                        : StartProcess("cmd", "/c \".\\gradlew clean\"", silkDroid);
+                    process.AssertZeroExitCode();
+                    outputs = outputs.Concat(process.Output);
+                }
+                else
+                {
+                    Logger.Warn("Skipping gradlew clean as the \"native\" feature-set has not been specified.");
+                }
+
+                return outputs;
             }
         );
 
@@ -300,7 +316,7 @@ Dictionary<string, object> ProcessedMsbuildProperties
                             s => s
                                 .SetProjectFile(sln)
                                 .SetConfiguration(Configuration)
-                                .SetNoRestore(true)
+                                .EnableNoRestore()
                                 .SetProperties(ProcessedMsbuildProperties)
                         );
                     }
@@ -357,6 +373,12 @@ Dictionary<string, object> ProcessedMsbuildProperties
         (
             () =>
             {
+                if (!FeatureSets.Any(x => x.Equals("native", StringComparison.OrdinalIgnoreCase)))
+                {
+                    Logger.Warn("Skipping gradlew build as the \"native\" feature-set has not been specified.");
+                    return Enumerable.Empty<Output>();
+                }
+                
                 var sdl = RootDirectory / "build" / "submodules" / "SDL";
                 var silkDroid = SourceDirectory / "Windowing" / "Android" / "SilkDroid";
                 var xcopy = new (string, string)[]
@@ -425,7 +447,7 @@ Dictionary<string, object> ProcessedMsbuildProperties
                             s => s
                                 .SetProject(sln)
                                 .SetConfiguration(Configuration)
-                                .SetNoRestore(true)
+                                .EnableNoRestore()
                                 .SetProperties(ProcessedMsbuildProperties)
                         );
                     }
@@ -448,21 +470,25 @@ Dictionary<string, object> ProcessedMsbuildProperties
     static IEnumerable<string> Packages => Directory.GetFiles(PackageDirectory, "*.nupkg")
         .Where(x => Path.GetFileName(x).StartsWith("Silk.NET") || Path.GetFileName(x).StartsWith("Ultz.Native"));
 
-    async Task PushPackages()
+    async Task<IEnumerable<Output>> PushPackages()
     {
+        var outputs = Enumerable.Empty<Output>();
         const int rateLimit = 300;
         if (!string.IsNullOrWhiteSpace(SignUsername) && !string.IsNullOrWhiteSpace(SignPassword))
         {
             var basePath = RootDirectory / "build" / "codesigning";
             var execPath = basePath / "tool" / (OperatingSystem.IsWindows() ? "SignClient.exe" : "SignClient");
             if (!File.Exists(execPath))
             {
-                DotNetToolInstall(s => s.SetToolInstallationPath(basePath / "tool").SetPackageName("SignClient"));
+                outputs = outputs.Concat
+                (
+                    DotNetToolInstall(s => s.SetToolInstallationPath(basePath / "tool").SetPackageName("SignClient"))
+                );
             }
 
             foreach (var pkg in Packages)
             {
-                StartProcess
+                var proc = StartProcess
                 (
                     execPath,
                     "sign " +
@@ -475,7 +501,10 @@ async Task PushPackages()
                     "--name \"Silk.NET\" " +
                     "--description \"Silk.NET\" " +
                     "--descriptionUrl \"https://github.com/dotnet/Silk.NET\""
-                ).AssertZeroExitCode();
+                );
+
+                proc.AssertZeroExitCode();
+                outputs = outputs.Concat(proc.Output);
             }
         }
 
@@ -484,11 +513,6 @@ async Task PushPackages()
             .Select(x => x.Select(v => v.Value).ToList())
             .ToList();
         var first = true;
-        var pushed = 0;
-        var feed = NuGetInterface.OpenNuGetFeed(NugetFeed, NugetUsername, NugetPassword);
-        var uploadResource = await NuGetInterface.GetUploadResourceAsync(feed);
-        var symbolsResource = await NuGetInterface.GetSymbolsUploadResourceAsync(feed);
-        var exceptions = new List<Exception>();
         Logger.Info($"Searching for packages in \"{RootDirectory / "build" / "output_packages"}\"...");
         foreach (var files in allFiles)
         {
@@ -501,33 +525,33 @@ async Task PushPackages()
                 await Task.Delay(TimeSpan.FromHours(1));
             }
 
-            foreach (var file in files)
+            var srcSettings = new DotNetNuGetAddSourceSettings().SetName("Silk-PushPackages").SetSource(NugetFeed);
+            if (NugetUsername is not null || NugetPassword is not null)
             {
-                try
-                {
-                    await NuGetInterface.UploadPackageAsync
-                        (uploadResource, NugetNoServiceEndpoint, file, NugetApiKey, symbolsResource);
-                    pushed++;
-                }
-                catch (Exception ex)
+                if (NugetUsername is null || NugetPassword is null)
                 {
-                    if (file.Contains(".Native.")) // native packages have their own update cycle
-                    {
-                        Logger.Warn(ex);
-                    }
-                    else
-                    {
-                        exceptions.Add(new Exception($"Failed to push package \"{file}\"", ex));
-                    }
+                    ControlFlow.Fail
+                    (
+                        "Both \"NugetUsername\" and \"NugetPassword\" must be specified if either are used."
+                    );
                 }
+
+                srcSettings = srcSettings.SetUsername(NugetUsername).SetPassword(NugetPassword);
             }
-        }
+            
+            outputs = outputs.Concat(DotNetNuGetAddSource(srcSettings));
 
-        Logger.Success($"Successfully pushed {pushed} packages.");
+            foreach (var pushSettings in files.Select(file => new DotNetNuGetPushSettings()
+                .SetNoServiceEndpoint(NugetNoServiceEndpoint)
+                .EnableSkipDuplicate()
+                .SetTargetPath(file)))
+            {
+                outputs = outputs.Concat(DotNetNuGetPush(pushSettings));
+            }
 
-        if (exceptions.Count > 0)
-        {
-            throw new AggregateException(exceptions);
+            outputs = outputs.Concat(DotNet($"dotnet nuget remove source \"Silk-PushPackages\""));
         }
+
+        return outputs;
     }
 }

src/infrastructure/Silk.NET.NUKE/Projects.cs

@@ -5,7 +5,7 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
-using JetBrains.Annotations;
+
 using Nuke.Common;
 using Nuke.Common.IO;
 using Nuke.Common.ProjectModel;
@@ -65,7 +65,11 @@ bool hasDesktopMsBuild
             }
 
             var sln = ParseSolution(originalSolutionPath);
-            featureSetSpecificSolutions[featureSet.Name] = (sln, featureSet.RequiresDesktopMsBuild);
+            if (featureSetUsed)
+            {
+                featureSetSpecificSolutions[featureSet.Name] = (sln, featureSet.RequiresDesktopMsBuild);
+            }
+
             foreach (var removal in rm)
             {
                 sln.RemoveProject(sln.GetProject(removal));