Fix incorrect VersionSuffix, workaround strange NUKE bug

Author: Perksey

.github/workflows/dotnet.yml

@@ -34,8 +34,7 @@ jobs:
                 Pack
                 --configuration Release
                 --msbuild-properties
-                ${{ github.event_name == 'workflow_dispatch' && inputs.release && '' || github.event_name != 'pull_request' && format('VersionSuffix=build{0}.0', github.run_number) || format('VersionSuffix=pr{0}.{1}', github.event.number, github.run_number) }}
-                ContinuousIntegrationBuild=true
+                ${{ github.event_name == 'workflow_dispatch' && inputs.release && 'ContinuousIntegrationBuild=true' || github.event_name != 'pull_request' && format('ContinuousIntegrationBuild=true VersionSuffix=build{0}.0', github.run_number) || format('ContinuousIntegrationBuild=true VersionSuffix=pr{0}.{1}', github.event.number, github.run_number) }}
             - name: Upload Unsigned Artifacts to Actions
               uses: actions/upload-artifact@v4
               with:

eng/build/Build.Publishing.cs

@@ -233,7 +233,18 @@ private void CommitShippedApi()
             Git($"checkout {GitHubActions.Instance.RefName}");
         }
         Git("add **/PublicAPI.*.txt");
-        Git("commit -m \"Update public API after release\"");
+
+        // Must be an interpolated string even if we're not interpolating because NUKE specially recognises this idfk.
+        // The issue this caused if you omitted the $ is as follows:
+        // 20:14:58 [INF] > "C:\Program Files\Git\bin\git.exe" config user.email "[email protected]"
+        // 20:14:58 [INF] > "C:\Program Files\Git\bin\git.exe" config user.name "The Silk.NET Automaton"
+        // 20:14:58 [INF] > "C:\Program Files\Git\bin\git.exe" tag v3.0.0-preview
+        // 20:14:59 [DBG] ...
+        // 20:15:00 [INF] > "C:\Program Files\Git\bin\git.exe" "commit -m \"Update public API after release\""
+        // 20:15:00 [DBG] git: 'commit -m "Update public API after release"' is not a git command. See 'git --help'.
+        // Error: Target "FinishRelease" has thrown an exception
+        // THE ONLY DISCERNABLE DIFFERENCE BETWEEN THE GIT CONFIG COMMANDS AND GIT COMMIT COMMAND WAS THE LACK OF A $
+        Git($"commit -m \"Update public API after release\"");
     }
 
     private readonly record struct VersionsList(