Add another base case for FindCommonPrefix for when names.Count is 0

Exanite · Exanite · commit d7fc141ee8aa · 2025-05-23T19:56:56.000-04:00
This commit fixes the allowLeadingDigits overload. The previous similarly named commit fixes the maxLen overload.
diff --git a/sources/SilkTouch/SilkTouch/Naming/NameUtils.cs b/sources/SilkTouch/SilkTouch/Naming/NameUtils.cs
@@ -86,6 +86,11 @@ public static string FindCommonPrefix(
         bool naive = false
     )
     {
+        if (names.Count == 0)
+        {
+            return "";
+        }
+
         if (allowFullMatch && names.Count == 1)
         {
             return names.First();

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,11 @@ public static string FindCommonPrefix(`
`86`	`86`	`bool naive = false`
`87`	`87`	`)`
`88`	`88`	`{`
	`89`	`+ if (names.Count == 0)`
	`90`	`+ {`
	`91`	`+ return "";`
	`92`	`+ }`
	`93`	`+`
`89`	`94`	`if (allowFullMatch && names.Count == 1)`
`90`	`95`	`{`
`91`	`96`	`return names.First();`