Use string.Empty

mdaigle · mdaigle · commit 228009d7cadb · 2025-10-23T13:42:46.000-07:00
diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs
@@ -1634,7 +1634,7 @@ private void LoginNoFailover(ServerInfo serverInfo,
 
                 // When ignoring server provided failover partner, we must pass in the original failover partner from the connection string.
                 // Otherwise the pool group's failover partner designation will be updated to point to the server provided value.
-                string actualFailoverPartner = LocalAppContextSwitches.IgnoreServerProvidedFailoverPartner ? "" : ServerProvidedFailoverPartner;
+                string actualFailoverPartner = LocalAppContextSwitches.IgnoreServerProvidedFailoverPartner ? string.Empty : ServerProvidedFailoverPartner;
 
                 PoolGroupProviderInfo.FailoverCheck(false, connectionOptions, actualFailoverPartner);
             }
diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs
@@ -1964,7 +1964,7 @@ private void LoginNoFailover(ServerInfo serverInfo, string newPassword, SecureSt
 
                 // When ignoring server provided failover partner, we must pass in the original failover partner from the connection string.
                 // Otherwise the pool group's failover partner designation will be updated to point to the server provided value.
-                string actualFailoverPartner = LocalAppContextSwitches.IgnoreServerProvidedFailoverPartner ? "" : ServerProvidedFailoverPartner;
+                string actualFailoverPartner = LocalAppContextSwitches.IgnoreServerProvidedFailoverPartner ? string.Empty : ServerProvidedFailoverPartner;
 
                 PoolGroupProviderInfo.FailoverCheck(false, connectionOptions, actualFailoverPartner);
             }

Original file line number	Diff line number	Diff line change
`@@ -1634,7 +1634,7 @@ private void LoginNoFailover(ServerInfo serverInfo,`
`1634`	`1634`
`1635`	`1635`	`// When ignoring server provided failover partner, we must pass in the original failover partner from the connection string.`
`1636`	`1636`	`// Otherwise the pool group's failover partner designation will be updated to point to the server provided value.`
`1637`		`- string actualFailoverPartner = LocalAppContextSwitches.IgnoreServerProvidedFailoverPartner ? "" : ServerProvidedFailoverPartner;`
	`1637`	`+ string actualFailoverPartner = LocalAppContextSwitches.IgnoreServerProvidedFailoverPartner ? string.Empty : ServerProvidedFailoverPartner;`
`1638`	`1638`
`1639`	`1639`	`PoolGroupProviderInfo.FailoverCheck(false, connectionOptions, actualFailoverPartner);`
`1640`	`1640`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1964,7 +1964,7 @@ private void LoginNoFailover(ServerInfo serverInfo, string newPassword, SecureSt`
`1964`	`1964`
`1965`	`1965`	`// When ignoring server provided failover partner, we must pass in the original failover partner from the connection string.`
`1966`	`1966`	`// Otherwise the pool group's failover partner designation will be updated to point to the server provided value.`
`1967`		`- string actualFailoverPartner = LocalAppContextSwitches.IgnoreServerProvidedFailoverPartner ? "" : ServerProvidedFailoverPartner;`
	`1967`	`+ string actualFailoverPartner = LocalAppContextSwitches.IgnoreServerProvidedFailoverPartner ? string.Empty : ServerProvidedFailoverPartner;`
`1968`	`1968`
`1969`	`1969`	`PoolGroupProviderInfo.FailoverCheck(false, connectionOptions, actualFailoverPartner);`
`1970`	`1970`	`}`