Tests | Fix event counter test intermittent failure (#1358)

Author: DavoudEshtehari

src/Microsoft.Data.SqlClient/tests/ManualTests/TracingTests/EventCounterTest.cs

@@ -154,17 +154,24 @@ public void EventCounter_ReclaimedConnectionsCounter_Functional()
 
             long rc = SqlClientEventSourceProps.ReclaimedConnections;
 
-            InternalConnectionWrapper internalConnection = CreateEmancipatedConnection(stringBuilder.ToString());
-
-            GC.Collect();
+            int gcNumber = GC.GetGeneration(CreateEmancipatedConnection(stringBuilder.ToString()));
+            // Specifying the generation number makes it to run faster by avoiding a full GC process
+            GC.Collect(gcNumber);
             GC.WaitForPendingFinalizers();
 
             using (SqlConnection conn = new SqlConnection(stringBuilder.ToString()))
             {
                 conn.Open();
 
-                // when calling open, the connection is reclaimed. 
-                Assert.Equal(rc + 1, SqlClientEventSourceProps.ReclaimedConnections);
+                // when calling open, the connection could be reclaimed.
+                if (GC.GetGeneration(conn) == gcNumber)
+                {
+                    Assert.Equal(rc + 1, SqlClientEventSourceProps.ReclaimedConnections);
+                }
+                else
+                {
+                    Assert.Equal(rc, SqlClientEventSourceProps.ReclaimedConnections);
+                }
             }
         }
 
@@ -256,7 +263,7 @@ private static FieldInfo GetConnectionFactoryField()
 
     internal static class SqlClientEventSourceProps
     {
-        private static readonly object _log;
+        private static readonly object s_log;
         private static readonly FieldInfo _activeHardConnectionsCounter;
         private static readonly FieldInfo _hardConnectsCounter;
         private static readonly FieldInfo _hardDisconnectsCounter;
@@ -276,14 +283,14 @@ internal static class SqlClientEventSourceProps
 
         static SqlClientEventSourceProps()
         {
-            var sqlClientEventSourceType =
+            Type sqlClientEventSourceType =
                 Assembly.GetAssembly(typeof(SqlConnection))!.GetType("Microsoft.Data.SqlClient.SqlClientEventSource");
             Debug.Assert(sqlClientEventSourceType != null);
-            var logField = sqlClientEventSourceType.GetField("Log", BindingFlags.Static | BindingFlags.NonPublic);
+            FieldInfo logField = sqlClientEventSourceType.GetField("Log", BindingFlags.Static | BindingFlags.NonPublic);
             Debug.Assert(logField != null);
-            _log = logField.GetValue(null);
+            s_log = logField.GetValue(null);
 
-            var _bindingFlags = BindingFlags.Instance | BindingFlags.NonPublic;
+            BindingFlags _bindingFlags = BindingFlags.Instance | BindingFlags.NonPublic;
             _activeHardConnectionsCounter =
                 sqlClientEventSourceType.GetField(nameof(_activeHardConnectionsCounter), _bindingFlags);
             Debug.Assert(_activeHardConnectionsCounter != null);
@@ -334,36 +341,36 @@ static SqlClientEventSourceProps()
             Debug.Assert(_reclaimedConnectionsCounter != null);
         }
 
-        public static long ActiveHardConnections => (long)_activeHardConnectionsCounter.GetValue(_log)!;
+        public static long ActiveHardConnections => (long)_activeHardConnectionsCounter.GetValue(s_log)!;
 
-        public static long HardConnects => (long)_hardConnectsCounter.GetValue(_log)!;
+        public static long HardConnects => (long)_hardConnectsCounter.GetValue(s_log)!;
 
-        public static long HardDisconnects => (long)_hardDisconnectsCounter.GetValue(_log)!;
+        public static long HardDisconnects => (long)_hardDisconnectsCounter.GetValue(s_log)!;
 
-        public static long ActiveSoftConnections => (long)_activeSoftConnectionsCounter.GetValue(_log)!;
+        public static long ActiveSoftConnections => (long)_activeSoftConnectionsCounter.GetValue(s_log)!;
 
-        public static long SoftConnects => (long)_softConnectsCounter.GetValue(_log)!;
+        public static long SoftConnects => (long)_softConnectsCounter.GetValue(s_log)!;
 
-        public static long SoftDisconnects => (long)_softDisconnectsCounter.GetValue(_log)!;
+        public static long SoftDisconnects => (long)_softDisconnectsCounter.GetValue(s_log)!;
 
-        public static long NonPooledConnections => (long)_nonPooledConnectionsCounter.GetValue(_log)!;
+        public static long NonPooledConnections => (long)_nonPooledConnectionsCounter.GetValue(s_log)!;
 
-        public static long PooledConnections => (long)_pooledConnectionsCounter.GetValue(_log)!;
+        public static long PooledConnections => (long)_pooledConnectionsCounter.GetValue(s_log)!;
 
-        public static long ActiveConnectionPoolGroups => (long)_activeConnectionPoolGroupsCounter.GetValue(_log)!;
+        public static long ActiveConnectionPoolGroups => (long)_activeConnectionPoolGroupsCounter.GetValue(s_log)!;
 
-        public static long InactiveConnectionPoolGroups => (long)_inactiveConnectionPoolGroupsCounter.GetValue(_log)!;
+        public static long InactiveConnectionPoolGroups => (long)_inactiveConnectionPoolGroupsCounter.GetValue(s_log)!;
 
-        public static long ActiveConnectionPools => (long)_activeConnectionPoolsCounter.GetValue(_log)!;
+        public static long ActiveConnectionPools => (long)_activeConnectionPoolsCounter.GetValue(s_log)!;
 
-        public static long InactiveConnectionPools => (long)_inactiveConnectionPoolsCounter.GetValue(_log)!;
+        public static long InactiveConnectionPools => (long)_inactiveConnectionPoolsCounter.GetValue(s_log)!;
 
-        public static long ActiveConnections => (long)_activeConnectionsCounter.GetValue(_log)!;
+        public static long ActiveConnections => (long)_activeConnectionsCounter.GetValue(s_log)!;
 
-        public static long FreeConnections => (long)_freeConnectionsCounter.GetValue(_log)!;
+        public static long FreeConnections => (long)_freeConnectionsCounter.GetValue(s_log)!;
 
-        public static long StasisConnections => (long)_stasisConnectionsCounter.GetValue(_log)!;
+        public static long StasisConnections => (long)_stasisConnectionsCounter.GetValue(s_log)!;
 
-        public static long ReclaimedConnections => (long)_reclaimedConnectionsCounter.GetValue(_log)!;
+        public static long ReclaimedConnections => (long)_reclaimedConnectionsCounter.GetValue(s_log)!;
     }
 }