Skip to content

Commit 2dce507

Browse files
committed
User Story 37654: Create Extensions base package
- Fixed .NET runtime installs to actually install just a runtime. - Misc comment/doc additions and corrections.
1 parent 54d6245 commit 2dce507

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

eng/pipelines/dotnet-sqlclient-ci-core.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ variables:
8989
stages:
9090

9191
# Build the Extensions package, and publish it to the pipeline artifacts
92-
# under the default name 'Extensions.Artifact'.
92+
# under the name specified by the 'extensionsArtifactName' variable.
9393
- template: stages/ci-build-extensions-package-stage.yml@self
9494
parameters:
9595
buildConfiguration: Release

eng/pipelines/stages/ci-build-extensions-package-stage.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ stages:
207207
- task: UseDotNet@2
208208
displayName: Install .NET 8.0 Runtime
209209
inputs:
210-
packageType: sdk
210+
packageType: runtime
211211
version: 8.x
212212

213213
- task: DotNetCoreCLI@2
@@ -264,7 +264,7 @@ stages:
264264
- task: UseDotNet@2
265265
displayName: Install .NET 8.0 Runtime
266266
inputs:
267-
packageType: sdk
267+
packageType: runtime
268268
version: 8.x
269269

270270
- task: DotNetCoreCLI@2

src/Microsoft.Data.SqlClient.Extensions/Extensions/src/Extensions.csproj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<PropertyGroup>
1111
<!--
1212
We use the ExtensionsPackageVersion from Versions.props. It may be
13-
specified on the command-line, or a default vlaue is used.
13+
specified on the command-line, or a default value is used.
1414
-->
1515
<PackageVersion>$(ExtensionsPackageVersion)</PackageVersion>
1616
<!--
@@ -45,9 +45,12 @@
4545
<RootNamespace>Microsoft.Data.SqlClient.Extensions</RootNamespace>
4646
</PropertyGroup>
4747
<ItemGroup>
48+
<!-- Our API is CLS Compliant. -->
4849
<AssemblyAttribute Include="System.CLSCompliantAttribute">
4950
<_Parameter1>true</_Parameter1>
5051
</AssemblyAttribute>
52+
53+
<!-- Our unit tests have access to our internal types. -->
5154
<InternalsVisibleTo Include="Microsoft.Data.SqlClient.Extensions.Test" />
5255
</ItemGroup>
5356

0 commit comments

Comments
 (0)