Skip to content

Commit 9e1d2bc

Browse files
mdaiglemdaigle
committed
Restrict command reliability tests to non-azure.
1 parent 7625e0f commit 9e1d2bc

File tree

1 file changed

+22
-11
lines changed

1 file changed

+22
-11
lines changed

‎src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RetryLogic/SqlCommandReliabilityTest.cs‎

Lines changed: 22 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ protected virtual void Dispose(bool disposing)
5151
numberOfRetries: 2,
5252
maxInterval: TimeSpan.FromMilliseconds(100));
5353

54-
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
54+
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
55+
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
5556
[MemberData(nameof(RetryExecuteFail_Data), DisableDiscoveryEnumeration = true)]
5657
public void RetryExecuteFail(string cnnString, SqlRetryLogicBaseProvider provider)
5758
{
@@ -101,7 +102,8 @@ public void RetryExecuteFail(string cnnString, SqlRetryLogicBaseProvider provide
101102
numberOfRetries: 2,
102103
maxInterval: TimeSpan.FromMilliseconds(100));
103104

104-
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
105+
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
106+
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
105107
[MemberData(nameof(RetryExecuteCancel_Data), DisableDiscoveryEnumeration = true)]
106108
public void RetryExecuteCancel(string cnnString, SqlRetryLogicBaseProvider provider)
107109
{
@@ -151,7 +153,8 @@ public void RetryExecuteCancel(string cnnString, SqlRetryLogicBaseProvider provi
151153
numberOfRetries: 5,
152154
maxInterval: TimeSpan.FromMilliseconds(100));
153155

154-
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup))]
156+
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
157+
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
155158
[MemberData(nameof(RetryExecuteWithTransactionScope_Data), DisableDiscoveryEnumeration = true)]
156159
public void RetryExecuteWithTransScope(string cnnString, SqlRetryLogicBaseProvider provider)
157160
{
@@ -192,7 +195,8 @@ public void RetryExecuteWithTransScope(string cnnString, SqlRetryLogicBaseProvid
192195
maxInterval: TimeSpan.FromMilliseconds(100));
193196

194197
// Synapse: 111214;An attempt to complete a transaction has failed. No corresponding transaction found.
195-
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup))]
198+
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
199+
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
196200
[MemberData(nameof(RetryExecuteWithTransaction_Data), DisableDiscoveryEnumeration = true)]
197201
public void RetryExecuteWithTransaction(string cnnString, SqlRetryLogicBaseProvider provider)
198202
{
@@ -236,7 +240,8 @@ public void RetryExecuteWithTransaction(string cnnString, SqlRetryLogicBaseProvi
236240
unauthorizedStatementRegex: RetryLogicTestHelper.FilterDmlStatements);
237241

238242
// Synapse: Msg 103010, Level 16, State 1, Line 1 | Parse error at line: 1, column: 1: Incorrect syntax near 'command'
239-
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup))]
243+
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
244+
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
240245
[MemberData(nameof(RetryExecuteUnauthorizedSqlStatementDml_Data), DisableDiscoveryEnumeration = true)]
241246
public void RetryExecuteUnauthorizedSqlStatementDml(string cnnString, SqlRetryLogicBaseProvider provider)
242247
{
@@ -363,7 +368,8 @@ public void DropDatabaseWithActiveConnection(string cnnString, SqlRetryLogicBase
363368

364369
// In Managed SNI by Named pipe connection, SqlCommand doesn't respect timeout. "ActiveIssue 12167"
365370
// Synapse: Does not support WAITFOR DELAY.
366-
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotUsingManagedSNIOnWindows), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup))]
371+
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
372+
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsNotUsingManagedSNIOnWindows), nameof(DataTestUtility.IsNotAzureSynapse), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
367373
[MemberData(nameof(UpdateLockedTable_Data), DisableDiscoveryEnumeration = true)]
368374
public void UpdateLockedTable(string cnnString, SqlRetryLogicBaseProvider provider)
369375
{
@@ -423,7 +429,8 @@ public void UpdateLockedTable(string cnnString, SqlRetryLogicBaseProvider provid
423429
public static TheoryData<string, SqlRetryLogicBaseProvider> NoneRetriableExecuteFail_Data =>
424430
RetryLogicTestHelper.GetNonRetriableCases();
425431

426-
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
432+
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
433+
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
427434
[MemberData(nameof(NoneRetriableExecuteFail_Data), DisableDiscoveryEnumeration = true)]
428435
public void NoneRetriableExecuteFail(string cnnString, SqlRetryLogicBaseProvider provider)
429436
{
@@ -463,7 +470,8 @@ public void NoneRetriableExecuteFail(string cnnString, SqlRetryLogicBaseProvider
463470
numberOfRetries: 2,
464471
maxInterval: TimeSpan.FromMilliseconds(100));
465472

466-
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
473+
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
474+
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
467475
[MemberData(nameof(RetryExecuteAsyncFail_Data), DisableDiscoveryEnumeration = true)]
468476
public async Task RetryExecuteAsyncFail(string cnnString, SqlRetryLogicBaseProvider provider)
469477
{
@@ -533,7 +541,8 @@ public async Task RetryExecuteAsyncFail(string cnnString, SqlRetryLogicBaseProvi
533541
numberOfRetries: 2,
534542
maxInterval: TimeSpan.FromMilliseconds(100));
535543

536-
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
544+
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
545+
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
537546
[MemberData(nameof(RetryExecuteAsyncCancel_Data), DisableDiscoveryEnumeration = true)]
538547
public async Task RetryExecuteAsyncCancel(string cnnString, SqlRetryLogicBaseProvider provider)
539548
{
@@ -606,7 +615,8 @@ public async Task RetryExecuteAsyncCancel(string cnnString, SqlRetryLogicBasePro
606615
numberOfRetries: 2,
607616
maxInterval: TimeSpan.FromMilliseconds(100));
608617

609-
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
618+
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
619+
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
610620
[MemberData(nameof(ConcurrentExecution_Data), DisableDiscoveryEnumeration = true)]
611621
public void ConcurrentExecution(string cnnString, SqlRetryLogicBaseProvider provider)
612622
{
@@ -628,7 +638,8 @@ public void ConcurrentExecution(string cnnString, SqlRetryLogicBaseProvider prov
628638
numberOfRetries: 2,
629639
maxInterval: TimeSpan.FromMilliseconds(100));
630640

631-
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
641+
// Restricted to non azure: https://github.com/dotnet/SqlClient/issues/3821
642+
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
632643
[MemberData(nameof(ConcurrentExecutionAsync_Data), DisableDiscoveryEnumeration = true)]
633644
public async Task ConcurrentExecutionAsync(string cnnString, SqlRetryLogicBaseProvider provider)
634645
{

0 commit comments

Comments
 (0)