Skip to content

Commit b50c074

Browse files
Merged PR 4888: eng | Fix package validation stage against the preview
1 parent 4eafe1f commit b50c074

File tree

4 files changed

+28
-3
lines changed

4 files changed

+28
-3
lines changed

eng/pipelines/common/templates/jobs/run-tests-package-reference-job.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ parameters:
1717
type: string
1818
default: empty
1919

20+
- name: isPreview
21+
type: boolean
22+
2023
jobs:
2124
- job: run_tests_package_reference
2225
displayName: 'Run tests with package reference'
@@ -39,6 +42,8 @@ jobs:
3942
- template: ../steps/update-nuget-config-local-feed-step.yml
4043
parameters:
4144
downloadedNugetPath: $(Pipeline.Workspace)\${{parameters.packageFolderName }}
45+
${{ if parameters.isPreview }}:
46+
nugetPackageVersion: $(PreviewNugetPackageVersion)
4247

4348
- template: ../steps/update-config-file-step.yml
4449
parameters:
@@ -52,8 +57,12 @@ jobs:
5257
- template: ../steps/build-and-run-tests-netfx-step.yml
5358
parameters:
5459
referenceType: Package
60+
${{ if parameters.isPreview }}:
61+
nugetPackageVersion: $(PreviewNugetPackageVersion)
5562

5663
- template: ../steps/build-and-run-tests-netcore-step.yml
5764
parameters:
5865
referenceType: Package
5966
cleanFirst: true
67+
${{ if parameters.isPreview }}:
68+
nugetPackageVersion: $(PreviewNugetPackageVersion)

eng/pipelines/common/templates/jobs/validate-signed-package-job.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ parameters:
3333
type: string
3434
default: $(AssemblyFileVersion)
3535

36+
- name: isPreview
37+
type: boolean
38+
3639
jobs:
3740
- job: validate_signed_package
3841
displayName: 'Verify signed package'
@@ -49,6 +52,17 @@ jobs:
4952

5053
- name: pathToDownloadedNuget # path to the downloaded nuget files
5154
value: $(Pipeline.Workspace)\${{parameters.packageFolderName }}
55+
56+
- name: ProductVersion #MDS product version (MDS validation)
57+
value: $(NugetPackageVersion)
58+
59+
- ${{ if parameters.isPreview }}:
60+
- name: extractedNugetPath
61+
value: $(extractedNugetRootPath).$(PreviewNugetPackageVersion)
62+
- name: NugetPackageVersion
63+
value: $(PreviewNugetPackageVersion)
64+
- name: ProductVersion
65+
value: $(PreviewNugetPackageVersion)
5266

5367
steps:
5468
- script: SET

eng/pipelines/dotnet-sqlclient-signing-pipeline.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@ variables:
7777
value: ${{ parameters['MDS_PackageRef_Version'] }}
7878
- name: CurrentNetFxVersion
7979
value: ${{ parameters['CurrentNetFxVersion'] }}
80-
- name: ProductVersion #MDS product version (MDS validation)
81-
value: $(NUGETPACKAGEVERSION)
8280

8381
resources:
8482
repositories:
@@ -158,6 +156,7 @@ extends:
158156
- template: eng/pipelines/common/templates/jobs/validate-signed-package-job.yml@self
159157
parameters:
160158
packageFolderName: $(packageFolderName)
159+
isPreview: ${{ parameters['isPreview'] }}
161160
downloadPackageStep:
162161
download: current
163162
artifact: $(packageFolderName)
@@ -167,6 +166,7 @@ extends:
167166
- template: eng/pipelines/common/templates/jobs/run-tests-package-reference-job.yml@self
168167
parameters:
169168
packageFolderName: $(packageFolderName)
169+
isPreview: ${{ parameters['isPreview'] }}
170170
downloadPackageStep:
171171
download: current
172172
artifact: $(packageFolderName)

eng/pipelines/libraries/mds-validation-variables.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ variables:
1010

1111
- name: TempFolderName # extract the nuget package here
1212
value: temp
13+
- name: extractedNugetRootPath
14+
value: $(Build.SourcesDirectory)\$(TempFolderName)\Microsoft.Data.SqlClient
1315
- name: extractedNugetPath
14-
value: $(Build.SourcesDirectory)\$(TempFolderName)\Microsoft.Data.SqlClient.$(NugetPackageVersion)
16+
value: $(extractedNugetRootPath).$(NugetPackageVersion)
1517
- name: expectedFolderNames
1618
value: lib,ref,runtimes
1719
- name: expectedDotnetVersions

0 commit comments

Comments
 (0)