Description

At the moment, the build has a custom target, GenerateResourceStringsSource. This target has been around since the start of the repo; it runs prior to compile and generates a file which contains one const for each resource string. An example file is

internal partial class StringsHelper : Strings
{
    internal class ResourceNames
    {
        internal const string ADP_Ascending = @"Ascending";
        // ..etc.
    }
}

This ResourceNames class is only used in the ResCategory and ResDescription attributes applied to certain properties within the implementation assemblies for netfx and netcore.

This is redundant because the ResCategoryAttribute and ResDescriptionAttribute classes will already look up the parameter passed to them as a resource string. Switching to using this functionality (with associated test) means that we don't need the StringsHelper class, which means that we don't need the target which generates it.

Issues

None.

Testing

Two automated tests added to prove that the descriptions contain the localized values as we expect. One manual check by binding a PropertyGrid to a SqlConnectionStringBuilder (in netcore and netfx) to make sure that WinForms isn't performing something unusual to get the description in a way which bypasses the custom logic in ResCategoryAttribute and ResDescriptionAttribute.