Skip to content

Commit 4c78c6c

Browse files
committed
Fix build nuget pacakges and build from VS 2019
1 parent abd51f9 commit 4c78c6c

16 files changed

+560
-29
lines changed

THIRD-PARTY-NOTICES.TXT

Lines changed: 517 additions & 0 deletions
Large diffs are not rendered by default.

build/BranchInfo.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@
99
</PropertyGroup>
1010
<PropertyGroup Condition="'$(IsStableProject)' == 'true'">
1111
<MajorVersion>1</MajorVersion>
12-
<MinorVersion>1</MinorVersion>
12+
<MinorVersion>0</MinorVersion>
1313
<PatchVersion>0</PatchVersion>
1414
<PreReleaseLabel>preview</PreReleaseLabel>
1515
</PropertyGroup>
1616
<PropertyGroup Condition="'$(IsStableProject)' != 'true'">
1717
<MajorVersion>0</MajorVersion>
18-
<MinorVersion>13</MinorVersion>
18+
<MinorVersion>2</MinorVersion>
1919
<PatchVersion>0</PatchVersion>
2020
<PreReleaseLabel>preview</PreReleaseLabel>
2121
</PropertyGroup>

build/Dependencies.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
<!-- Other/Non-Core Product Dependencies -->
1414
<PropertyGroup>
1515
<LibtorchVersion>1.0.1</LibtorchVersion>
16+
<MklDnnVersion>2019.0.5.20190502</MklDnnVersion>
1617
<!-- <GoogleProtobufPackageVersion>3.5.1</GoogleProtobufPackageVersion>
1718
<LightGBMPackageVersion>2.2.3</LightGBMPackageVersion>
1819
<MicrosoftMLOnnxRuntimePackageVersion>0.3.0</MicrosoftMLOnnxRuntimePackageVersion>

pkg/Directory.Build.props

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<PackageLicenseFile>LICENSE</PackageLicenseFile>
2525
<PackageProjectUrl>https://github.com/xamarin/TorchSharp</PackageProjectUrl>
2626
<!-- space separated -->
27-
<PackageTags>TorchSharp PyTorch Torch DL Deep ML Machine Learning</PackageTags>
27+
<PackageTags>TorchSharp LibTorch PyTorch Torch DL DNN Deep ML Machine Learning Neural Network</PackageTags>
2828
</PropertyGroup>
2929

3030
<ItemGroup>
@@ -34,7 +34,8 @@
3434
<Content Include="$(PackageAssetsPath)$(PackageIdFolderName)\tools\**\*" Pack="true" PackagePath="tools" />
3535
</ItemGroup>
3636

37-
<ItemGroup Condition="'$(IncludeMLNetNotices)' != 'false'">
37+
<ItemGroup Condition="'$(IncludeNotices)' != 'false'">
38+
<Content Include="$(RepoRoot)\THIRD-PARTY-NOTICES.TXT" Pack="true" PackagePath="" />
3839
<Content Include="$(RepoRoot)\LICENSE" Pack="true" PackagePath=""/>
3940
</ItemGroup>
4041

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<Project Sdk="Microsoft.NET.Sdk" DefaultTargets="Pack">
2+
3+
<PropertyGroup>
4+
<Authors></Authors>
5+
<Copyright>Copyright (c) Microsoft Corporation</Copyright>
6+
<Owners>Microsoft Corporation</Owners>
7+
<TargetFramework>netstandard2.0</TargetFramework>
8+
<PackageDescription>$(MSBuildProjectName) contains the PyTorch C++ frontend LibTorch library version $(LibTorchVersion)
9+
and MKL-DNN library version $(MklDnnVersion) redistributed as a NuGet package. </PackageDescription>
10+
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
11+
<PackageProjectUrl>https://pytorch.org/</PackageProjectUrl>
12+
</PropertyGroup>
13+
</Project>

pkg/TorchSharp/TorchSharp.nupkgproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<PropertyGroup>
44
<TargetFramework Condition="'$(UseIntrinsics)' != 'true'">netstandard2.0</TargetFramework>
55
<TargetFrameworks Condition="'$(UseIntrinsics)' == 'true'">netstandard2.0;netcoreapp3.0</TargetFrameworks>
6-
<PackageDescription>.NET Bindings for Torch.</PackageDescription>
6+
<PackageDescription>.NET Bindings for Toch.</PackageDescription>
77
</PropertyGroup>
88

99
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">

pkg/_._

Whitespace-only changes.

pkg/common/DnnImageFeaturizer.props

Lines changed: 0 additions & 9 deletions
This file was deleted.

src/Native/build.cmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ exit /b 1
6565
:VS2019
6666
:: Setup vars for VS2019
6767
set __PlatformToolset=v142
68-
set __VSVersion=15 2017
68+
set __VSVersion=16 2019
6969
if NOT "%__BuildArch%" == "arm64" (
7070
:: Set the environment for the native build
7171
call "%VS160COMNTOOLS%..\..\VC\Auxiliary\Build\vcvarsall.bat" %__VCBuildArch%

src/Native/build.proj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
<LibName Condition="'$(OS)' != 'Windows_NT'">libtorch-shared-with-deps</LibName>
4343
<LibName Condition="$([MSBuild]::IsOSPlatform('osx'))">libtorch-macos</LibName>
4444

45-
<LibtorchPath Condition="'$(LibtorchPath)'==''">$(IntermediateOutputRootPath)Microsoft.ML.Libtorch.Redist\$(LibName)-$(LibtorchVersion)\libtorch\share\cmake\Torch</LibtorchPath>
45+
<LibtorchPath Condition="'$(LibtorchPath)'==''">$(IntermediateOutputRootPath)Libtorch.Redist\$(LibName)-$(LibtorchVersion)\libtorch\share\cmake\Torch</LibtorchPath>
4646
</PropertyGroup>
4747

4848
<Target Name="BuildNativeUnix"

0 commit comments

Comments
 (0)