Skip to content

Commit 05b5f98

Browse files
committed
Move some of assembly packaging code to a helper class
1 parent 880a30c commit 05b5f98

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/Xamarin.Android.Build.Tasks/Tasks/BuildApk.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ void AddAssemblies (ZipArchiveEx apk, bool debug, bool compress, IDictionary<And
459459
AddFileToArchiveIfNewer (apk, wrappedSourcePath, inArchivePath, GetCompressionMethod (inArchivePath));
460460
}
461461

462-
void DoAddAssembliesFromArchCollection (TaskLoggingHelper log, AndroidTargetArch arch, ITaskItem assembly)
462+
void DoAddAssembliesFromArchCollection (AndroidTargetArch arch, Dictionary<string, ITaskItem> assemblies)
463463
{
464464
// In the "all assemblies are per-RID" world, assemblies, pdb and config are disguised as shared libraries (that is,
465465
// their names end with the .so extension) so that Android allows us to put them in the `lib/{ARCH}` directory.

src/Xamarin.Android.Build.Tasks/Utilities/AssemblyPackagingHelper.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@ namespace Xamarin.Android.Tasks;
1010

1111
static class AssemblyPackagingHelper
1212
{
13+
<<<<<<< HEAD
1314
public static void AddAssembliesFromCollection (TaskLoggingHelper Log, ICollection<string> SupportedAbis, ICollection<ITaskItem> assemblies, Action<TaskLoggingHelper, AndroidTargetArch, ITaskItem> doAddAssembly)
15+
=======
16+
public static void AddAssembliesFromCollection (TaskLoggingHelper Log, ICollection<string> SupportedAbis, ICollection<ITaskItem> assemblies, Action<AndroidTargetArch, Dictionary<string, ITaskItem>> doAddAssemblies)
17+
>>>>>>> c4d883405 (Move some of assembly packaging code to a helper class)
1418
{
1519
Dictionary<AndroidTargetArch, Dictionary<string, ITaskItem>> perArchAssemblies = MonoAndroidHelper.GetPerArchAssemblies (
1620
assemblies,
@@ -28,6 +32,7 @@ public static void AddAssembliesFromCollection (TaskLoggingHelper Log, ICollecti
2832

2933
foreach (var kvp in perArchAssemblies) {
3034
Log.LogDebugMessage ($"Adding assemblies for architecture '{kvp.Key}'");
35+
<<<<<<< HEAD
3136
DoAddAssembliesFromArchCollection (Log, kvp.Key, kvp.Value, doAddAssembly);
3237
}
3338
}
@@ -40,6 +45,9 @@ static void DoAddAssembliesFromArchCollection (TaskLoggingHelper Log, AndroidTar
4045
}
4146

4247
doAddAssembly (Log, arch, assembly);
48+
=======
49+
doAddAssemblies (kvp.Key, kvp.Value);
50+
>>>>>>> c4d883405 (Move some of assembly packaging code to a helper class)
4351
}
4452
}
4553
}

0 commit comments

Comments
 (0)