Skip to content

Commit 0a1ff37

Browse files
committed
Log it when an assembly is missing in ManifestDocument
1 parent 8edaf51 commit 0a1ff37

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/Xamarin.Android.Build.Tasks/Utilities/ManifestDocument.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ public IList<string> Merge (TaskLoggingHelper log, TypeDefinitionCache cache, Li
287287
string.IsNullOrEmpty (VersionName) ? "1.0" : VersionName);
288288
}
289289

290-
app = CreateApplicationElement (manifest, applicationClass, subclasses, cache);
290+
app = CreateApplicationElement (log, manifest, applicationClass, subclasses, cache);
291291

292292
if (app.Attribute (androidNs + "label") == null && !string.IsNullOrEmpty (ApplicationLabel))
293293
app.SetAttributeValue (androidNs + "label", ApplicationLabel);
@@ -567,7 +567,7 @@ Func<TypeDefinition, string, TypeDefinitionCache, int, XElement> GetGenerator (T
567567
return null;
568568
}
569569

570-
XElement CreateApplicationElement (XElement manifest, string applicationClass, List<TypeDefinition> subclasses, TypeDefinitionCache cache)
570+
XElement CreateApplicationElement (TaskLoggingHelper log, XElement manifest, string applicationClass, List<TypeDefinition> subclasses, TypeDefinitionCache cache)
571571
{
572572
var application = manifest.Descendants ("application").FirstOrDefault ();
573573

@@ -579,6 +579,7 @@ XElement CreateApplicationElement (XElement manifest, string applicationClass, L
579579
foreach (var assemblyPath in Assemblies) {
580580
var assembly = Resolver.GetAssembly (assemblyPath);
581581
if (assembly == null) {
582+
log.LogDebugMessage ($"Assembly '{assemblyPath}' not found.");
582583
continue;
583584
}
584585

0 commit comments

Comments
 (0)