Skip to content

Commit 327687c

Browse files
committed
Post-rebase fixes
1 parent 3bd5c59 commit 327687c

File tree

2 files changed

+17
-6
lines changed

2 files changed

+17
-6
lines changed

build-tools/create-packs/Microsoft.Android.Runtime.proj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ projects that use the Microsoft.Android framework in .NET 6+.
4242
<_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.release.so" />
4343
<_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libxamarin-debug-app-helper.so" />
4444
<_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libxamarin-native-tracing.so" />
45-
<_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libarchive-dso-stub.so" />
4645
<_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libunwind_xamarin-release.a" />
4746
<_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libruntime-base-release.a" />
4847
<_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libxa-java-interop-release.a" />

src/native/pinvoke-override/dynamic.cc

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,15 @@ PinvokeOverride::monodroid_pinvoke_override (const char *library_name, const cha
2929
log_debug (LOG_ASSEMBLY, "library_name == '%s'; entrypoint_name == '%s'", library_name, entrypoint_name);
3030

3131
if (library_name == nullptr || entrypoint_name == nullptr) [[unlikely]] {
32-
log_fatal (LOG_ASSEMBLY, "Both library name ('%s') and entry point name ('%s') must be specified", library_name, entrypoint_name);
33-
Helpers::abort_application ();
34-
}
32+
Helpers::abort_application (
33+
LOG_ASSEMBLY,
34+
Util::monodroid_strdup_printf (
35+
"Both library name ('%s') and entry point name ('%s') must be specified",
36+
library_name,
37+
entrypoint_name
38+
)
39+
);
40+
}
3541

3642
hash_t library_name_hash = xxhash::hash (library_name, strlen (library_name));
3743
hash_t entrypoint_hash = xxhash::hash (entrypoint_name, strlen (entrypoint_name));
@@ -51,8 +57,14 @@ PinvokeOverride::monodroid_pinvoke_override (const char *library_name, const cha
5157
// the find* functions didn't know its hash), but we cannot be sure of that so we'll try to load it.
5258
pinvoke_ptr = dlsym (RTLD_DEFAULT, entrypoint_name);
5359
if (pinvoke_ptr == nullptr) {
54-
log_fatal (LOG_ASSEMBLY, "Unable to load p/invoke entry '%s/%s' from the unified runtime DSO", library_name, entrypoint_name);
55-
Helpers::abort_application ();
60+
Helpers::abort_application (
61+
LOG_ASSEMBLY,
62+
Util::monodroid_strdup_printf (
63+
"Unable to load p/invoke entry '%s/%s' from the unified runtime DSO",
64+
library_name,
65+
entrypoint_name
66+
)
67+
);
5668
}
5769

5870
return pinvoke_ptr;

0 commit comments

Comments
 (0)