Skip to content

Commit 39324dd

Browse files
committed
Log it when an assembly is missing in ManifestDocument
1 parent 2d196a3 commit 39324dd

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/Xamarin.Android.Build.Tasks/Utilities/ManifestDocument.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ public IList<string> Merge (TaskLoggingHelper log, TypeDefinitionCache cache, Li
290290
string.IsNullOrEmpty (VersionName) ? "1.0" : VersionName);
291291
}
292292

293-
app = CreateApplicationElement (manifest, applicationClass, subclasses, cache);
293+
app = CreateApplicationElement (log, manifest, applicationClass, subclasses, cache);
294294

295295
if (app.Attribute (androidNs + "label") == null && !string.IsNullOrEmpty (ApplicationLabel))
296296
app.SetAttributeValue (androidNs + "label", ApplicationLabel);
@@ -570,7 +570,7 @@ Func<TypeDefinition, string, TypeDefinitionCache, int, XElement> GetGenerator (T
570570
return null;
571571
}
572572

573-
XElement CreateApplicationElement (XElement manifest, string applicationClass, List<TypeDefinition> subclasses, TypeDefinitionCache cache)
573+
XElement CreateApplicationElement (TaskLoggingHelper log, XElement manifest, string applicationClass, List<TypeDefinition> subclasses, TypeDefinitionCache cache)
574574
{
575575
var application = manifest.Descendants ("application").FirstOrDefault ();
576576

@@ -582,6 +582,7 @@ XElement CreateApplicationElement (XElement manifest, string applicationClass, L
582582
foreach (var assemblyPath in Assemblies) {
583583
var assembly = Resolver.GetAssembly (assemblyPath);
584584
if (assembly == null) {
585+
log.LogDebugMessage ($"Assembly '{assemblyPath}' not found.");
585586
continue;
586587
}
587588

0 commit comments

Comments
 (0)