Skip to content

Commit 478de4c

Browse files
[build] fix code-flow from dotnet/installer, .NET 9.0.100-preview.5.24262.2 (#8949)
Context: dotnet/installer#19707 Changes: dotnet/installer@fa261b9...1741345 Changes: dotnet/runtime@4326eb7...84b3339 Changes: dotnet/cecil@4abe3e6...7a4a59f dotnet/installer is no longer producing a `Microsoft.Dotnet.Sdk.Internal` "package" for the SDK. This is causing the maestro code-flow to fail, such as: > darc update-dependencies --id 225276 Looking up build with BAR id 225276 Checking for coherency updates... Using 'Strict' coherency mode. If this fails, a second attempt utilizing 'Legacy' Coherency mode will be made. Found no dependencies to update. We use `Microsoft.Dotnet.Sdk.Internal` to provision the .NET SDK, similar to: ./dotnet-install.sh --version $(MicrosoftDotnetSdkInternalPackageVersion) Where `eng/Versions.props` is updated by the Maestro bot for the version number. There is no `Microsoft.Dotnet.Sdk.Internal` package from the build, such as: > darc gather-drop --id 225276 -o drop --dry-run | grep Microsoft.Dotnet.Sdk.Internal Root build - Build number 20240512.2 of https://dev.azure.com/dnceng/internal/_git/dotnet-installer @ 1741345c6399ae203d8f259fb12fb873dac5129d But we can find the package for .NET 9 Preview 4: > darc gather-drop --id 225611 -o drop --dry-run | grep Microsoft.Dotnet.Sdk.Internal Root build - Build number 20240515.4 of https://dev.azure.com/dnceng/internal/_git/dotnet-installer @ df80b5eb607242b1d8ded158ec97a25e5d5e5e05 Skipping non-shipping asset [email protected] For now, we can use `VS.Tools.Net.Core.SDK.Resolver` instead, as this is a component inserted into Visual Studio that contains the same version number. We may have to change this again in the future, as dotnet/installer is in the process of merging and/or moving to dotnet/sdk. MS employees can see more details in the [MS Teams thread][0]. [0]: https://teams.microsoft.com/l/message/19:[email protected]/1715789991637?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4d73664c-9f2f-450d-82a5-c2f02756606d&parentMessageId=1715789991637&teamName=.NET%20Core%20Eng%20Services%20Partners&channelName=First%20Responders&createdTime=1715789991637
1 parent a0b7aad commit 478de4c

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

eng/Version.Details.xml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
<Dependencies>
22
<ProductDependencies>
3-
<Dependency Name="Microsoft.Dotnet.Sdk.Internal" Version="9.0.100-preview.5.24253.16">
3+
<Dependency Name="VS.Tools.Net.Core.SDK.Resolver" Version="9.0.100-preview.5.24262.2">
44
<Uri>https://github.com/dotnet/installer</Uri>
5-
<Sha>fa261b952d702c6bd604728fcbdb58ac071a22b1</Sha>
5+
<Sha>1741345c6399ae203d8f259fb12fb873dac5129d</Sha>
66
</Dependency>
7-
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="9.0.0-preview.4.24251.3" CoherentParentDependency="Microsoft.Dotnet.Sdk.Internal">
7+
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="9.0.0-preview.5.24256.1" CoherentParentDependency="VS.Tools.Net.Core.SDK.Resolver">
88
<Uri>https://github.com/dotnet/runtime</Uri>
9-
<Sha>4326eb7ed4d03f30ce4a4de1eb028ee76fdaaa3c</Sha>
9+
<Sha>84b33395057737db3ea342a5151feb6b90c1b6f6</Sha>
1010
</Dependency>
11-
<Dependency Name="Microsoft.NETCore.App.Ref" Version="9.0.0-preview.4.24251.3" CoherentParentDependency="Microsoft.Dotnet.Sdk.Internal">
11+
<Dependency Name="Microsoft.NETCore.App.Ref" Version="9.0.0-preview.5.24256.1" CoherentParentDependency="VS.Tools.Net.Core.SDK.Resolver">
1212
<Uri>https://github.com/dotnet/runtime</Uri>
13-
<Sha>4326eb7ed4d03f30ce4a4de1eb028ee76fdaaa3c</Sha>
13+
<Sha>84b33395057737db3ea342a5151feb6b90c1b6f6</Sha>
1414
</Dependency>
1515
<Dependency Name="Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport" Version="9.0.0-preview.5.24223.2" CoherentParentDependency="Microsoft.NETCore.App.Ref">
1616
<Uri>https://github.com/dotnet/emsdk</Uri>
1717
<Sha>53288f87c588907e8ff01f129786820fe998573c</Sha>
1818
</Dependency>
19-
<Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.4-alpha.24222.1" CoherentParentDependency="Microsoft.NET.ILLink.Tasks">
19+
<Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.4-alpha.24230.1" CoherentParentDependency="Microsoft.NET.ILLink.Tasks">
2020
<Uri>https://github.com/dotnet/cecil</Uri>
21-
<Sha>4abe3e63a5d4653ca098c633644432c1395411c1</Sha>
21+
<Sha>7a4a59f9f66baf6711a6ce2de01d3b2c62ed72d8</Sha>
2222
</Dependency>
2323
</ProductDependencies>
2424
<ToolsetDependencies>

eng/Versions.props

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,17 @@
11
<Project>
22
<!--Package versions-->
33
<PropertyGroup>
4-
<MicrosoftDotnetSdkInternalPackageVersion>9.0.100-preview.5.24253.16</MicrosoftDotnetSdkInternalPackageVersion>
5-
<MicrosoftNETILLinkTasksPackageVersion>9.0.0-preview.4.24251.3</MicrosoftNETILLinkTasksPackageVersion>
6-
<MicrosoftNETCoreAppRefPackageVersion>9.0.0-preview.4.24251.3</MicrosoftNETCoreAppRefPackageVersion>
4+
<!-- NOTE: $(VSToolsNetCoreSDKResolverPackageVersion) may be temporary -->
5+
<VSToolsNetCoreSDKResolverPackageVersion>9.0.100-preview.5.24262.2</VSToolsNetCoreSDKResolverPackageVersion>
6+
<MicrosoftDotnetSdkInternalPackageVersion>$(VSToolsNetCoreSDKResolverPackageVersion)</MicrosoftDotnetSdkInternalPackageVersion>
7+
<MicrosoftNETILLinkTasksPackageVersion>9.0.0-preview.5.24256.1</MicrosoftNETILLinkTasksPackageVersion>
8+
<MicrosoftNETCoreAppRefPackageVersion>9.0.0-preview.5.24256.1</MicrosoftNETCoreAppRefPackageVersion>
79
<MicrosoftDotNetApiCompatPackageVersion>7.0.0-beta.22103.1</MicrosoftDotNetApiCompatPackageVersion>
810
<MicrosoftDotNetBuildTasksFeedPackageVersion>8.0.0-beta.24225.1</MicrosoftDotNetBuildTasksFeedPackageVersion>
911
<MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion>9.0.0-preview.5.24223.2</MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion>
1012
<MicrosoftNETWorkloadEmscriptenPackageVersion>$(MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion)</MicrosoftNETWorkloadEmscriptenPackageVersion>
1113
<MicrosoftTemplateEngineTasksPackageVersion>7.0.100-rc.1.22410.7</MicrosoftTemplateEngineTasksPackageVersion>
12-
<MicrosoftDotNetCecilPackageVersion>0.11.4-alpha.24222.1</MicrosoftDotNetCecilPackageVersion>
14+
<MicrosoftDotNetCecilPackageVersion>0.11.4-alpha.24230.1</MicrosoftDotNetCecilPackageVersion>
1315
<SystemIOHashingPackageVersion>$(MicrosoftNETCoreAppRefPackageVersion)</SystemIOHashingPackageVersion>
1416
</PropertyGroup>
1517
<PropertyGroup>

0 commit comments

Comments
 (0)