[XABT] Remove support for $(_AndroidGenerateNativeAssembly) = false (typemaps). (#10001)

Context: #9292

In #9292, we removed support for the "instant run" feature. This feature required the use of typemaps that existed outside of the "native" assemblies ($(_AndroidGenerateNativeAssembly) = false). This support is no longer needed, and in fact causes a build error if it is used:

Xamarin.Android.Common.targets(2132,3): error XA3006: Could not compile native assembly file: typemaps.x86_64.ll
As such, clean up our codebase to remove support for this.

Additionally, unused fields in the Module[Debug|Release]Data and TypeMap[Debug|Release]Entry data classes were removed to help make it clearer what data is required to generate typemaps.

Author: jpobst

src/Xamarin.Android.Build.Tasks/Tasks/GenerateTypeMappings.cs

@@ -4,7 +4,6 @@
 using System.Collections.Generic;
 using System.IO;
 using Java.Interop.Tools.Cecil;
-using Java.Interop.Tools.Diagnostics;
 using Microsoft.Android.Build.Tasks;
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
@@ -21,9 +20,6 @@ public class GenerateTypeMappings : AndroidTask
 
 	public bool Debug { get; set; }
 
-	[Required]
-	public bool GenerateNativeAssembly { get; set; }
-
 	[Required]
 	public string IntermediateOutputDirectory { get; set; } = "";
 
@@ -50,18 +46,10 @@ public override bool RunTask ()
 		);
 
 		NativeCodeGenState? templateCodeGenState = null;
-		bool typemapsAreAbiAgnostic = Debug && !GenerateNativeAssembly;
-		bool first = true;
 
 		foreach (var kvp in nativeCodeGenStates) {
-			if (!first && typemapsAreAbiAgnostic) {
-				Log.LogDebugMessage ("Typemaps: it's a debug build and type maps are ABI-agnostic, not processing more ABIs");
-				break;
-			}
-
 			NativeCodeGenState state = kvp.Value;
 			templateCodeGenState = state;
-			first = false;
 			WriteTypeMappings (state);
 		}
 
@@ -89,9 +77,7 @@ void WriteTypeMappings (NativeCodeGenState state)
 		}
 
 		var tmg = new TypeMapGenerator (Log, state, androidRuntime);
-		if (!tmg.Generate (Debug, SkipJniAddNativeMethodRegistrationAttributeScan, TypemapOutputDirectory, GenerateNativeAssembly)) {
-			throw new XamarinAndroidException (4308, Properties.Resources.XA4308);
-		}
+		tmg.Generate (Debug, SkipJniAddNativeMethodRegistrationAttributeScan, TypemapOutputDirectory);
 
 		string abi = MonoAndroidHelper.ArchToAbi (state.TargetArch);
 		var items = new List<ITaskItem> ();

src/Xamarin.Android.Build.Tasks/Utilities/TypeMapCecilAdapter.cs

@@ -1,12 +1,9 @@
 #nullable enable
 using System;
 using System.Collections.Generic;
-using System.IO;
-using System.Text;
 using Java.Interop.Tools.Cecil;
 using Mono.Cecil;
 
-using ModuleDebugData = Xamarin.Android.Tasks.TypeMapGenerator.ModuleDebugData;
 using ModuleReleaseData = Xamarin.Android.Tasks.TypeMapGenerator.ModuleReleaseData;
 using ReleaseGenerationState = Xamarin.Android.Tasks.TypeMapGenerator.ReleaseGenerationState;
 using TypeMapDebugEntry = Xamarin.Android.Tasks.TypeMapGenerator.TypeMapDebugEntry;
@@ -17,59 +14,6 @@ namespace Xamarin.Android.Tasks;
 // Converts types from Mono.Cecil to the format used by the typemap generator.
 class TypeMapCecilAdapter
 {
-	const string TypemapExtension = ".typemap";
-
-	public static Dictionary<string, ModuleDebugData> GetDebugModules (NativeCodeGenState state, string typemapFilesOutputDirectory, Encoding outputEncoding, out int maxModuleFileNameWidth)
-	{
-		var modules = new Dictionary<string, ModuleDebugData> (StringComparer.Ordinal);
-		maxModuleFileNameWidth = 0;
-		int maxModuleNameWidth = 0;
-
-		var javaDuplicates = new Dictionary<string, List<TypeMapDebugEntry>> (StringComparer.Ordinal);
-		foreach (TypeDefinition td in state.AllJavaTypes) {
-			UpdateApplicationConfig (state, td);
-			string moduleName = td.Module.Assembly.Name.Name;
-			ModuleDebugData module;
-
-			if (!modules.TryGetValue (moduleName, out module)) {
-				string outputFileName = $"{moduleName}{TypemapExtension}";
-				module = new ModuleDebugData {
-					EntryCount = 0,
-					JavaNameWidth = 0,
-					ManagedNameWidth = 0,
-					JavaToManagedMap = new List<TypeMapDebugEntry> (),
-					ManagedToJavaMap = new List<TypeMapDebugEntry> (),
-					OutputFilePath = Path.Combine (typemapFilesOutputDirectory, outputFileName),
-					ModuleName = moduleName,
-					ModuleNameBytes = outputEncoding.GetBytes (moduleName),
-				};
-
-				if (module.ModuleNameBytes.Length > maxModuleNameWidth)
-					maxModuleNameWidth = module.ModuleNameBytes.Length;
-
-				if (outputFileName.Length > maxModuleFileNameWidth)
-					maxModuleFileNameWidth = outputFileName.Length;
-
-				modules.Add (moduleName, module);
-			}
-
-			TypeMapDebugEntry entry = GetDebugEntry (td, state.TypeCache);
-			HandleDebugDuplicates (javaDuplicates, entry, td, state.TypeCache);
-			if (entry.JavaName.Length > module.JavaNameWidth)
-				module.JavaNameWidth = (uint) entry.JavaName.Length + 1;
-
-			if (entry.ManagedName.Length > module.ManagedNameWidth)
-				module.ManagedNameWidth = (uint) entry.ManagedName.Length + 1;
-
-			module.JavaToManagedMap.Add (entry);
-			module.ManagedToJavaMap.Add (entry);
-		}
-
-		SyncDebugDuplicates (javaDuplicates);
-
-		return modules;
-	}
-
 	public static (List<TypeMapDebugEntry> javaToManaged, List<TypeMapDebugEntry> managedToJava) GetDebugNativeEntries (NativeCodeGenState state)
 	{
 		var javaToManaged = new List<TypeMapDebugEntry> ();
@@ -102,7 +46,6 @@ public static ReleaseGenerationState GetReleaseGenerationState (NativeCodeGenSta
 		return genState;
 	}
 
-
 	static void ProcessReleaseType (NativeCodeGenState state, ReleaseGenerationState genState, TypeDefinition td)
 	{
 		UpdateApplicationConfig (state, td);
@@ -141,7 +84,6 @@ static void ProcessReleaseType (NativeCodeGenState state, ReleaseGenerationState
 			JavaName = javaName,
 			ManagedTypeName = td.FullName,
 			Token = td.MetadataToken.ToUInt32 (),
-			AssemblyNameIndex = genState.KnownAssemblies [GetAssemblyName (td)],
 			SkipInJavaToManaged = ShouldSkipInJavaToManaged (td),
 		};