[tests] ignore transient "Broken pipe" network errors (#10681)

This should allow us to ignore failure cases like:

    Mono.Android.NET_Tests, Xamarin.Android.NetTests.AndroidMessageHandlerTests.HttpContentStreamIsRewoundAfterCancellation / Release
    Error message
    System.AggregateException : AggregateException_ctor_DefaultMessage (Broken pipe)
    ----> System.Net.WebException : Broken pipe
    ----> Java.Net.SocketException : Broken pipe
    Stack trace
       at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean)
       at System.Threading.Tasks.Task.Wait(Int32, CancellationToken)
       at System.Threading.Tasks.Task.Wait()
       at NUnit.Framework.Internal.AsyncInvocationRegion.AsyncTaskInvocationRegion.WaitForPendingOperationsToComplete(Object)
       at NUnit.Framework.Internal.Commands.TestMethodCommand.RunAsyncTestMethod(TestExecutionContext)
    --WebException
       at Xamarin.Android.Net.AndroidMessageHandler.DoSendAsync(HttpRequestMessage, CancellationToken)
       at Xamarin.Android.Net.AndroidMessageHandler.SendWithNegotiateAuthenticationAsync(HttpRequestMessage, CancellationToken)
       at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage, HttpCompletionOption, CancellationTokenSource, Boolean, CancellationTokenSource, CancellationToken)
       at Xamarin.Android.NetTests.AndroidMessageHandlerTests.HttpContentStreamIsRewoundAfterCancellation()
    --SocketException
       at Java.Interop.JniEnvironment.InstanceMethods.CallIntMethod(JniObjectReference, JniMethodInfo , JniArgumentValue*)
       at Java.Interop.JniPeerMembers.JniInstanceMethods.InvokeVirtualInt32Method(String, IJavaPeerable, JniArgumentValue* )
       at Java.Net.HttpURLConnection.get_ResponseCode()
       at Xamarin.Android.Net.AndroidMessageHandler.<>c__DisplayClass140_0.<DoProcessRequest>b__2()
       at System.Threading.Tasks.Task`1[[System.Net.HttpStatusCode, System.Net.Primitives, Version=11.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].InnerInvoke()
       at System.Threading.Tasks.Task.<>c.<.cctor>b__289_0(Object obj)
       at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread, ExecutionContext, ContextCallback, Object)
    --- End of stack trace from previous location ---
       at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread, ExecutionContext, ContextCallback, Object)
       at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task&, Thread )
    --- End of stack trace from previous location ---
       at Xamarin.Android.Net.AndroidMessageHandler.DoProcessRequest(HttpRequestMessage, URL, HttpURLConnection, CancellationToken, RequestRedirectionState)
       at Xamarin.Android.Net.AndroidMessageHandler.DoSendAsync(HttpRequestMessage, CancellationToken)
      --- End of managed Java.Net.SocketException stack trace ---
    java.net.SocketException: Broken pipe
       at java.net.SocketOutputStream.socketWrite0(Native Method)
       at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:117)
       at java.net.SocketOutputStream.write(SocketOutputStream.java:161)
       at com.android.okhttp.okio.Okio$1.write(Okio.java:78)
       at com.android.okhttp.okio.AsyncTimeout$1.write(AsyncTimeout.java:157)
       at com.android.okhttp.okio.RealBufferedSink.flush(RealBufferedSink.java:222)
       at com.android.okhttp.internal.http.Http1xStream.finishRequest(Http1xStream.java:163)
       at com.android.okhttp.internal.http.HttpEngine.readNetworkResponse(HttpEngine.java:748)
       at com.android.okhttp.internal.http.HttpEngine.readResponse(HttpEngine.java:622)
       at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:475)
       at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:411)
       at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponseCode(HttpURLConnectionImpl.java:542)

Author: jonathanpeppers

tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidClientHandlerTests.cs

@@ -115,12 +115,15 @@ protected void RunIgnoringNetworkIssues (Action runner, out bool connectionFaile
 			}
 		}
 
-		bool IgnoreIfConnectionFailed (AggregateException aex, out bool connectionFailed)
+		protected bool IgnoreIfConnectionFailed (AggregateException aex, out bool connectionFailed)
 		{
 			if (IgnoreIfConnectionFailed (aex.InnerException as HttpRequestException, out connectionFailed))
 				return true;
 
-			return IgnoreIfConnectionFailed (aex.InnerException as WebException, out connectionFailed);
+			if (IgnoreIfConnectionFailed (aex.InnerException as WebException, out connectionFailed))
+				return true;
+
+			return IgnoreIfSocketException (aex, out connectionFailed);
 		}
 
 		bool IgnoreIfConnectionFailed (HttpRequestException hrex, out bool connectionFailed)
@@ -145,6 +148,26 @@ bool IgnoreIfConnectionFailed (WebException wex, out bool connectionFailed)
 
 			return false;
 		}
+
+		bool IgnoreIfSocketException (Exception ex, out bool connectionFailed)
+		{
+			connectionFailed = false;
+			// Check the exception and all inner exceptions for transient socket errors
+			var current = ex;
+			while (current != null) {
+				if (current is Java.Net.SocketException socketEx) {
+					var message = socketEx.Message ?? "";
+					if (message.Contains ("Broken pipe", StringComparison.OrdinalIgnoreCase) ||
+							message.Contains ("Connection reset", StringComparison.OrdinalIgnoreCase)) {
+						connectionFailed = true;
+						Assert.Ignore ($"Ignoring transient socket error: {socketEx}");
+						return true;
+					}
+				}
+				current = current.InnerException;
+			}
+			return false;
+		}
 	}
 
 	[Category ("AndroidClientHandler")]

tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidMessageHandlerTests.cs

@@ -385,6 +385,13 @@ public async Task HttpContentStreamIsRewoundAfterCancellation ()
 			try {
 				await client.SendAsync (request, tcs.Token).ConfigureAwait (false);
 				// If we get here without exception, that's also OK for this test
+			} catch (AggregateException ex) {
+				if (IgnoreIfConnectionFailed (ex, out _))
+					return;
+				// Expected - cancellation or connection error
+				// We catch all exceptions to ensure the test doesn't fail due to unhandled exceptions
+				Console.WriteLine ($"Exception during first request (expected): {ex}");
+				exceptionThrown = true;
 			} catch (Exception ex) {
 				// Expected - cancellation or connection error
 				// We catch all exceptions to ensure the test doesn't fail due to unhandled exceptions