Skip to content

Commit f834b55

Browse files
authored
[ci] Use long version for maestro publishing (#8964)
Commit bbac9fe ran into some issues when attempting to publish to maestro: error : Asset 'D:\a\_work\1\a\7dc04dfe-406a-4fa3-aea0-199acc2763fa\MergedManifest.xml' already exists with different contents at assets/manifests/xamarin-xamarin-android/34.99.0-dev/MergedManifest.xml We should be able to fix this by using the long package version which optionally includes pre-release labeling and commit distance info.
1 parent 14b70ac commit f834b55

File tree

2 files changed

+21
-19
lines changed

2 files changed

+21
-19
lines changed

build-tools/automation/azure-pipelines.yaml

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -537,17 +537,10 @@ extends:
537537
variables:
538538
- ${{ if eq(variables['MicroBuildSignType'], 'Real') }}:
539539
- group: Publish-Build-Assets
540-
templateContext:
541-
outputs:
542-
- output: nuget
543-
condition: and(succeeded(), eq('${{ parameters.pushXAPackagesToMaestro }}', 'true'))
544-
useDotNetTask: false # The default is false to use the NuGetCommand task. Set to true to use the DotNetCoreCLI task to publish packages.
545-
packagesToPush: $(Build.StagingDirectory)\nuget-signed\*.nupkg
546-
packageParentPath: $(Build.StagingDirectory)\nuget-signed
547-
nuGetFeedType: external
548-
publishFeedCredentials: $(DotNetFeedCredential)
549540
steps:
550541
- checkout: self
542+
clean: true
543+
submodules: recursive
551544

552545
- task: DownloadPipelineArtifact@2
553546
inputs:
@@ -606,14 +599,22 @@ extends:
606599
artifactName: vsdrop-multitarget-signed
607600
downloadPath: $(Build.StagingDirectory)\$(MultiTargetVSDropCommitStatusName)
608601

609-
- powershell: >-
610-
& dotnet build -v:n -c $(XA.Build.Configuration)
611-
-t:PushManifestToBuildAssetRegistry
612-
-p:BuildAssetRegistryToken=$(MaestroAccessToken)
613-
-p:OutputPath=$(Build.StagingDirectory)\nuget-signed\
614-
$(System.DefaultWorkingDirectory)\build-tools\create-packs\Microsoft.Android.Sdk.proj
615-
-bl:$(System.DefaultWorkingDirectory)\bin\Build$(XA.Build.Configuration)\push-bar-manifest.binlog
602+
- task: DotNetCoreCLI@2
603+
displayName: build Xamarin.Android.Tools.BootstrapTasks.sln
604+
inputs:
605+
projects: $(System.DefaultWorkingDirectory)\Xamarin.Android.BootstrapTasks.sln
606+
arguments: -c $(XA.Build.Configuration) -bl:$(System.DefaultWorkingDirectory)\bin\Build$(XA.Build.Configuration)\bootstrap.binlog
607+
condition: and(succeeded(), eq('${{ parameters.pushXAPackagesToMaestro }}', 'true'))
608+
609+
- task: DotNetCoreCLI@2
616610
displayName: generate and publish BAR manifest
611+
inputs:
612+
projects: $(System.DefaultWorkingDirectory)\build-tools\create-packs\Microsoft.Android.Sdk.proj
613+
arguments: >-
614+
-t:PushManifestToBuildAssetRegistry
615+
-p:BuildAssetRegistryToken=$(MaestroAccessToken)
616+
-p:OutputPath=$(Build.StagingDirectory)\nuget-signed\
617+
-c $(XA.Build.Configuration) -bl:$(System.DefaultWorkingDirectory)\bin\Build$(XA.Build.Configuration)\push-bar-manifest.binlog
617618
condition: and(succeeded(), eq('${{ parameters.pushXAPackagesToMaestro }}', 'true'))
618619

619620
- powershell: |

build-tools/create-packs/Directory.Build.targets

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,8 @@
164164
</Target>
165165

166166
<!-- https://github.com/dotnet/arcade/blob/efc3da96e5ac110513e92ebd9ef87c73f44d8540/Documentation/DependencyFlowOnboardingWithoutArcade.md -->
167-
<Target Name="PushManifestToBuildAssetRegistry" >
167+
<Target Name="PushManifestToBuildAssetRegistry"
168+
DependsOnTargets="GetXAVersionInfo" >
168169
<PropertyGroup>
169170
<ArtifactsLogDir>$(OutputPath)</ArtifactsLogDir>
170171
<AssetManifestFileName>Assets.xml</AssetManifestFileName>
@@ -204,12 +205,12 @@
204205
<MSBuild
205206
Targets="Restore"
206207
Projects="$(PkgMicrosoft_DotNet_Arcade_Sdk)\tools\SdkTasks\PublishBuildAssets.proj"
207-
Properties="Configuration=$(Configuration);RepoRoot=$(XamarinAndroidSourcePath);VersionPrefix=$(AndroidPackVersion)"
208+
Properties="Configuration=$(Configuration);RepoRoot=$(XamarinAndroidSourcePath);VersionPrefix=$(AndroidPackVersionLong)"
208209
/>
209210

210211
<MSBuild
211212
Projects="$(PkgMicrosoft_DotNet_Arcade_Sdk)\tools\SdkTasks\PublishBuildAssets.proj"
212-
Properties="Configuration=$(Configuration);RepoRoot=$(XamarinAndroidSourcePath);VersionPrefix=$(AndroidPackVersion);ManifestsPath=$(ArtifactsLogDir)AssetManifest;MaestroApiEndpoint=https://maestro.dot.net"
213+
Properties="Configuration=$(Configuration);RepoRoot=$(XamarinAndroidSourcePath);VersionPrefix=$(AndroidPackVersionLong);ManifestsPath=$(ArtifactsLogDir)AssetManifest;MaestroApiEndpoint=https://maestro.dot.net"
213214
/>
214215
</Target>
215216

0 commit comments

Comments
 (0)