Skip to content

Commit 8c44901

Browse files
authored
Pkgtool feedback (#15271)
1 parent 22f9fcf commit 8c44901

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

src/Microsoft.DotNet.MacOsPkg.Tests/Microsoft.DotNet.MacOsPkg.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>$(NetToolCurrent)</TargetFrameworks>
4+
<TargetFramework>$(NetToolCurrent)</TargetFramework>
55
<Nullable>enable</Nullable>
66
</PropertyGroup>
77

src/Microsoft.DotNet.MacOsPkg/Microsoft.DotNet.MacOsPkg.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>$(NetToolCurrent)</TargetFrameworks>
4+
<TargetFramework>$(NetToolCurrent)</TargetFramework>
55
<OutputType>Exe</OutputType>
66
<Nullable>enable</Nullable>
77
<IsPackable>true</IsPackable>
8-
<Description>MacOsPkg</Description>
8+
<Description>The MacOsPkg tool is used for unpacking and packing MacOS .pkg files and nested .app bundles.</Description>
99
<PackageTags>Arcade Build Tool MacOS Pkg</PackageTags>
1010
<DevelopmentDependency>false</DevelopmentDependency>
1111
<PackAsTool>true</PackAsTool>

src/Microsoft.DotNet.MacOsPkg/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
}
8080
catch (Exception e)
8181
{
82-
Console.Error.Write(e.Message);
82+
Console.Error.WriteLine(e);
8383
return 1;
8484
}
8585

src/Microsoft.DotNet.MacOsPkg/Utilities.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,21 @@
66

77
namespace Microsoft.DotNet.MacOsPkg
88
{
9-
public static class Utilities
9+
internal static class Utilities
1010
{
11-
internal static bool IsPkg(string path) =>
11+
public static bool IsPkg(string path) =>
1212
Path.GetExtension(path).Equals(".pkg");
1313

14-
internal static bool IsAppBundle(string path) =>
14+
public static bool IsAppBundle(string path) =>
1515
Path.GetExtension(path).Equals(".app");
1616

17-
internal static string? FindInPath(string name, string path, bool isDirectory, SearchOption searchOption = SearchOption.AllDirectories)
17+
public static string? FindInPath(string name, string path, bool isDirectory, SearchOption searchOption = SearchOption.AllDirectories)
1818
{
1919
string[] results = isDirectory ? Directory.GetDirectories(path, name, searchOption) : Directory.GetFiles(path, name, searchOption);
2020
return results.FirstOrDefault();
2121
}
2222

23-
internal static void CleanupPath(string path)
23+
public static void CleanupPath(string path)
2424
{
2525
if (Directory.Exists(path))
2626
{
@@ -32,7 +32,7 @@ internal static void CleanupPath(string path)
3232
}
3333
}
3434

35-
internal static void CreateParentDirectory(string path)
35+
public static void CreateParentDirectory(string path)
3636
{
3737
string? parent = Path.GetDirectoryName(path);
3838
if (!string.IsNullOrEmpty(parent))

0 commit comments

Comments
 (0)