Skip to content

Commit d487320

Browse files
Add detached signature CertificatesSignInfo (#16248)
1 parent 9aaf45f commit d487320

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

src/Microsoft.DotNet.Arcade.Sdk/tools/Sign.props

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030
<CertificatesSignInfo Include="MacDeveloperWithNotarization" MacCertificate="MacDeveloper" MacNotarizationAppName="dotnet" />
3131
<CertificatesSignInfo Include="MacDeveloperVNextWithNotarization" MacCertificate="MacDeveloperVNext" MacNotarizationAppName="dotnet" />
3232
<CertificatesSignInfo Include="MacDeveloperVNextHardenWithNotarization" MacCertificate="MacDeveloperVNextHarden" MacNotarizationAppName="dotnet" />
33+
<!-- Certificates Which support detached signatures -->
34+
<CertificatesSignInfo Include="LinuxSignTar" SupportsDetachedSignature="true" />
3335
</ItemGroup>
3436

3537
<!-- Only publish packages that contain this build's Target RID in the name.

src/Microsoft.DotNet.SignTool.Tests/SignToolTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2773,7 +2773,7 @@ public void ValidateSignToolTaskParsing()
27732773
}),
27742774
new TaskItem("DetachedArchiveCert", new Dictionary<string, string>
27752775
{
2776-
{ "DetachedSignature", "true" }
2776+
{ "SupportsDetachedSignature", "true" }
27772777
}),
27782778
};
27792779

src/Microsoft.DotNet.SignTool/src/SignToolTask.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ private Dictionary<string, List<AdditionalCertificateInformation>> ParseAddition
367367
var macSigningOperation = certificateSignInfo.GetMetadata("MacCertificate");
368368
var macNotarizationAppName = certificateSignInfo.GetMetadata("MacNotarizationAppName");
369369
var collisionPriorityId = certificateSignInfo.GetMetadata(SignToolConstants.CollisionPriorityId);
370-
var detachedSignatureCertificate = certificateSignInfo.GetMetadata("DetachedSignature");
370+
var detachedSignatureCertificate = certificateSignInfo.GetMetadata("SupportsDetachedSignature");
371371
bool detachedSignatureCertificateValue = false;
372372

373373
if (string.IsNullOrEmpty(macSigningOperation) != string.IsNullOrEmpty(macNotarizationAppName))

0 commit comments

Comments
 (0)