From 66e21b9135bb4d8f594c93add1568385e52856a9 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 12 Jun 2025 14:29:14 +0200 Subject: [PATCH 1/8] Downgrade TFMs to NetMinimum and NetFrameworkMinimum In an effort to decouple Arcade from the latest .NET SDK, downgrade project TFMs to the minimum in support versions. This means that projects target net8.0. Also set NetFrameworkMinimum to net472 as the Arcade tools and packages don't need to support a lower version and simplifies conditions and package dependencies. --- Directory.Build.props | 2 ++ Documentation/HowToCreatePackages.md | 4 ++-- ...crosoft.DotNet.SwaggerGenerator.MSBuild.InTree.targets | 8 ++++---- .../Microsoft.Arcade.Common.Tests.csproj | 2 +- .../Microsoft.Arcade.Common.csproj | 3 +-- .../Microsoft.Arcade.Test.Common.csproj | 2 +- .../Microsoft.Cci.Extensions.csproj | 3 +-- .../Microsoft.DotNet.Arcade.Sdk.Tests.csproj | 2 +- .../Microsoft.DotNet.Arcade.Sdk.csproj | 2 +- .../tools/SdkTasks/PublishArtifactsInManifest.proj | 2 +- .../tools/SdkTasks/PublishBuildAssets.proj | 2 +- .../tools/SdkTasks/PublishSignedAssets.proj | 2 +- .../tools/SdkTasks/PublishToSymbolServers.proj | 2 +- .../tools/SdkTasks/SigningValidation.proj | 2 +- src/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj | 4 ++-- .../Microsoft.DotNet.ArcadeAzureIntegration.csproj | 2 +- .../Microsoft.DotNet.ArcadeLogging.csproj | 2 +- .../Microsoft.DotNet.Build.Manifest.Tests.csproj | 2 +- .../Microsoft.DotNet.Build.Manifest.csproj | 2 +- .../Microsoft.DotNet.Build.Tasks.Archives.csproj | 2 +- .../Microsoft.DotNet.Build.Tasks.Feed.Tests.csproj | 2 +- .../Microsoft.DotNet.Build.Tasks.Feed.csproj | 2 +- .../Microsoft.DotNet.Build.Tasks.Installers.csproj | 2 +- .../src/Microsoft.DotNet.Build.Tasks.Packaging.csproj | 2 +- .../Microsoft.DotNet.Build.Tasks.Packaging.Tests.csproj | 2 +- .../Microsoft.DotNet.Build.Tasks.TargetFramework.csproj | 2 +- .../src/Microsoft.DotNet.Build.Tasks.Templating.csproj | 2 +- .../Microsoft.DotNet.Build.Tasks.Templating.Tests.csproj | 2 +- ...Microsoft.DotNet.Build.Tasks.VisualStudio.Tests.csproj | 2 +- .../Microsoft.DotNet.Build.Tasks.VisualStudio.csproj | 2 +- .../Microsoft.DotNet.Build.Tasks.Workloads.Tests.csproj | 2 +- .../src/Microsoft.DotNet.Build.Tasks.Workloads.csproj | 2 +- .../Microsoft.DotNet.CMake.Sdk.csproj | 2 +- .../Microsoft.DotNet.Deployment.Tasks.Links.csproj | 2 +- .../Microsoft.DotNet.GenAPI.csproj | 2 +- .../Microsoft.DotNet.GenFacades.csproj | 2 +- .../Client/CSharp/Microsoft.DotNet.Helix.Client.csproj | 3 +-- .../Microsoft.DotNet.Helix.JobSender.Tests.csproj | 2 +- .../JobSender/Microsoft.DotNet.Helix.JobSender.csproj | 3 +-- .../Microsoft.DotNet.Helix.Sdk.Tests.csproj | 2 +- .../Sdk/Microsoft.DotNet.Helix.Sdk.csproj | 2 +- ...oft.DotNet.Internal.DependencyInjection.Testing.csproj | 2 +- .../Microsoft.DotNet.Internal.SymbolHelper.csproj | 2 +- .../Microsoft.DotNet.MacOsPkg.Tests.csproj | 4 ++-- .../Cli/Microsoft.DotNet.MacOsPkg.Cli.csproj | 8 ++++---- .../Core/Microsoft.DotNet.MacOsPkg.Core.csproj | 2 +- .../tasks/Microsoft.DotNet.NuGetRepack.Tasks.csproj | 2 +- .../tests/Microsoft.DotNet.NuGetRepack.Tests.csproj | 2 +- .../Microsoft.DotNet.PackageTesting.Tests.csproj | 2 +- .../Microsoft.DotNet.PackageTesting.csproj | 2 +- .../tests/Microsoft.DotNet.RemoteExecutor.Tests.csproj | 2 +- .../Microsoft.DotNet.SharedFramework.Sdk.csproj | 2 +- src/Microsoft.DotNet.SharedFramework.Sdk/README.md | 2 +- .../Microsoft.DotNet.SignTool.Tests.csproj | 6 +++--- .../Microsoft.DotNet.SignTool.csproj | 2 +- .../tasks/Microsoft.DotNet.SourceBuild.Tasks.csproj | 2 +- .../tests/Microsoft.DotNet.SourceBuild.Tasks.Tests.csproj | 2 +- .../Microsoft.DotNet.StrongName.csproj | 2 +- .../Microsoft.DotNet.SwaggerGenerator.CmdLine.csproj | 2 +- .../Microsoft.DotNet.SwaggerGenerator.MSBuild.csproj | 2 +- src/Microsoft.DotNet.Tar/Microsoft.DotNet.Tar.csproj | 4 ++-- .../tests/Microsoft.DotNet.XUnitAssert.Tests.csproj | 2 +- .../src/Microsoft.DotNet.XUnitConsoleRunner.csproj | 2 +- .../tests/Microsoft.DotNet.XUnitExtensions.Tests.csproj | 2 +- .../Microsoft.DotNet.XliffTasks.Tests.csproj | 2 +- .../Microsoft.DotNet.XliffTasks.csproj | 2 +- .../Microsoft.DotNet.SignCheckLibrary.csproj | 6 +++--- src/SignCheck/SignCheck/Microsoft.DotNet.SignCheck.csproj | 2 +- .../SignCheckTask/Microsoft.DotNet.SignCheckTask.csproj | 2 +- .../Microsoft.DotNet.VersionTools.Cli.Tests.csproj | 2 +- .../Microsoft.DotNet.VersionTools.Cli.csproj | 2 +- .../Microsoft.DotNet.VersionTools.Tasks.Tests.csproj | 2 +- src/WinShimmer/WinShimmer.csproj | 2 +- tests/UnitTests.proj | 4 ++-- tests/XHarness.Tests.Common.props | 4 ++-- 75 files changed, 92 insertions(+), 94 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index b432639a72a..ffc9559ac3f 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -17,6 +17,8 @@ https://github.com/dotnet/arcade $(WarningsNotAsErrors);NU1901;NU1902;NU1903;NU1904 + $(NetCurrent) + net472 diff --git a/Documentation/HowToCreatePackages.md b/Documentation/HowToCreatePackages.md index aad2d8ce8a0..518b1fc87bf 100644 --- a/Documentation/HowToCreatePackages.md +++ b/Documentation/HowToCreatePackages.md @@ -32,9 +32,9 @@ One of the goals of Arcade is to be a vehicle to provide code sharing. One of th - If your package produces binaries that need to be signed, make sure to mark it as true or check the SignTool [documentation](../src/Microsoft.DotNet.SignTool/README.md) to see how to sign specific files. -- If the package needs to target a version of .NET Framework we recommend you to use the Arcade defined version, which is stored in the $(NetFxTfm) property. For instance: +- If the package needs to target a version of .NET Framework we recommend you to use the Arcade defined version, which is stored in the $(NetFrameworkMinimum) property. For instance: - `$(NetFxTfm);netcoreapp2.0` + `$(NetFrameworkMinimum);netcoreapp2.0` - There is no requirement to create a separate `.nuspec` file for the package. The package information will be automatically extracted from the `.csproj` file. diff --git a/eng/Microsoft.DotNet.SwaggerGenerator.MSBuild.InTree.targets b/eng/Microsoft.DotNet.SwaggerGenerator.MSBuild.InTree.targets index 7772d6a8c88..fa98506bd51 100644 --- a/eng/Microsoft.DotNet.SwaggerGenerator.MSBuild.InTree.targets +++ b/eng/Microsoft.DotNet.SwaggerGenerator.MSBuild.InTree.targets @@ -4,8 +4,8 @@ $([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'Microsoft.DotNet.SwaggerGenerator', 'Microsoft.DotNet.SwaggerGenerator.MSBuild')) $(ArtifactsBinDir)Microsoft.DotNet.SwaggerGenerator.MSBuild\$(Configuration)\ - $(MicrosoftDotNetSwaggerGeneratorMSBuildBaseOutputDirectory)$(NetToolCurrent)\ - $(MicrosoftDotNetSwaggerGeneratorMSBuildBaseOutputDirectory)$(NetFrameworkToolCurrent)\ + $(MicrosoftDotNetSwaggerGeneratorMSBuildBaseOutputDirectory)$(NetMinimum)\ + $(MicrosoftDotNetSwaggerGeneratorMSBuildBaseOutputDirectory)$(NetFrameworkMinimum)\ TaskHostFactory @@ -26,8 +26,8 @@ PrivateAssets="all" Private="false"> - TargetFramework=$(NetToolCurrent) - TargetFramework=$(NetFrameworkToolCurrent) + TargetFramework=$(NetMinimum) + TargetFramework=$(NetFrameworkMinimum) diff --git a/src/Common/Microsoft.Arcade.Common.Tests/Microsoft.Arcade.Common.Tests.csproj b/src/Common/Microsoft.Arcade.Common.Tests/Microsoft.Arcade.Common.Tests.csproj index 11cd8e38804..e014d51ff93 100644 --- a/src/Common/Microsoft.Arcade.Common.Tests/Microsoft.Arcade.Common.Tests.csproj +++ b/src/Common/Microsoft.Arcade.Common.Tests/Microsoft.Arcade.Common.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) enable diff --git a/src/Common/Microsoft.Arcade.Common/Microsoft.Arcade.Common.csproj b/src/Common/Microsoft.Arcade.Common/Microsoft.Arcade.Common.csproj index bf6d4c11032..b7c610821b9 100644 --- a/src/Common/Microsoft.Arcade.Common/Microsoft.Arcade.Common.csproj +++ b/src/Common/Microsoft.Arcade.Common/Microsoft.Arcade.Common.csproj @@ -1,8 +1,7 @@ - - $(NetToolCurrent);netstandard2.0;$(NetFrameworkToolCurrent) + $(NetMinimum);netstandard2.0;$(NetFrameworkMinimum) true **/*.Desktop.* diff --git a/src/Common/Microsoft.Arcade.Test.Common/Microsoft.Arcade.Test.Common.csproj b/src/Common/Microsoft.Arcade.Test.Common/Microsoft.Arcade.Test.Common.csproj index 4867a58638f..4aaa9aa0a66 100644 --- a/src/Common/Microsoft.Arcade.Test.Common/Microsoft.Arcade.Test.Common.csproj +++ b/src/Common/Microsoft.Arcade.Test.Common/Microsoft.Arcade.Test.Common.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true diff --git a/src/Microsoft.Cci.Extensions/Microsoft.Cci.Extensions.csproj b/src/Microsoft.Cci.Extensions/Microsoft.Cci.Extensions.csproj index 4a6d36711e0..7749d9118e1 100644 --- a/src/Microsoft.Cci.Extensions/Microsoft.Cci.Extensions.csproj +++ b/src/Microsoft.Cci.Extensions/Microsoft.Cci.Extensions.csproj @@ -1,8 +1,7 @@ - - $(NetToolCurrent);netstandard2.0;$(NetFrameworkToolCurrent) + $(NetMinimum);netstandard2.0;$(NetFrameworkMinimum) true true true diff --git a/src/Microsoft.DotNet.Arcade.Sdk.Tests/Microsoft.DotNet.Arcade.Sdk.Tests.csproj b/src/Microsoft.DotNet.Arcade.Sdk.Tests/Microsoft.DotNet.Arcade.Sdk.Tests.csproj index 01234e4c065..5aaef84ef84 100644 --- a/src/Microsoft.DotNet.Arcade.Sdk.Tests/Microsoft.DotNet.Arcade.Sdk.Tests.csproj +++ b/src/Microsoft.DotNet.Arcade.Sdk.Tests/Microsoft.DotNet.Arcade.Sdk.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) $(DefaultItemExcludes);testassets\**\* diff --git a/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj b/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj index baebf769c53..c95d472c6fa 100644 --- a/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj +++ b/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true true diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishArtifactsInManifest.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishArtifactsInManifest.proj index dbd512d4958..b049cfb3250 100644 --- a/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishArtifactsInManifest.proj +++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishArtifactsInManifest.proj @@ -76,7 +76,7 @@ --> - $(NetToolCurrent) + $(NetMinimum) Publish diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishBuildAssets.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishBuildAssets.proj index 6fbe0aa5c73..4c087020fbe 100644 --- a/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishBuildAssets.proj +++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishBuildAssets.proj @@ -19,7 +19,7 @@ - $(NetFrameworkToolCurrent) + $(NetFrameworkMinimum) Publish diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishSignedAssets.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishSignedAssets.proj index 5283b3274dc..f43d6b9a9fe 100644 --- a/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishSignedAssets.proj +++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishSignedAssets.proj @@ -3,7 +3,7 @@ Publish - $(NetToolCurrent) + $(NetMinimum) - $(NetToolCurrent) + $(NetMinimum) Publish diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/SigningValidation.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/SigningValidation.proj index c9b5e09585f..48339e456d0 100644 --- a/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/SigningValidation.proj +++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/SigningValidation.proj @@ -19,7 +19,7 @@ - $(NetToolCurrent) + $(NetMinimum) Build diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj index 9854fca07be..8a3aa4de1df 100644 --- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj +++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj @@ -62,7 +62,7 @@ $(NuGetPackageRoot)sn\$(SNVersion)\sn.exe - $(NuGetPackageRoot)microsoft.dotnet.macospkg.cli\$(MicrosoftDotNetMacOsPkgVersion)\tools\$(NetToolCurrent)\any\Microsoft.Dotnet.MacOsPkg.Cli.dll + $(NuGetPackageRoot)microsoft.dotnet.macospkg.cli\$(MicrosoftDotNetMacOsPkgVersion)\tools\$(NetMinimum)\any\Microsoft.Dotnet.MacOsPkg.Cli.dll - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) diff --git a/src/Microsoft.DotNet.ArcadeLogging/Microsoft.DotNet.ArcadeLogging.csproj b/src/Microsoft.DotNet.ArcadeLogging/Microsoft.DotNet.ArcadeLogging.csproj index 66710e1db8f..717e74aef85 100644 --- a/src/Microsoft.DotNet.ArcadeLogging/Microsoft.DotNet.ArcadeLogging.csproj +++ b/src/Microsoft.DotNet.ArcadeLogging/Microsoft.DotNet.ArcadeLogging.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) diff --git a/src/Microsoft.DotNet.Build.Manifest.Tests/Microsoft.DotNet.Build.Manifest.Tests.csproj b/src/Microsoft.DotNet.Build.Manifest.Tests/Microsoft.DotNet.Build.Manifest.Tests.csproj index f395d3cb3ca..6667a8ff81f 100644 --- a/src/Microsoft.DotNet.Build.Manifest.Tests/Microsoft.DotNet.Build.Manifest.Tests.csproj +++ b/src/Microsoft.DotNet.Build.Manifest.Tests/Microsoft.DotNet.Build.Manifest.Tests.csproj @@ -1,7 +1,7 @@  - $(NetToolCurrent) + $(NetMinimum) diff --git a/src/Microsoft.DotNet.Build.Manifest/Microsoft.DotNet.Build.Manifest.csproj b/src/Microsoft.DotNet.Build.Manifest/Microsoft.DotNet.Build.Manifest.csproj index 9bdb9f1d51f..96f8591db71 100644 --- a/src/Microsoft.DotNet.Build.Manifest/Microsoft.DotNet.Build.Manifest.csproj +++ b/src/Microsoft.DotNet.Build.Manifest/Microsoft.DotNet.Build.Manifest.csproj @@ -1,7 +1,7 @@  - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true diff --git a/src/Microsoft.DotNet.Build.Tasks.Archives/Microsoft.DotNet.Build.Tasks.Archives.csproj b/src/Microsoft.DotNet.Build.Tasks.Archives/Microsoft.DotNet.Build.Tasks.Archives.csproj index 03301ff8e12..7393ad940a1 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Archives/Microsoft.DotNet.Build.Tasks.Archives.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.Archives/Microsoft.DotNet.Build.Tasks.Archives.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) true true false diff --git a/src/Microsoft.DotNet.Build.Tasks.Feed.Tests/Microsoft.DotNet.Build.Tasks.Feed.Tests.csproj b/src/Microsoft.DotNet.Build.Tasks.Feed.Tests/Microsoft.DotNet.Build.Tasks.Feed.Tests.csproj index 7b091823dbe..e0bff620dc3 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Feed.Tests/Microsoft.DotNet.Build.Tasks.Feed.Tests.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.Feed.Tests/Microsoft.DotNet.Build.Tasks.Feed.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) false diff --git a/src/Microsoft.DotNet.Build.Tasks.Feed/Microsoft.DotNet.Build.Tasks.Feed.csproj b/src/Microsoft.DotNet.Build.Tasks.Feed/Microsoft.DotNet.Build.Tasks.Feed.csproj index bc70dea1458..b9c28fbe2a8 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Feed/Microsoft.DotNet.Build.Tasks.Feed.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.Feed/Microsoft.DotNet.Build.Tasks.Feed.csproj @@ -1,7 +1,7 @@  - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true false This package provides support for publishing assets to appropriate channels. diff --git a/src/Microsoft.DotNet.Build.Tasks.Installers/Microsoft.DotNet.Build.Tasks.Installers.csproj b/src/Microsoft.DotNet.Build.Tasks.Installers/Microsoft.DotNet.Build.Tasks.Installers.csproj index b802bc9a24a..0b32ae5e0a5 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Installers/Microsoft.DotNet.Build.Tasks.Installers.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.Installers/Microsoft.DotNet.Build.Tasks.Installers.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true true true diff --git a/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj b/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj index 3fd7becffb3..b09a768ded0 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true true MSBuildSdk diff --git a/src/Microsoft.DotNet.Build.Tasks.Packaging/tests/Microsoft.DotNet.Build.Tasks.Packaging.Tests.csproj b/src/Microsoft.DotNet.Build.Tasks.Packaging/tests/Microsoft.DotNet.Build.Tasks.Packaging.Tests.csproj index a8d9333437e..8bde4244bee 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Packaging/tests/Microsoft.DotNet.Build.Tasks.Packaging.Tests.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.Packaging/tests/Microsoft.DotNet.Build.Tasks.Packaging.Tests.csproj @@ -1,7 +1,7 @@  - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) false $(NoWarn);xUnit2013 diff --git a/src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/Microsoft.DotNet.Build.Tasks.TargetFramework.csproj b/src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/Microsoft.DotNet.Build.Tasks.TargetFramework.csproj index c3ad17606c7..e7974396920 100644 --- a/src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/Microsoft.DotNet.Build.Tasks.TargetFramework.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/Microsoft.DotNet.Build.Tasks.TargetFramework.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true true Configuration system for cross-targeting projects. diff --git a/src/Microsoft.DotNet.Build.Tasks.Templating/src/Microsoft.DotNet.Build.Tasks.Templating.csproj b/src/Microsoft.DotNet.Build.Tasks.Templating/src/Microsoft.DotNet.Build.Tasks.Templating.csproj index d4abc62784f..5502577ff24 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Templating/src/Microsoft.DotNet.Build.Tasks.Templating.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.Templating/src/Microsoft.DotNet.Build.Tasks.Templating.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) Templating task package true true diff --git a/src/Microsoft.DotNet.Build.Tasks.Templating/test/Microsoft.DotNet.Build.Tasks.Templating.Tests.csproj b/src/Microsoft.DotNet.Build.Tasks.Templating/test/Microsoft.DotNet.Build.Tasks.Templating.Tests.csproj index 03679598d86..5be6ae3e466 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Templating/test/Microsoft.DotNet.Build.Tasks.Templating.Tests.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.Templating/test/Microsoft.DotNet.Build.Tasks.Templating.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) diff --git a/src/Microsoft.DotNet.Build.Tasks.VisualStudio.Tests/Microsoft.DotNet.Build.Tasks.VisualStudio.Tests.csproj b/src/Microsoft.DotNet.Build.Tasks.VisualStudio.Tests/Microsoft.DotNet.Build.Tasks.VisualStudio.Tests.csproj index e276d85658e..55fef90cb3a 100644 --- a/src/Microsoft.DotNet.Build.Tasks.VisualStudio.Tests/Microsoft.DotNet.Build.Tasks.VisualStudio.Tests.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.VisualStudio.Tests/Microsoft.DotNet.Build.Tasks.VisualStudio.Tests.csproj @@ -1,7 +1,7 @@ - $(NetFrameworkToolCurrent) + $(NetFrameworkMinimum) diff --git a/src/Microsoft.DotNet.Build.Tasks.VisualStudio/Microsoft.DotNet.Build.Tasks.VisualStudio.csproj b/src/Microsoft.DotNet.Build.Tasks.VisualStudio/Microsoft.DotNet.Build.Tasks.VisualStudio.csproj index 410c5cee1c6..c500046ef31 100644 --- a/src/Microsoft.DotNet.Build.Tasks.VisualStudio/Microsoft.DotNet.Build.Tasks.VisualStudio.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.VisualStudio/Microsoft.DotNet.Build.Tasks.VisualStudio.csproj @@ -1,7 +1,7 @@ - $(NetFrameworkToolCurrent) + $(NetFrameworkMinimum) true true Arcade SDK build tasks for Visual Studio profile guided optimization training diff --git a/src/Microsoft.DotNet.Build.Tasks.Workloads.Tests/Microsoft.DotNet.Build.Tasks.Workloads.Tests.csproj b/src/Microsoft.DotNet.Build.Tasks.Workloads.Tests/Microsoft.DotNet.Build.Tasks.Workloads.Tests.csproj index cd322aac72d..e18b28ef78d 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Workloads.Tests/Microsoft.DotNet.Build.Tasks.Workloads.Tests.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.Workloads.Tests/Microsoft.DotNet.Build.Tasks.Workloads.Tests.csproj @@ -1,7 +1,7 @@  - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) diff --git a/src/Microsoft.DotNet.Build.Tasks.Workloads/src/Microsoft.DotNet.Build.Tasks.Workloads.csproj b/src/Microsoft.DotNet.Build.Tasks.Workloads/src/Microsoft.DotNet.Build.Tasks.Workloads.csproj index 0f1d87796bc..6798c7c3935 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Workloads/src/Microsoft.DotNet.Build.Tasks.Workloads.csproj +++ b/src/Microsoft.DotNet.Build.Tasks.Workloads/src/Microsoft.DotNet.Build.Tasks.Workloads.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true true true diff --git a/src/Microsoft.DotNet.CMake.Sdk/Microsoft.DotNet.CMake.Sdk.csproj b/src/Microsoft.DotNet.CMake.Sdk/Microsoft.DotNet.CMake.Sdk.csproj index 47b6a076af6..c8174f8017e 100644 --- a/src/Microsoft.DotNet.CMake.Sdk/Microsoft.DotNet.CMake.Sdk.csproj +++ b/src/Microsoft.DotNet.CMake.Sdk/Microsoft.DotNet.CMake.Sdk.csproj @@ -1,7 +1,7 @@  - $(NetToolCurrent) + $(NetMinimum) true Common toolset for calling into CMake from MSBuild and easily reference native assets from managed projects. MSBuildSdk diff --git a/src/Microsoft.DotNet.Deployment.Tasks.Links/Microsoft.DotNet.Deployment.Tasks.Links.csproj b/src/Microsoft.DotNet.Deployment.Tasks.Links/Microsoft.DotNet.Deployment.Tasks.Links.csproj index 18ba7e8e323..16ff23feb54 100644 --- a/src/Microsoft.DotNet.Deployment.Tasks.Links/Microsoft.DotNet.Deployment.Tasks.Links.csproj +++ b/src/Microsoft.DotNet.Deployment.Tasks.Links/Microsoft.DotNet.Deployment.Tasks.Links.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true true Aka.ms link manager diff --git a/src/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj b/src/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj index 841055a6823..799ca9c9659 100644 --- a/src/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj +++ b/src/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true MSBuildSdk true diff --git a/src/Microsoft.DotNet.GenFacades/Microsoft.DotNet.GenFacades.csproj b/src/Microsoft.DotNet.GenFacades/Microsoft.DotNet.GenFacades.csproj index 119fce5fc77..7028ad24f2d 100644 --- a/src/Microsoft.DotNet.GenFacades/Microsoft.DotNet.GenFacades.csproj +++ b/src/Microsoft.DotNet.GenFacades/Microsoft.DotNet.GenFacades.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) MSBuildSdk true true diff --git a/src/Microsoft.DotNet.Helix/Client/CSharp/Microsoft.DotNet.Helix.Client.csproj b/src/Microsoft.DotNet.Helix/Client/CSharp/Microsoft.DotNet.Helix.Client.csproj index e0e56b3ae1c..e9efec08ad1 100644 --- a/src/Microsoft.DotNet.Helix/Client/CSharp/Microsoft.DotNet.Helix.Client.csproj +++ b/src/Microsoft.DotNet.Helix/Client/CSharp/Microsoft.DotNet.Helix.Client.csproj @@ -1,8 +1,7 @@ - - $(NetToolCurrent);netstandard2.0;$(NetFrameworkToolCurrent) + $(NetMinimum);netstandard2.0;$(NetFrameworkMinimum) true This package provides access to the Helix Api located at https://helix.dot.net/ https://helix.dot.net/api/openapi.json diff --git a/src/Microsoft.DotNet.Helix/JobSender.Tests/Microsoft.DotNet.Helix.JobSender.Tests.csproj b/src/Microsoft.DotNet.Helix/JobSender.Tests/Microsoft.DotNet.Helix.JobSender.Tests.csproj index 63f357bd05a..070ff872314 100644 --- a/src/Microsoft.DotNet.Helix/JobSender.Tests/Microsoft.DotNet.Helix.JobSender.Tests.csproj +++ b/src/Microsoft.DotNet.Helix/JobSender.Tests/Microsoft.DotNet.Helix.JobSender.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) diff --git a/src/Microsoft.DotNet.Helix/JobSender/Microsoft.DotNet.Helix.JobSender.csproj b/src/Microsoft.DotNet.Helix/JobSender/Microsoft.DotNet.Helix.JobSender.csproj index e6886316066..a6ed5e97fc6 100644 --- a/src/Microsoft.DotNet.Helix/JobSender/Microsoft.DotNet.Helix.JobSender.csproj +++ b/src/Microsoft.DotNet.Helix/JobSender/Microsoft.DotNet.Helix.JobSender.csproj @@ -1,8 +1,7 @@ - - $(NetToolCurrent);netstandard2.0;$(NetFrameworkToolCurrent) + $(NetMinimum);netstandard2.0;$(NetFrameworkMinimum) true Microsoft.DotNet.Helix.Client This package provides a simple API for constructing and sending jobs to the Helix Api diff --git a/src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests.csproj b/src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests.csproj index 970d2627c6f..265441b094f 100644 --- a/src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests.csproj +++ b/src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) diff --git a/src/Microsoft.DotNet.Helix/Sdk/Microsoft.DotNet.Helix.Sdk.csproj b/src/Microsoft.DotNet.Helix/Sdk/Microsoft.DotNet.Helix.Sdk.csproj index 6e1b0a8cf9c..43c0a342afb 100644 --- a/src/Microsoft.DotNet.Helix/Sdk/Microsoft.DotNet.Helix.Sdk.csproj +++ b/src/Microsoft.DotNet.Helix/Sdk/Microsoft.DotNet.Helix.Sdk.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) MSBuildSdk true **/*.Desktop.* diff --git a/src/Microsoft.DotNet.Internal.DependencyInjection.Testing/Microsoft.DotNet.Internal.DependencyInjection.Testing.csproj b/src/Microsoft.DotNet.Internal.DependencyInjection.Testing/Microsoft.DotNet.Internal.DependencyInjection.Testing.csproj index 61cf5eb57df..8c454b7100e 100644 --- a/src/Microsoft.DotNet.Internal.DependencyInjection.Testing/Microsoft.DotNet.Internal.DependencyInjection.Testing.csproj +++ b/src/Microsoft.DotNet.Internal.DependencyInjection.Testing/Microsoft.DotNet.Internal.DependencyInjection.Testing.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) diff --git a/src/Microsoft.DotNet.Internal.SymbolHelper/Microsoft.DotNet.Internal.SymbolHelper.csproj b/src/Microsoft.DotNet.Internal.SymbolHelper/Microsoft.DotNet.Internal.SymbolHelper.csproj index 9b2bc487369..0fe7b4879ab 100644 --- a/src/Microsoft.DotNet.Internal.SymbolHelper/Microsoft.DotNet.Internal.SymbolHelper.csproj +++ b/src/Microsoft.DotNet.Internal.SymbolHelper/Microsoft.DotNet.Internal.SymbolHelper.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) true true diff --git a/src/Microsoft.DotNet.MacOsPkg.Tests/Microsoft.DotNet.MacOsPkg.Tests.csproj b/src/Microsoft.DotNet.MacOsPkg.Tests/Microsoft.DotNet.MacOsPkg.Tests.csproj index bf8fa2ea936..3ad8661506c 100644 --- a/src/Microsoft.DotNet.MacOsPkg.Tests/Microsoft.DotNet.MacOsPkg.Tests.csproj +++ b/src/Microsoft.DotNet.MacOsPkg.Tests/Microsoft.DotNet.MacOsPkg.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) enable @@ -23,7 +23,7 @@ diff --git a/src/Microsoft.DotNet.MacOsPkg/Cli/Microsoft.DotNet.MacOsPkg.Cli.csproj b/src/Microsoft.DotNet.MacOsPkg/Cli/Microsoft.DotNet.MacOsPkg.Cli.csproj index c5ac6d05aea..a92a516ca98 100644 --- a/src/Microsoft.DotNet.MacOsPkg/Cli/Microsoft.DotNet.MacOsPkg.Cli.csproj +++ b/src/Microsoft.DotNet.MacOsPkg/Cli/Microsoft.DotNet.MacOsPkg.Cli.csproj @@ -3,7 +3,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) Exe enable true @@ -13,11 +13,11 @@ - - + + - + true dotnet-macos-pkg diff --git a/src/Microsoft.DotNet.MacOsPkg/Core/Microsoft.DotNet.MacOsPkg.Core.csproj b/src/Microsoft.DotNet.MacOsPkg/Core/Microsoft.DotNet.MacOsPkg.Core.csproj index dc9776f9fe8..e01562ee8bc 100644 --- a/src/Microsoft.DotNet.MacOsPkg/Core/Microsoft.DotNet.MacOsPkg.Core.csproj +++ b/src/Microsoft.DotNet.MacOsPkg/Core/Microsoft.DotNet.MacOsPkg.Core.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) Library enable true diff --git a/src/Microsoft.DotNet.NuGetRepack/tasks/Microsoft.DotNet.NuGetRepack.Tasks.csproj b/src/Microsoft.DotNet.NuGetRepack/tasks/Microsoft.DotNet.NuGetRepack.Tasks.csproj index 64d4a8c22a0..d61209ede53 100644 --- a/src/Microsoft.DotNet.NuGetRepack/tasks/Microsoft.DotNet.NuGetRepack.Tasks.csproj +++ b/src/Microsoft.DotNet.NuGetRepack/tasks/Microsoft.DotNet.NuGetRepack.Tasks.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true true MSBuildSdk diff --git a/src/Microsoft.DotNet.NuGetRepack/tests/Microsoft.DotNet.NuGetRepack.Tests.csproj b/src/Microsoft.DotNet.NuGetRepack/tests/Microsoft.DotNet.NuGetRepack.Tests.csproj index c202f2e3d6a..3d7a40d0c20 100644 --- a/src/Microsoft.DotNet.NuGetRepack/tests/Microsoft.DotNet.NuGetRepack.Tests.csproj +++ b/src/Microsoft.DotNet.NuGetRepack/tests/Microsoft.DotNet.NuGetRepack.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) $(DefaultExcludesInProjectFolder);Resources\*.cs diff --git a/src/Microsoft.DotNet.PackageTesting.Tests/Microsoft.DotNet.PackageTesting.Tests.csproj b/src/Microsoft.DotNet.PackageTesting.Tests/Microsoft.DotNet.PackageTesting.Tests.csproj index ed72ff9eaf6..aca104b147d 100644 --- a/src/Microsoft.DotNet.PackageTesting.Tests/Microsoft.DotNet.PackageTesting.Tests.csproj +++ b/src/Microsoft.DotNet.PackageTesting.Tests/Microsoft.DotNet.PackageTesting.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) diff --git a/src/Microsoft.DotNet.PackageTesting/Microsoft.DotNet.PackageTesting.csproj b/src/Microsoft.DotNet.PackageTesting/Microsoft.DotNet.PackageTesting.csproj index 74b80da5bfe..83f64359309 100644 --- a/src/Microsoft.DotNet.PackageTesting/Microsoft.DotNet.PackageTesting.csproj +++ b/src/Microsoft.DotNet.PackageTesting/Microsoft.DotNet.PackageTesting.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) MSBuildSdk true true diff --git a/src/Microsoft.DotNet.RemoteExecutor/tests/Microsoft.DotNet.RemoteExecutor.Tests.csproj b/src/Microsoft.DotNet.RemoteExecutor/tests/Microsoft.DotNet.RemoteExecutor.Tests.csproj index 0db92001071..4de0294c2b7 100644 --- a/src/Microsoft.DotNet.RemoteExecutor/tests/Microsoft.DotNet.RemoteExecutor.Tests.csproj +++ b/src/Microsoft.DotNet.RemoteExecutor/tests/Microsoft.DotNet.RemoteExecutor.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) true diff --git a/src/Microsoft.DotNet.SharedFramework.Sdk/Microsoft.DotNet.SharedFramework.Sdk.csproj b/src/Microsoft.DotNet.SharedFramework.Sdk/Microsoft.DotNet.SharedFramework.Sdk.csproj index ab867e7a4a4..3a9528b8817 100644 --- a/src/Microsoft.DotNet.SharedFramework.Sdk/Microsoft.DotNet.SharedFramework.Sdk.csproj +++ b/src/Microsoft.DotNet.SharedFramework.Sdk/Microsoft.DotNet.SharedFramework.Sdk.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true true Common toolset for building shared frameworks and framework packs. diff --git a/src/Microsoft.DotNet.SharedFramework.Sdk/README.md b/src/Microsoft.DotNet.SharedFramework.Sdk/README.md index 5dd4313bcdc..8263b20e14e 100644 --- a/src/Microsoft.DotNet.SharedFramework.Sdk/README.md +++ b/src/Microsoft.DotNet.SharedFramework.Sdk/README.md @@ -15,7 +15,7 @@ An example project is included below: - net10.0 + $(NetCurrent) win-x64 Microsoft.Banana.App RuntimePack diff --git a/src/Microsoft.DotNet.SignTool.Tests/Microsoft.DotNet.SignTool.Tests.csproj b/src/Microsoft.DotNet.SignTool.Tests/Microsoft.DotNet.SignTool.Tests.csproj index dd77c5d1883..c1bd054ccd2 100644 --- a/src/Microsoft.DotNet.SignTool.Tests/Microsoft.DotNet.SignTool.Tests.csproj +++ b/src/Microsoft.DotNet.SignTool.Tests/Microsoft.DotNet.SignTool.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) @@ -18,14 +18,14 @@ diff --git a/src/Microsoft.DotNet.SignTool/Microsoft.DotNet.SignTool.csproj b/src/Microsoft.DotNet.SignTool/Microsoft.DotNet.SignTool.csproj index 6e87e071b39..998ce977fbb 100644 --- a/src/Microsoft.DotNet.SignTool/Microsoft.DotNet.SignTool.csproj +++ b/src/Microsoft.DotNet.SignTool/Microsoft.DotNet.SignTool.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true true true diff --git a/src/Microsoft.DotNet.SourceBuild/tasks/Microsoft.DotNet.SourceBuild.Tasks.csproj b/src/Microsoft.DotNet.SourceBuild/tasks/Microsoft.DotNet.SourceBuild.Tasks.csproj index 7f234c442ca..db380e62953 100644 --- a/src/Microsoft.DotNet.SourceBuild/tasks/Microsoft.DotNet.SourceBuild.Tasks.csproj +++ b/src/Microsoft.DotNet.SourceBuild/tasks/Microsoft.DotNet.SourceBuild.Tasks.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) MSBuildSdk true diff --git a/src/Microsoft.DotNet.SourceBuild/tests/Microsoft.DotNet.SourceBuild.Tasks.Tests.csproj b/src/Microsoft.DotNet.SourceBuild/tests/Microsoft.DotNet.SourceBuild.Tasks.Tests.csproj index 983f8ca0ec5..f8f21ae722d 100644 --- a/src/Microsoft.DotNet.SourceBuild/tests/Microsoft.DotNet.SourceBuild.Tasks.Tests.csproj +++ b/src/Microsoft.DotNet.SourceBuild/tests/Microsoft.DotNet.SourceBuild.Tasks.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) false diff --git a/src/Microsoft.DotNet.StrongName/Microsoft.DotNet.StrongName.csproj b/src/Microsoft.DotNet.StrongName/Microsoft.DotNet.StrongName.csproj index fd542d9a6c3..1c7e0edae66 100644 --- a/src/Microsoft.DotNet.StrongName/Microsoft.DotNet.StrongName.csproj +++ b/src/Microsoft.DotNet.StrongName/Microsoft.DotNet.StrongName.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) Library true true diff --git a/src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.CmdLine/Microsoft.DotNet.SwaggerGenerator.CmdLine.csproj b/src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.CmdLine/Microsoft.DotNet.SwaggerGenerator.CmdLine.csproj index 1131225c365..b2e20561d04 100644 --- a/src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.CmdLine/Microsoft.DotNet.SwaggerGenerator.CmdLine.csproj +++ b/src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.CmdLine/Microsoft.DotNet.SwaggerGenerator.CmdLine.csproj @@ -1,7 +1,7 @@  - $(NetToolCurrent) + $(NetMinimum) Exe true true diff --git a/src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.MSBuild/Microsoft.DotNet.SwaggerGenerator.MSBuild.csproj b/src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.MSBuild/Microsoft.DotNet.SwaggerGenerator.MSBuild.csproj index 93477f78700..778875f7fac 100644 --- a/src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.MSBuild/Microsoft.DotNet.SwaggerGenerator.MSBuild.csproj +++ b/src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.MSBuild/Microsoft.DotNet.SwaggerGenerator.MSBuild.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true true This package provides support for generating client library code from a swagger document. diff --git a/src/Microsoft.DotNet.Tar/Microsoft.DotNet.Tar.csproj b/src/Microsoft.DotNet.Tar/Microsoft.DotNet.Tar.csproj index 13690815698..c194b488ba7 100644 --- a/src/Microsoft.DotNet.Tar/Microsoft.DotNet.Tar.csproj +++ b/src/Microsoft.DotNet.Tar/Microsoft.DotNet.Tar.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) Exe true true @@ -10,7 +10,7 @@ false - + true dotnet-tar diff --git a/src/Microsoft.DotNet.XUnitAssert/tests/Microsoft.DotNet.XUnitAssert.Tests.csproj b/src/Microsoft.DotNet.XUnitAssert/tests/Microsoft.DotNet.XUnitAssert.Tests.csproj index 407bc9ff7cf..9916ed99aac 100644 --- a/src/Microsoft.DotNet.XUnitAssert/tests/Microsoft.DotNet.XUnitAssert.Tests.csproj +++ b/src/Microsoft.DotNet.XUnitAssert/tests/Microsoft.DotNet.XUnitAssert.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) enable $(NoWarn);xUnit2000;xUnit2003;xUnit2005;xUnit2007;xUnit2011;xUnit2015;xUnit2017 diff --git a/src/Microsoft.DotNet.XUnitConsoleRunner/src/Microsoft.DotNet.XUnitConsoleRunner.csproj b/src/Microsoft.DotNet.XUnitConsoleRunner/src/Microsoft.DotNet.XUnitConsoleRunner.csproj index 68bdb062ee1..5066302967e 100644 --- a/src/Microsoft.DotNet.XUnitConsoleRunner/src/Microsoft.DotNet.XUnitConsoleRunner.csproj +++ b/src/Microsoft.DotNet.XUnitConsoleRunner/src/Microsoft.DotNet.XUnitConsoleRunner.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) Exe xunit.console true diff --git a/src/Microsoft.DotNet.XUnitExtensions/tests/Microsoft.DotNet.XUnitExtensions.Tests.csproj b/src/Microsoft.DotNet.XUnitExtensions/tests/Microsoft.DotNet.XUnitExtensions.Tests.csproj index 41d1983b2d6..081908ec337 100644 --- a/src/Microsoft.DotNet.XUnitExtensions/tests/Microsoft.DotNet.XUnitExtensions.Tests.csproj +++ b/src/Microsoft.DotNet.XUnitExtensions/tests/Microsoft.DotNet.XUnitExtensions.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) diff --git a/src/Microsoft.DotNet.XliffTasks.Tests/Microsoft.DotNet.XliffTasks.Tests.csproj b/src/Microsoft.DotNet.XliffTasks.Tests/Microsoft.DotNet.XliffTasks.Tests.csproj index 0204cba0f3f..32021ce6e77 100644 --- a/src/Microsoft.DotNet.XliffTasks.Tests/Microsoft.DotNet.XliffTasks.Tests.csproj +++ b/src/Microsoft.DotNet.XliffTasks.Tests/Microsoft.DotNet.XliffTasks.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) MicrosoftAspNetCore diff --git a/src/Microsoft.DotNet.XliffTasks/Microsoft.DotNet.XliffTasks.csproj b/src/Microsoft.DotNet.XliffTasks/Microsoft.DotNet.XliffTasks.csproj index 165a4a7d5fd..14e28f244e2 100644 --- a/src/Microsoft.DotNet.XliffTasks/Microsoft.DotNet.XliffTasks.csproj +++ b/src/Microsoft.DotNet.XliffTasks/Microsoft.DotNet.XliffTasks.csproj @@ -1,7 +1,7 @@ - $(NetToolMinimum);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true true XliffTasks diff --git a/src/SignCheck/Microsoft.SignCheck/Microsoft.DotNet.SignCheckLibrary.csproj b/src/SignCheck/Microsoft.SignCheck/Microsoft.DotNet.SignCheckLibrary.csproj index c43fe8f8cb7..c985bd04b09 100644 --- a/src/SignCheck/Microsoft.SignCheck/Microsoft.DotNet.SignCheckLibrary.csproj +++ b/src/SignCheck/Microsoft.SignCheck/Microsoft.DotNet.SignCheckLibrary.csproj @@ -3,7 +3,7 @@ - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) Microsoft.SignCheck false @@ -38,7 +38,7 @@ CopyToOutputDirectory="PreserveNewest" /> - + @@ -59,7 +59,7 @@ - + diff --git a/src/SignCheck/SignCheck/Microsoft.DotNet.SignCheck.csproj b/src/SignCheck/SignCheck/Microsoft.DotNet.SignCheck.csproj index d0628c78798..be1ba255fe6 100644 --- a/src/SignCheck/SignCheck/Microsoft.DotNet.SignCheck.csproj +++ b/src/SignCheck/SignCheck/Microsoft.DotNet.SignCheck.csproj @@ -3,7 +3,7 @@ - $(NetFrameworkToolCurrent) + $(NetFrameworkMinimum) Exe true false diff --git a/src/SignCheck/SignCheckTask/Microsoft.DotNet.SignCheckTask.csproj b/src/SignCheck/SignCheckTask/Microsoft.DotNet.SignCheckTask.csproj index ede49db7e8c..f01262f0aad 100644 --- a/src/SignCheck/SignCheckTask/Microsoft.DotNet.SignCheckTask.csproj +++ b/src/SignCheck/SignCheckTask/Microsoft.DotNet.SignCheckTask.csproj @@ -1,7 +1,7 @@  - $(NetToolCurrent);$(NetFrameworkToolCurrent) + $(NetMinimum);$(NetFrameworkMinimum) true false true diff --git a/src/VersionTools/Microsoft.DotNet.VersionTools.Cli.Tests/Microsoft.DotNet.VersionTools.Cli.Tests.csproj b/src/VersionTools/Microsoft.DotNet.VersionTools.Cli.Tests/Microsoft.DotNet.VersionTools.Cli.Tests.csproj index ac8f8cfe175..63c0b81b8f0 100644 --- a/src/VersionTools/Microsoft.DotNet.VersionTools.Cli.Tests/Microsoft.DotNet.VersionTools.Cli.Tests.csproj +++ b/src/VersionTools/Microsoft.DotNet.VersionTools.Cli.Tests/Microsoft.DotNet.VersionTools.Cli.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) diff --git a/src/VersionTools/Microsoft.DotNet.VersionTools.Cli/Microsoft.DotNet.VersionTools.Cli.csproj b/src/VersionTools/Microsoft.DotNet.VersionTools.Cli/Microsoft.DotNet.VersionTools.Cli.csproj index e02e2d9a40e..c11c4f74e3c 100644 --- a/src/VersionTools/Microsoft.DotNet.VersionTools.Cli/Microsoft.DotNet.VersionTools.Cli.csproj +++ b/src/VersionTools/Microsoft.DotNet.VersionTools.Cli/Microsoft.DotNet.VersionTools.Cli.csproj @@ -1,7 +1,7 @@  - $(NetToolCurrent) + $(NetMinimum) Exe true true diff --git a/src/VersionTools/Microsoft.DotNet.VersionTools.Tasks.Tests/Microsoft.DotNet.VersionTools.Tasks.Tests.csproj b/src/VersionTools/Microsoft.DotNet.VersionTools.Tasks.Tests/Microsoft.DotNet.VersionTools.Tasks.Tests.csproj index deac5bd978a..6d9f269df6e 100644 --- a/src/VersionTools/Microsoft.DotNet.VersionTools.Tasks.Tests/Microsoft.DotNet.VersionTools.Tasks.Tests.csproj +++ b/src/VersionTools/Microsoft.DotNet.VersionTools.Tasks.Tests/Microsoft.DotNet.VersionTools.Tasks.Tests.csproj @@ -1,7 +1,7 @@ - $(NetToolCurrent) + $(NetMinimum) diff --git a/src/WinShimmer/WinShimmer.csproj b/src/WinShimmer/WinShimmer.csproj index 0b9e35e8b58..769d3d8e9d6 100644 --- a/src/WinShimmer/WinShimmer.csproj +++ b/src/WinShimmer/WinShimmer.csproj @@ -1,7 +1,7 @@ - $(NetFrameworkToolCurrent) + $(NetFrameworkMinimum) Exe diff --git a/tests/UnitTests.proj b/tests/UnitTests.proj index a497dadcc2d..581bd5618c7 100644 --- a/tests/UnitTests.proj +++ b/tests/UnitTests.proj @@ -3,8 +3,8 @@ - $(MSBuildThisFileDirectory)../artifacts/bin/Microsoft.DotNet.Helix.Sdk/$(Configuration)/$(NetToolCurrent)/publish/Microsoft.DotNet.Helix.Sdk.dll - $(MSBuildThisFileDirectory)../artifacts/bin/Microsoft.DotNet.Helix.Sdk/$(Configuration)/$(NetFrameworkToolCurrent)/publish/Microsoft.DotNet.Helix.Sdk.dll + $(MSBuildThisFileDirectory)../artifacts/bin/Microsoft.DotNet.Helix.Sdk/$(Configuration)/$(NetMinimum)/publish/Microsoft.DotNet.Helix.Sdk.dll + $(MSBuildThisFileDirectory)../artifacts/bin/Microsoft.DotNet.Helix.Sdk/$(Configuration)/$(NetFrameworkMinimum)/publish/Microsoft.DotNet.Helix.Sdk.dll diff --git a/tests/XHarness.Tests.Common.props b/tests/XHarness.Tests.Common.props index 2c46db86366..29124a88579 100644 --- a/tests/XHarness.Tests.Common.props +++ b/tests/XHarness.Tests.Common.props @@ -7,8 +7,8 @@ --> - $(MSBuildThisFileDirectory)../artifacts/bin/Microsoft.DotNet.Helix.Sdk/$(Configuration)/$(NetToolCurrent)/publish/Microsoft.DotNet.Helix.Sdk.dll - $(MSBuildThisFileDirectory)../artifacts/bin/Microsoft.DotNet.Helix.Sdk/$(Configuration)/$(NetFrameworkToolCurrent)/publish/Microsoft.DotNet.Helix.Sdk.dll + $(MSBuildThisFileDirectory)../artifacts/bin/Microsoft.DotNet.Helix.Sdk/$(Configuration)/$(NetMinimum)/publish/Microsoft.DotNet.Helix.Sdk.dll + $(MSBuildThisFileDirectory)../artifacts/bin/Microsoft.DotNet.Helix.Sdk/$(Configuration)/$(NetFrameworkMinimum)/publish/Microsoft.DotNet.Helix.Sdk.dll From bea0289af65daa63b0413d92740dd57940d15e92 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 12 Jun 2025 14:34:22 +0200 Subject: [PATCH 2/8] Downgrade msbuild version --- eng/Version.Details.xml | 8 ++++---- eng/Versions.props | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 48d674910ec..a0b5f069d8a 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -163,19 +163,19 @@ 43731346c220878a370328d0965b1ebd3269d5af - + https://github.com/dotnet/msbuild d1cce8d7cc03c23a4f1bad8e9240714fd9d199a3 - + https://github.com/dotnet/msbuild d1cce8d7cc03c23a4f1bad8e9240714fd9d199a3 - + https://github.com/dotnet/msbuild d1cce8d7cc03c23a4f1bad8e9240714fd9d199a3 - + https://github.com/dotnet/msbuild d1cce8d7cc03c23a4f1bad8e9240714fd9d199a3 diff --git a/eng/Versions.props b/eng/Versions.props index c92b5baa962..f401d958fdd 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -35,10 +35,10 @@ 2.0.0-preview.1.23470.14 2.0.0-preview.1.23470.14 - 17.12.36 - 17.12.36 - 17.12.36 - 17.12.36 + 17.11.31 + 17.11.31 + 17.11.31 + 17.11.31 2.0.3 From bf40647cc8e7f0745db3afd69f037d79f71418ee Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 12 Jun 2025 14:37:58 +0200 Subject: [PATCH 3/8] Add RollForward policy to tools --- .../Cli/Microsoft.DotNet.MacOsPkg.Cli.csproj | 1 + .../Core/Microsoft.DotNet.MacOsPkg.Core.csproj | 3 +-- .../src/Microsoft.DotNet.RemoteExecutor.csproj | 1 + .../Microsoft.DotNet.StrongName.csproj | 1 - .../Microsoft.DotNet.SwaggerGenerator.CmdLine.csproj | 1 + src/Microsoft.DotNet.Tar/Microsoft.DotNet.Tar.csproj | 3 ++- src/SignCheck/SignCheck/Microsoft.DotNet.SignCheck.csproj | 1 - 7 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/Microsoft.DotNet.MacOsPkg/Cli/Microsoft.DotNet.MacOsPkg.Cli.csproj b/src/Microsoft.DotNet.MacOsPkg/Cli/Microsoft.DotNet.MacOsPkg.Cli.csproj index a92a516ca98..5e54299a4bb 100644 --- a/src/Microsoft.DotNet.MacOsPkg/Cli/Microsoft.DotNet.MacOsPkg.Cli.csproj +++ b/src/Microsoft.DotNet.MacOsPkg/Cli/Microsoft.DotNet.MacOsPkg.Cli.csproj @@ -10,6 +10,7 @@ The MacOsPkg CLI tool is used for unpacking, packing, and validating MacOS .pkg files and nested .app bundles. Arcade Build Tool MacOS Pkg false + Major diff --git a/src/Microsoft.DotNet.MacOsPkg/Core/Microsoft.DotNet.MacOsPkg.Core.csproj b/src/Microsoft.DotNet.MacOsPkg/Core/Microsoft.DotNet.MacOsPkg.Core.csproj index e01562ee8bc..1dde6c46067 100644 --- a/src/Microsoft.DotNet.MacOsPkg/Core/Microsoft.DotNet.MacOsPkg.Core.csproj +++ b/src/Microsoft.DotNet.MacOsPkg/Core/Microsoft.DotNet.MacOsPkg.Core.csproj @@ -1,8 +1,7 @@ - $(NetMinimum) - Library + $(NetMinimum) enable true The MacOsPkg Library is used for unpacking, packing, and validating MacOS .pkg files and nested .app bundles. diff --git a/src/Microsoft.DotNet.RemoteExecutor/src/Microsoft.DotNet.RemoteExecutor.csproj b/src/Microsoft.DotNet.RemoteExecutor/src/Microsoft.DotNet.RemoteExecutor.csproj index 8a76b50f650..edc95c06bfb 100644 --- a/src/Microsoft.DotNet.RemoteExecutor/src/Microsoft.DotNet.RemoteExecutor.csproj +++ b/src/Microsoft.DotNet.RemoteExecutor/src/Microsoft.DotNet.RemoteExecutor.csproj @@ -9,6 +9,7 @@ true $(TargetsForTfmSpecificContentInPackage);PackBuildOutputs true + Major diff --git a/src/Microsoft.DotNet.StrongName/Microsoft.DotNet.StrongName.csproj b/src/Microsoft.DotNet.StrongName/Microsoft.DotNet.StrongName.csproj index 1c7e0edae66..778ed6ddd96 100644 --- a/src/Microsoft.DotNet.StrongName/Microsoft.DotNet.StrongName.csproj +++ b/src/Microsoft.DotNet.StrongName/Microsoft.DotNet.StrongName.csproj @@ -2,7 +2,6 @@ $(NetMinimum);$(NetFrameworkMinimum) - Library true true true diff --git a/src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.CmdLine/Microsoft.DotNet.SwaggerGenerator.CmdLine.csproj b/src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.CmdLine/Microsoft.DotNet.SwaggerGenerator.CmdLine.csproj index b2e20561d04..8006155a3fc 100644 --- a/src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.CmdLine/Microsoft.DotNet.SwaggerGenerator.CmdLine.csproj +++ b/src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.CmdLine/Microsoft.DotNet.SwaggerGenerator.CmdLine.csproj @@ -7,6 +7,7 @@ true dotnet-swaggergen false + Major diff --git a/src/Microsoft.DotNet.Tar/Microsoft.DotNet.Tar.csproj b/src/Microsoft.DotNet.Tar/Microsoft.DotNet.Tar.csproj index c194b488ba7..1ee1450c53e 100644 --- a/src/Microsoft.DotNet.Tar/Microsoft.DotNet.Tar.csproj +++ b/src/Microsoft.DotNet.Tar/Microsoft.DotNet.Tar.csproj @@ -8,9 +8,10 @@ Tar Arcade Build Tool Tar false + Major - + true dotnet-tar diff --git a/src/SignCheck/SignCheck/Microsoft.DotNet.SignCheck.csproj b/src/SignCheck/SignCheck/Microsoft.DotNet.SignCheck.csproj index be1ba255fe6..86a00105f24 100644 --- a/src/SignCheck/SignCheck/Microsoft.DotNet.SignCheck.csproj +++ b/src/SignCheck/SignCheck/Microsoft.DotNet.SignCheck.csproj @@ -8,7 +8,6 @@ true false true - true Build artifact signing validation tool Arcade Signing Validation Tool From f3e909a5ab33fccd70cc57b3f6d44a8742e2caa4 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 12 Jun 2025 14:42:12 +0200 Subject: [PATCH 4/8] Add 8.0 runtime for testing --- global.json | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/global.json b/global.json index 46d4b27da16..28dbc585289 100644 --- a/global.json +++ b/global.json @@ -6,7 +6,12 @@ "errorMessage": "The required .NET SDK wasn't found. Please run ./eng/common/dotnet.cmd/sh to install it." }, "tools": { - "dotnet": "10.0.100-preview.6.25302.104" + "dotnet": "10.0.100-preview.6.25302.104", + "runtimes": { + "dotnet": [ + "8.0.17" + ] + } }, "msbuild-sdks": { "Microsoft.DotNet.Arcade.Sdk": "10.0.0-beta.25311.1", From a22f1d03162ee2a2a4c0c237ec27b34b1d820db6 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 12 Jun 2025 14:49:39 +0200 Subject: [PATCH 5/8] Remove unnecessary RuntimeInformation package --- Directory.Packages.props | 2 -- eng/Versions.props | 2 -- .../src/Microsoft.DotNet.RemoteExecutor.csproj | 1 - .../src/Microsoft.DotNet.XUnitExtensions.csproj | 1 - 4 files changed, 6 deletions(-) diff --git a/Directory.Packages.props b/Directory.Packages.props index bcac667db34..e1b308c1477 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -30,8 +30,6 @@ - - diff --git a/eng/Versions.props b/eng/Versions.props index f401d958fdd..d5a84bffd54 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -27,8 +27,6 @@ 1.1.0-beta.25311.1 2.0.0-beta5.25210.1 - - 4.3.0 2.0.0-preview.1.24305.1 diff --git a/src/Microsoft.DotNet.RemoteExecutor/src/Microsoft.DotNet.RemoteExecutor.csproj b/src/Microsoft.DotNet.RemoteExecutor/src/Microsoft.DotNet.RemoteExecutor.csproj index edc95c06bfb..109252d92af 100644 --- a/src/Microsoft.DotNet.RemoteExecutor/src/Microsoft.DotNet.RemoteExecutor.csproj +++ b/src/Microsoft.DotNet.RemoteExecutor/src/Microsoft.DotNet.RemoteExecutor.csproj @@ -14,7 +14,6 @@ - diff --git a/src/Microsoft.DotNet.XUnitExtensions/src/Microsoft.DotNet.XUnitExtensions.csproj b/src/Microsoft.DotNet.XUnitExtensions/src/Microsoft.DotNet.XUnitExtensions.csproj index 46320c33f15..2a85cc0d005 100644 --- a/src/Microsoft.DotNet.XUnitExtensions/src/Microsoft.DotNet.XUnitExtensions.csproj +++ b/src/Microsoft.DotNet.XUnitExtensions/src/Microsoft.DotNet.XUnitExtensions.csproj @@ -10,7 +10,6 @@ - From a697bb5fc287acc0c9e84c713156eb4f4582fffb Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 12 Jun 2025 15:57:48 +0200 Subject: [PATCH 6/8] Don't use Architecture enum from BCL and use HexConverter polyfill for net8.0 --- .../src/CreateRpmPackage.cs | 19 +------- .../src/HexConverter.cs | 2 +- .../src/RpmBuilder.cs | 46 +++++++++---------- 3 files changed, 24 insertions(+), 43 deletions(-) diff --git a/src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateRpmPackage.cs b/src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateRpmPackage.cs index 41bd5450031..e3a6ae0a042 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateRpmPackage.cs +++ b/src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateRpmPackage.cs @@ -66,22 +66,7 @@ public sealed class CreateRpmPackage : BuildTask public override bool Execute() { - var arch = PackageArchitecture switch - { - "x86" => Architecture.X86, - "x64" => Architecture.X64, - "arm" => Architecture.Arm, - "arm64" => Architecture.Arm64, -#if NET - "armv6" => Architecture.Armv6, - "s390x" => Architecture.S390x, - "ppc64le" => Architecture.Ppc64le, - "riscv64" => Architecture.RiscV64, - "loongarch64" => Architecture.LoongArch64, -#endif - _ => throw new ArgumentException($"Unknown architecture: {PackageArchitecture}") - }; - RpmBuilder builder = new(PackageName, PackageVersion, PackageRelease, arch, OSPlatform.Create(PackageOS)) + RpmBuilder builder = new(PackageName, PackageVersion, PackageRelease, PackageArchitecture, OSPlatform.Create(PackageOS)) { Vendor = Vendor, Packager = Packager, @@ -107,7 +92,7 @@ public override bool Execute() } builder.AddProvidedCapability(PackageName, PackageVersion); - builder.AddProvidedCapability($"{PackageName}({RpmBuilder.GetRpmHeaderArchitecture(arch)})", PackageVersion); + builder.AddProvidedCapability($"{PackageName}({RpmBuilder.GetRpmHeaderArchitecture(PackageArchitecture)})", PackageVersion); HashSet ownedDirectories = new(OwnedDirectories.Select(d => d.ItemSpec)); diff --git a/src/Microsoft.DotNet.Build.Tasks.Installers/src/HexConverter.cs b/src/Microsoft.DotNet.Build.Tasks.Installers/src/HexConverter.cs index 0e6db40a605..6b599597a29 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Installers/src/HexConverter.cs +++ b/src/Microsoft.DotNet.Build.Tasks.Installers/src/HexConverter.cs @@ -1,7 +1,7 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -#if NET +#if NET9_0_OR_GREATER global using HexConverter = System.Convert; #else using System; diff --git a/src/Microsoft.DotNet.Build.Tasks.Installers/src/RpmBuilder.cs b/src/Microsoft.DotNet.Build.Tasks.Installers/src/RpmBuilder.cs index 68b5f81f4f9..58019215dfe 100644 --- a/src/Microsoft.DotNet.Build.Tasks.Installers/src/RpmBuilder.cs +++ b/src/Microsoft.DotNet.Build.Tasks.Installers/src/RpmBuilder.cs @@ -15,7 +15,7 @@ namespace Microsoft.DotNet.Build.Tasks.Installers { - internal sealed class RpmBuilder(string packageName, string version, string releaseVersion, Architecture architecture, OSPlatform os) + internal sealed class RpmBuilder(string packageName, string version, string releaseVersion, string architecture, OSPlatform os) { private readonly List<(string capability, string version)> _provides = []; private readonly List _conflicts = []; @@ -55,42 +55,38 @@ internal sealed class RpmBuilder(string packageName, string version, string rele new RpmHeader.Entry(RpmHeaderTag.Group, RpmHeaderEntryType.String, "default"), ]; - private static short GetRpmLeadArchitecture(Architecture architecture) + private static short GetRpmLeadArchitecture(string architecture) { // See /usr/lib/rpm/rpmrc for the canonical architecture mapping return architecture switch { - Architecture.X86 => 1, - Architecture.X64 => 1, - Architecture.Arm => 12, - Architecture.Arm64 => 19, -#if NET - Architecture.Armv6 => 12, - Architecture.S390x => 15, - Architecture.Ppc64le => 16, - Architecture.RiscV64 => 22, - Architecture.LoongArch64 => 23, -#endif + "x86" => 1, + "x64" => 1, + "arm" => 12, + "arm64" => 19, + "armv6" => 12, + "s390x" => 15, + "ppc64le" => 16, + "riscv64" => 22, + "loongarch64" => 23, _ => throw new ArgumentException("Unsupported architecture", nameof(architecture)) }; } - public static string GetRpmHeaderArchitecture(Architecture architecture) + public static string GetRpmHeaderArchitecture(string architecture) { // See /usr/lib/rpm/rpmrc for valida architecture values return architecture switch { - Architecture.X86 => "i686", - Architecture.X64 => "x86_64", - Architecture.Arm => "armv7hl", - Architecture.Arm64 => "aarch64", -#if NET - Architecture.Armv6 => "armv6hl", - Architecture.S390x => "s390x", - Architecture.Ppc64le => "ppc64le", - Architecture.RiscV64 => "riscv64", - Architecture.LoongArch64 => "loongarch64", -#endif + "x86" => "i686", + "x64" => "x86_64", + "arm" => "armv7hl", + "arm64" => "aarch64", + "armv6" => "armv6hl", + "s390x" => "s390x", + "ppc64le" => "ppc64le", + "riscv64" => "riscv64", + "loongarch64" => "loongarch64", _ => throw new ArgumentException("Unsupported architecture", nameof(architecture)) }; } From c9eea10f4e522d51395e1cead82db31ab5dacd24 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 12 Jun 2025 15:59:04 +0200 Subject: [PATCH 7/8] Remove non-needed using --- src/SignCheck/Microsoft.SignCheck/Verification/PkgVerifier.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/SignCheck/Microsoft.SignCheck/Verification/PkgVerifier.cs b/src/SignCheck/Microsoft.SignCheck/Verification/PkgVerifier.cs index 721eede4403..1b4dcbca7b1 100644 --- a/src/SignCheck/Microsoft.SignCheck/Verification/PkgVerifier.cs +++ b/src/SignCheck/Microsoft.SignCheck/Verification/PkgVerifier.cs @@ -10,7 +10,6 @@ using System.Linq; using Microsoft.DotNet.MacOsPkg.Core; using Microsoft.Tools.WindowsInstallerXml; -using System.IO.Pipelines; namespace Microsoft.SignCheck.Verification { From 10a3325428a6b6d56ffef956a01364b8eb2289d1 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 12 Jun 2025 18:08:27 +0200 Subject: [PATCH 8/8] Specify xunit publish target framework for helix --- Directory.Build.props | 1 + 1 file changed, 1 insertion(+) diff --git a/Directory.Build.props b/Directory.Build.props index ffc9559ac3f..d5154982d18 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -19,6 +19,7 @@ $(WarningsNotAsErrors);NU1901;NU1902;NU1903;NU1904 $(NetCurrent) net472 + $(NetMinimum)