update tests

Author: radical

eng/scripts/tests/test-get-aspire-cli-pr.ps1

@@ -327,7 +327,7 @@ function Test-MissingArtifactsScenarios {
     $nonExistentPR = 999999
     $result = Invoke-TestCommand -Command $Script:ScriptPath -Arguments @("-PRNumber", $nonExistentPR, "-InstallPath", $testInstallDir, "-WhatIf") -ExpectedExitCode 1
 
-    if ($result.Success -and ($result.Output -match "Failed to get PR information" -or $result.Output -match "Could not retrieve HEAD SHA")) {
+    if ($result.Success -and ($result.Output -match "Failed to get HEAD SHA" -or $result.Output -match "Could not retrieve HEAD SHA" -or $result.Output -match "Not Found")) {
         Write-TestResult "Non-existent PR number fails gracefully" "PASS"
     } else {
         Write-TestResult "Non-existent PR number fails gracefully" "FAIL" "Expected error message not found"
@@ -436,8 +436,9 @@ function Test-PRWithoutSuccessfulWorkflows {
 
     if ($result.Success) {
         $expectedMessages = @(
-            "Failed to get PR information",
+            "Failed to get HEAD SHA",
             "Could not retrieve HEAD SHA",
+            "Not Found",
             "does not exist",
             "don't have access"
         )

eng/scripts/tests/test-get-aspire-cli-pr.sh

@@ -81,7 +81,7 @@ test_verbose_flag() {
 }
 
 # Test: Short and long option equivalence
-test_option_equivalence() {
+test_option_equivalence_wrapper() {
     local test_cmd_short="$SCRIPT_UNDER_TEST $TEST_PR_NUMBER -i $TEST_INSTALL_DIR -r $TEST_RUN_ID -v -k --dry-run"
     local test_cmd_long="$SCRIPT_UNDER_TEST $TEST_PR_NUMBER --install-path $TEST_INSTALL_DIR --run-id $TEST_RUN_ID --verbose --keep-archive --dry-run"
 
@@ -144,7 +144,7 @@ test_nuget_hive_path() {
 # Test: Large PR number validation (should fail for non-existent PR)
 test_large_pr_number() {
     local large_pr="999999999"
-    run_test "Non-existent large PR numbers are properly rejected" "$SCRIPT_UNDER_TEST $large_pr --install-path $TEST_INSTALL_DIR --dry-run" 1 "Failed to get PR information" ""
+    run_test "Non-existent large PR numbers are properly rejected" "$SCRIPT_UNDER_TEST $large_pr --install-path $TEST_INSTALL_DIR --dry-run" 1 "Failed to get HEAD SHA" ""
 }
 
 # Test: Zero PR number rejection
@@ -193,7 +193,7 @@ run_all_tests() {
     test_dry_run_with_run_id
     test_dry_run_all_options
     test_verbose_flag
-    test_option_equivalence
+    test_option_equivalence_wrapper
     test_gh_dependency_check
     test_install_path_handling
 

eng/scripts/tests/test-utils.ps1

@@ -607,7 +607,7 @@ function Test-HelpFunctionality {
     Invoke-Test $TestName {
         try {
             $helpOutput = & pwsh -Command "Get-Help '$ScriptPath'" 2>&1 | Out-String
-            if ($helpOutput -and $helpOutput.Length -gt 0 -and ($helpOutput -match "SYNOPSIS" -or $helpOutput -match "DESCRIPTION")) {
+            if ($helpOutput -and $helpOutput.Length -gt 0 -and ($helpOutput -match "SYNOPSIS" -or $helpOutput -match "DESCRIPTION" -or $helpOutput -match "NAME")) {
                 Write-Output "Help functionality works: $helpOutput"
                 return $helpOutput
             } else {
@@ -617,7 +617,7 @@ function Test-HelpFunctionality {
         catch {
             throw "Help functionality failed: $($_.Exception.Message)"
         }
-    } 0 "SYNOPSIS|DESCRIPTION" ""
+    } 0 "SYNOPSIS" ""
 }
 
 <#
@@ -654,4 +654,5 @@ function Test-PlatformDetection {
 }
 
 # Export all functions for dot-sourcing
-Export-ModuleMember -Function *
+# Note: Export-ModuleMember is only valid in modules, not when dot-sourcing
+# The functions are already available when dot-sourcing this script