[release/9.4] Always set MSBUILDTERMINALLOGGER=false for all dotnet command executions in DotNetCliRunner (#10643)

* Initial plan

* Add MSBUILDTERMINALLOGGER=1 to all dotnet command executions

Co-authored-by: mitchdenny <[email protected]>

* Remove MSBUILDTERMINALLOGGER assertions from BuildAsyncAlwaysInjectsDotnetCliUseMsBuildServerEnvironmentVariable test

Co-authored-by: mitchdenny <[email protected]>

* Change MSBUILDTERMINALLOGGER value from "1" to "false" as requested

Co-authored-by: mitchdenny <[email protected]>

* Remove added MSBUILDTERMINALLOGGER tests as requested

Co-authored-by: mitchdenny <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: mitchdenny <[email protected]>

Author: 3 people

src/Aspire.Cli/DotNet/DotNetCliRunner.cs

@@ -437,6 +437,9 @@ public virtual async Task<int> ExecuteAsync(string[] args, IDictionary<string, s
         // not exist the orphan detector will exit.
         startInfo.EnvironmentVariables[KnownConfigNames.CliProcessId] = GetCurrentProcessId().ToString(CultureInfo.InvariantCulture);
 
+        // Always set MSBUILDTERMINALLOGGER=false for all dotnet command executions to ensure consistent terminal logger behavior
+        startInfo.EnvironmentVariables[KnownConfigNames.MsBuildTerminalLogger] = "false";
+
         var process = new Process { StartInfo = startInfo };
 
         logger.LogDebug("Running dotnet with args: {Args}", string.Join(" ", args));

src/Shared/KnownConfigNames.cs

@@ -32,6 +32,7 @@ internal static class KnownConfigNames
 
     public const string CliLocaleOverride = "ASPIRE_CLI_LOCALE_OVERRIDE";
     public const string DotnetCliUiLanguage = "DOTNET_CLI_UI_LANGUAGE";
+    public const string MsBuildTerminalLogger = "MSBUILDTERMINALLOGGER";
     public const string ExtensionEndpoint = "ASPIRE_EXTENSION_ENDPOINT";
     public const string ExtensionPromptEnabled = "ASPIRE_EXTENSION_PROMPT_ENABLED";
     public const string ExtensionToken = "ASPIRE_EXTENSION_TOKEN";