[release/9.4] Remove duplicate startup logging from DashboardLifecycleHook (#10692)

* Initial plan

* Remove duplicate startup logging from DashboardLifecycleHook

Co-authored-by: davidfowl <[email protected]>

* Restore ResourceReadyEvent handler as requested by @davidfowl

Co-authored-by: davidfowl <[email protected]>

* Remove duplicate logging from ConfigureEnvironmentVariables method

Co-authored-by: davidfowl <[email protected]>

* Update src/Aspire.Hosting/Dashboard/DashboardLifecycleHook.cs

* Dashboard URL parsing can happen out of sequence.

* Apply suggestions from code review

* Revert "Apply suggestions from code review"

This reverts commit cfd0231.

* Enhance StartAppHostAsync to optionally wait for dashboard URL during startup

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: davidfowl <[email protected]>
Co-authored-by: David Fowler <[email protected]>
Co-authored-by: Mitch Denny <[email protected]>

Author: 4 people

src/Aspire.Hosting/Dashboard/DashboardLifecycleHook.cs

@@ -344,19 +344,6 @@ internal async Task ConfigureEnvironmentVariables(EnvironmentCallbackContext con
             context.EnvironmentVariables[DashboardConfigNames.DebugSessionTelemetryOptOutName.EnvVarName] = optOutValue;
         }
 
-        if (!StringUtils.TryGetUriFromDelimitedString(options.DashboardUrl, ";", out var firstDashboardUrl))
-        {
-            return;
-        }
-
-        var dashboardUrl = codespaceUrlRewriter.RewriteUrl(firstDashboardUrl.ToString());
-
-        distributedApplicationLogger.LogInformation("Now listening on: {DashboardUrl}", dashboardUrl.TrimEnd('/'));
-
-        if (!string.IsNullOrEmpty(browserToken))
-        {
-            LoggingHelpers.WriteDashboardUrl(distributedApplicationLogger, dashboardUrl, browserToken, isContainer: false);
-        }
     }
 
     private static void PopulateDashboardUrls(EnvironmentCallbackContext context)

tests/Aspire.EndToEnd.Tests/IntegrationServicesFixture.cs

@@ -78,7 +78,9 @@ public async ValueTask InitializeAsync()
         {
             extraArgs += $"--skip-resources {skipArg}";
         }
-        await Project.StartAppHostAsync([extraArgs]);
+
+        var waitForDashboard = !_resourcesToSkip.HasFlag(TestResourceNames.dashboard);
+        await Project.StartAppHostAsync([extraArgs], waitForDashboardUrl: waitForDashboard);
 
         foreach (var project in Projects.Values)
         {

tests/Shared/TemplatesTesting/AspireProject.cs

@@ -158,7 +158,7 @@ public static async Task<AspireProject> CreateNewTemplateProjectAsync(
         return project;
     }
 
-    public async Task StartAppHostAsync(string[]? extraArgs = default, Action<ProcessStartInfo>? configureProcess = null, bool noBuild = true, CancellationToken token = default)
+    public async Task StartAppHostAsync(string[]? extraArgs = default, Action<ProcessStartInfo>? configureProcess = null, bool noBuild = true, bool waitForDashboardUrl = true, CancellationToken token = default)
     {
         if (IsRunning)
         {
@@ -169,6 +169,7 @@ public async Task StartAppHostAsync(string[]? extraArgs = default, Action<Proces
         var output = new StringBuilder();
         var projectsParsed = new TaskCompletionSource();
         var appRunning = new TaskCompletionSource();
+        var dashboardUrlParsed = new TaskCompletionSource();
         var stdoutComplete = new TaskCompletionSource();
         var stderrComplete = new TaskCompletionSource();
         AppExited = new();
@@ -213,6 +214,7 @@ public async Task StartAppHostAsync(string[]? extraArgs = default, Action<Proces
             if (m.Success)
             {
                 DashboardUrl = m.Groups["url"].Value;
+                dashboardUrlParsed.SetResult();
             }
 
             if (line?.StartsWith("$ENDPOINTS: ") == true)
@@ -263,7 +265,13 @@ public async Task StartAppHostAsync(string[]? extraArgs = default, Action<Proces
         AppHostProcess.BeginOutputReadLine();
         AppHostProcess.BeginErrorReadLine();
 
-        var successfulStartupTask = Task.WhenAll(appRunning.Task, projectsParsed.Task);
+        var tasksToWaitFor = new List<Task> { appRunning.Task, projectsParsed.Task };
+        if (waitForDashboardUrl)
+        {
+            tasksToWaitFor.Add(dashboardUrlParsed.Task);
+        }
+        
+        var successfulStartupTask = Task.WhenAll(tasksToWaitFor);
         var startupTimeoutTask = Task.Delay(TimeSpan.FromSeconds(AppStartupWaitTimeoutSecs), token);
 
         string outputMessage;