Add feature flag control for ExecCommand with default disabled (#10664) (#10669)

Co-authored-by: Copilot <[email protected]>

Author: mitchdenny

src/Aspire.Cli/Commands/RootCommand.cs

@@ -94,7 +94,10 @@ public RootCommand(
         {
             Subcommands.Add(deployCommand);
         }
-
-        Subcommands.Add(execCommand);
+        
+        if (featureFlags.IsFeatureEnabled(KnownFeatures.ExecCommandEnabled, false))
+        {
+            Subcommands.Add(execCommand);
+        }
     }
 }

src/Aspire.Cli/KnownFeatures.cs

@@ -10,4 +10,5 @@ internal static class KnownFeatures
     public static string UpdateNotificationsEnabled => "updateNotificationsEnabled";
     public static string MinimumSdkCheckEnabled => "minimumSdkCheckEnabled";
     public static string DeployCommandEnabled => "deployCommandEnabled";
+    public static string ExecCommandEnabled => "execCommandEnabled";
 }

tests/Aspire.Cli.Tests/Commands/ExecCommandTests.cs

@@ -42,6 +42,7 @@ public async Task ExecCommand_WhenNoProjectFileFound_ReturnsFailedToFindProject(
         using var workspace = TemporaryWorkspace.Create(_outputHelper);
         var services = CliTestHelper.CreateServiceCollection(workspace, _outputHelper, options =>
         {
+            options.EnabledFeatures = [KnownFeatures.ExecCommandEnabled];
             options.ProjectLocatorFactory = _ => new NoProjectFileProjectLocator();
         });
         var provider = services.BuildServiceProvider();
@@ -59,6 +60,7 @@ public async Task ExecCommand_WhenMultipleProjectFilesFound_ReturnsFailedToFindP
         using var workspace = TemporaryWorkspace.Create(_outputHelper);
         var services = CliTestHelper.CreateServiceCollection(workspace, _outputHelper, options =>
         {
+            options.EnabledFeatures = [KnownFeatures.ExecCommandEnabled];
             options.ProjectLocatorFactory = _ => new MultipleProjectFilesProjectLocator();
         });
         var provider = services.BuildServiceProvider();
@@ -76,6 +78,7 @@ public async Task ExecCommand_WhenProjectFileDoesNotExist_ReturnsFailedToFindPro
         using var workspace = TemporaryWorkspace.Create(_outputHelper);
         var services = CliTestHelper.CreateServiceCollection(workspace, _outputHelper, options =>
         {
+            options.EnabledFeatures = [KnownFeatures.ExecCommandEnabled];
             options.ProjectLocatorFactory = _ => new ProjectFileDoesNotExistLocator();
         });
         var provider = services.BuildServiceProvider();
@@ -87,6 +90,29 @@ public async Task ExecCommand_WhenProjectFileDoesNotExist_ReturnsFailedToFindPro
         Assert.Equal(ExitCodeConstants.FailedToFindProject, exitCode);
     }
 
+    [Fact]
+    public async Task ExecCommand_WhenFeatureFlagEnabled_CommandAvailable()
+    {
+        using var workspace = TemporaryWorkspace.Create(_outputHelper);
+        var services = CliTestHelper.CreateServiceCollection(workspace, _outputHelper, options =>
+        {
+            options.EnabledFeatures = [KnownFeatures.ExecCommandEnabled];
+        });
+        var provider = services.BuildServiceProvider();
+
+        var command = provider.GetRequiredService<RootCommand>();
+        var commandLineConfiguration = new CommandLineConfiguration(command);
+        var testOutputWriter = new TestOutputTextWriter(_outputHelper);
+        commandLineConfiguration.Output = testOutputWriter;
+
+        var result = command.Parse("exec --help", commandLineConfiguration);
+
+        var exitCode = await result.InvokeAsync().WaitAsync(CliTestConstants.DefaultTimeout);
+        
+        // Should succeed because exec command is registered when feature flag is enabled
+        Assert.Equal(ExitCodeConstants.Success, exitCode);
+    }
+
     [Fact]
     public async Task ExecCommand_WhenTargetResourceNotSpecified_ReturnsInvalidCommand()
     {
@@ -117,6 +143,7 @@ public async Task ExecCommand_ExecutesSuccessfully()
         using var workspace = TemporaryWorkspace.Create(_outputHelper);
         var services = CliTestHelper.CreateServiceCollection(workspace, _outputHelper, options =>
         {
+            options.EnabledFeatures = [KnownFeatures.ExecCommandEnabled];
             options.ProjectLocatorFactory = _ => new TestProjectLocator();
 
             options.DotNetCliRunnerFactory = _ => new TestDotNetCliRunner

tests/Aspire.Cli.Tests/Commands/SdkInstallerTests.cs

@@ -118,6 +118,7 @@ public async Task ExecCommand_WhenSdkNotInstalled_ReturnsCorrectExitCode()
         using var workspace = TemporaryWorkspace.Create(outputHelper);
         var services = CliTestHelper.CreateServiceCollection(workspace, outputHelper, options =>
         {
+            options.EnabledFeatures = [KnownFeatures.ExecCommandEnabled];
             options.DotNetSdkInstallerFactory = _ => new TestDotNetSdkInstaller
             {
                 CheckAsyncCallback = _ => false // SDK not installed