Add TFM tracking to InitContext for determining required AppHost framework (#11853)

* Initial plan

* Add ExecutableProjectInfo class with TFM tracking and RequiredAppHostFramework property

Co-authored-by: mitchdenny <[email protected]>

* Fix test compilation errors by adding missing interface methods

Co-authored-by: mitchdenny <[email protected]>

* Support apphost creation with max TFM verison.

* Fix build error.

* Some files somehow missed when rebased?

* Use SemVersion for TFM parsing and add IsSupportedTfm filter

Co-authored-by: mitchdenny <[email protected]>

* Update src/Aspire.Cli/Commands/InitCommand.cs

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: mitchdenny <[email protected]>
Co-authored-by: Mitch Denny <[email protected]>
Co-authored-by: Copilot <[email protected]>

Author: 3 people

src/Aspire.Cli/Commands/InitCommand.cs

@@ -176,7 +176,7 @@ later as needed.
             var selectedProjects = await InteractionService.PromptForSelectionsAsync(
                 "Select projects to add to the AppHost:",
                 initContext.ExecutableProjects,
-                project => Path.GetFileNameWithoutExtension(project.Name),
+                project => Path.GetFileNameWithoutExtension(project.ProjectFile.Name),
                 cancellationToken);
 
             initContext.ExecutableProjectsToAddToAppHost = selectedProjects;
@@ -190,7 +190,7 @@ later as needed.
 
                 foreach (var project in initContext.ExecutableProjectsToAddToAppHost)
                 {
-                    InteractionService.DisplayMessage("check_box_with_check", project.Name);
+                    InteractionService.DisplayMessage("check_box_with_check", project.ProjectFile.Name);
                 }
 
                 var addServiceDefaultsMessage = """
@@ -229,11 +229,11 @@ ServiceDefaults project contains helper code to make it easier
                         initContext.ProjectsToAddServiceDefaultsTo = await InteractionService.PromptForSelectionsAsync(
                             "Select projects to add ServiceDefaults reference to:",
                             initContext.ExecutableProjectsToAddToAppHost,
-                            project => Path.GetFileNameWithoutExtension(project.Name),
+                            project => Path.GetFileNameWithoutExtension(project.ProjectFile.Name),
                             cancellationToken);
                         break;
                     case "none":
-                        initContext.ProjectsToAddServiceDefaultsTo = Array.Empty<FileInfo>();
+                        initContext.ProjectsToAddServiceDefaultsTo = Array.Empty<ExecutableProjectInfo>();
                         break;
                 }
             }
@@ -281,7 +281,7 @@ ServiceDefaults project contains helper code to make it easier
                         "aspire", 
                         initContext.SolutionName, 
                         tempProjectDir, 
-                        [], // No extra args needed for aspire template
+                        ["--framework", initContext.RequiredAppHostFramework],
                         new DotNetCliRunnerInvocationOptions(), 
                         cancellationToken);
                 });
@@ -354,18 +354,18 @@ ServiceDefaults project contains helper code to make it easier
                 foreach(var project in initContext.ExecutableProjectsToAddToAppHost)
                 {
                     var addRefResult = await InteractionService.ShowStatusAsync(
-                        $"Adding {project.Name} to AppHost...", async () =>
+                        $"Adding {project.ProjectFile.Name} to AppHost...", async () =>
                         {
                             return await _runner.AddProjectReferenceAsync(
                                 appHostProjectFile,
-                                project,
+                                project.ProjectFile,
                                 new DotNetCliRunnerInvocationOptions(),
                                 cancellationToken);
                         });
 
                     if (addRefResult != 0)
                     {
-                        InteractionService.DisplayError($"Failed to add reference to {Path.GetFileNameWithoutExtension(project.Name)}.");
+                        InteractionService.DisplayError($"Failed to add reference to {Path.GetFileNameWithoutExtension(project.ProjectFile.Name)}.");
                         return addRefResult;
                     }
                 }
@@ -377,18 +377,18 @@ ServiceDefaults project contains helper code to make it easier
                 foreach (var project in initContext.ProjectsToAddServiceDefaultsTo)
                 {
                     var addRefResult = await InteractionService.ShowStatusAsync(
-                        $"Adding ServiceDefaults reference to {project.Name}...", async () =>
+                        $"Adding ServiceDefaults reference to {project.ProjectFile.Name}...", async () =>
                         {
                             return await _runner.AddProjectReferenceAsync(
-                                project,
+                                project.ProjectFile,
                                 serviceDefaultsProjectFile,
                                 new DotNetCliRunnerInvocationOptions(),
                                 cancellationToken);
                         });
 
                     if (addRefResult != 0)
                     {
-                        InteractionService.DisplayError($"Failed to add ServiceDefaults reference to {Path.GetFileNameWithoutExtension(project.Name)}.");
+                        InteractionService.DisplayError($"Failed to add ServiceDefaults reference to {Path.GetFileNameWithoutExtension(project.ProjectFile.Name)}.");
                         return addRefResult;
                     }
                 }
@@ -449,15 +449,15 @@ private async Task<int> CreateEmptyAppHostAsync(ParseResult parseResult, Cancell
 
     private async Task EvaluateSolutionProjectsAsync(InitContext initContext, CancellationToken cancellationToken)
     {
-        var executableProjects = new List<FileInfo>();
+        var executableProjects = new List<ExecutableProjectInfo>();
 
         foreach (var project in initContext.SolutionProjects)
         {
-            // Get both IsAspireHost and OutputType properties in a single call
+            // Get IsAspireHost, OutputType, and TargetFramework properties in a single call
             var (exitCode, jsonDoc) = await _runner.GetProjectItemsAndPropertiesAsync(
                 project,
                 [],
-                ["IsAspireHost", "OutputType"],
+                ["IsAspireHost", "OutputType", "TargetFramework"],
                 new DotNetCliRunnerInvocationOptions(),
                 cancellationToken);
 
@@ -483,7 +483,22 @@ private async Task EvaluateSolutionProjectsAsync(InitContext initContext, Cancel
                         var outputType = outputTypeElement.GetString();
                         if (outputType == "Exe" || outputType == "WinExe")
                         {
-                            executableProjects.Add(project);
+                            // Get the target framework
+                            var targetFramework = "net9.0"; // Default if not found
+                            if (properties.TryGetProperty("TargetFramework", out var targetFrameworkElement))
+                            {
+                                targetFramework = targetFrameworkElement.GetString() ?? "net9.0";
+                            }
+
+                            // Only add projects with supported TFMs
+                            if (IsSupportedTfm(targetFramework))
+                            {
+                                executableProjects.Add(new ExecutableProjectInfo
+                                {
+                                    ProjectFile = project,
+                                    TargetFramework = targetFramework
+                                });
+                            }
                         }
                     }
                 }
@@ -493,6 +508,22 @@ private async Task EvaluateSolutionProjectsAsync(InitContext initContext, Cancel
         initContext.ExecutableProjects = executableProjects;
     }
 
+    /// <summary>
+    /// Determines if the specified target framework moniker is supported.
+    /// </summary>
+    /// <param name="tfm">The target framework moniker to check.</param>
+    /// <returns>True if the TFM is supported; otherwise, false.</returns>
+    private static bool IsSupportedTfm(string tfm)
+    {
+        return tfm switch
+        {
+            "net8.0" => true,
+            "net9.0" => true,
+            "net10.0" => true,
+            _ => false
+        };
+    }
+
     private async Task<(NuGetPackage Package, PackageChannel Channel)> GetProjectTemplatesVersionAsync(ParseResult parseResult, CancellationToken cancellationToken)
     {
         var channels = await _packagingService.GetChannelsAsync(cancellationToken);
@@ -550,6 +581,22 @@ the latest stable version choose ***{{latestStable.Package.Version}}***.
     }
 }
 
+/// <summary>
+/// Represents information about an executable project including its file and target framework.
+/// </summary>
+internal sealed class ExecutableProjectInfo
+{
+    /// <summary>
+    /// Gets the project file.
+    /// </summary>
+    public required FileInfo ProjectFile { get; init; }
+
+    /// <summary>
+    /// Gets the target framework moniker (e.g., "net9.0", "net10.0").
+    /// </summary>
+    public required string TargetFramework { get; init; }
+}
+
 /// <summary>
 /// Context class for building up a model of the init operation before executing changes.
 /// </summary>
@@ -593,15 +640,60 @@ internal sealed class InitContext
     /// <summary>
     /// List of executable projects found in the solution (excluding the AppHost).
     /// </summary>
-    public IReadOnlyList<FileInfo> ExecutableProjects { get; set; } = Array.Empty<FileInfo>();
+    public IReadOnlyList<ExecutableProjectInfo> ExecutableProjects { get; set; } = Array.Empty<ExecutableProjectInfo>();
 
     /// <summary>
     /// Executable projects selected by the user to add to the AppHost.
     /// </summary>
-    public IReadOnlyList<FileInfo> ExecutableProjectsToAddToAppHost { get; set; } = Array.Empty<FileInfo>();
+    public IReadOnlyList<ExecutableProjectInfo> ExecutableProjectsToAddToAppHost { get; set; } = Array.Empty<ExecutableProjectInfo>();
 
     /// <summary>
     /// Projects selected by the user to add ServiceDefaults reference to.
     /// </summary>
-    public IReadOnlyList<FileInfo> ProjectsToAddServiceDefaultsTo { get; set; } = Array.Empty<FileInfo>();
+    public IReadOnlyList<ExecutableProjectInfo> ProjectsToAddServiceDefaultsTo { get; set; } = Array.Empty<ExecutableProjectInfo>();
+
+    /// <summary>
+    /// Gets the required AppHost framework based on the highest TFM of all selected executable projects.
+    /// </summary>
+    public string RequiredAppHostFramework
+    {
+        get
+        {
+            if (ExecutableProjectsToAddToAppHost.Count == 0)
+            {
+                return "net9.0"; // Default framework if no projects selected
+            }
+
+            // Parse and compare TFMs to find the highest one using SemVersion
+            SemVersion? highestVersion = null;
+            var highestTfm = "net9.0";
+
+            foreach (var project in ExecutableProjectsToAddToAppHost)
+            {
+                var tfm = project.TargetFramework;
+                if (tfm.StartsWith("net", StringComparison.OrdinalIgnoreCase))
+                {
+                    var versionString = tfm[3..];
+                    // Add patch version if not present for SemVersion parsing
+                    // TFMs are in format "8.0", "9.0", "10.0", need to make them "8.0.0", "9.0.0", "10.0.0"
+                    var dotCount = versionString.Count(c => c == '.');
+                    if (dotCount == 1)
+                    {
+                        versionString += ".0";
+                    }
+                    
+                    if (SemVersion.TryParse(versionString, SemVersionStyles.Strict, out var version))
+                    {
+                        if (highestVersion is null || SemVersion.ComparePrecedence(version, highestVersion) > 0)
+                        {
+                            highestVersion = version;
+                            highestTfm = tfm;
+                        }
+                    }
+                }
+            }
+
+            return highestTfm;
+        }
+    }
 }

tests/Aspire.Cli.Tests/Commands/InitCommandTests.cs

@@ -13,6 +13,49 @@ namespace Aspire.Cli.Tests.Commands;
 
 public class InitCommandTests(ITestOutputHelper outputHelper)
 {
+    [Fact]
+    public void InitContext_RequiredAppHostFramework_ReturnsHighestTfm()
+    {
+        // Arrange
+        var initContext = new InitContext();
+        
+        // Act & Assert - No projects selected returns default
+        Assert.Equal("net9.0", initContext.RequiredAppHostFramework);
+        
+        // Set up projects with different TFMs
+        initContext.ExecutableProjectsToAddToAppHost = new List<ExecutableProjectInfo>
+        {
+            new() { ProjectFile = new FileInfo("/test/project1.csproj"), TargetFramework = "net8.0" },
+            new() { ProjectFile = new FileInfo("/test/project2.csproj"), TargetFramework = "net9.0" },
+            new() { ProjectFile = new FileInfo("/test/project3.csproj"), TargetFramework = "net10.0" }
+        };
+        
+        // Act
+        var result = initContext.RequiredAppHostFramework;
+        
+        // Assert
+        Assert.Equal("net10.0", result);
+        
+        // Test with only lower versions
+        initContext.ExecutableProjectsToAddToAppHost = new List<ExecutableProjectInfo>
+        {
+            new() { ProjectFile = new FileInfo("/test/project1.csproj"), TargetFramework = "net8.0" },
+            new() { ProjectFile = new FileInfo("/test/project2.csproj"), TargetFramework = "net9.0" }
+        };
+        
+        result = initContext.RequiredAppHostFramework;
+        Assert.Equal("net9.0", result);
+        
+        // Test with only net8.0
+        initContext.ExecutableProjectsToAddToAppHost = new List<ExecutableProjectInfo>
+        {
+            new() { ProjectFile = new FileInfo("/test/project1.csproj"), TargetFramework = "net8.0" }
+        };
+        
+        result = initContext.RequiredAppHostFramework;
+        Assert.Equal("net8.0", result);
+    }
+
     [Fact]
     public async Task InitCommand_WithSingleFileAppHost_DoesNotPromptForProjectNameOrOutputPath()
     {

tests/Aspire.Cli.Tests/Snapshots/Merge_ExtraPatternOnDailyFeedWhenOnPrFeedGetsConsolidatedWithOtherPatterns_ProducesExpectedXml.daily.verified.xml

@@ -4,7 +4,6 @@
     <add key="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" />
     <add key="https://api.nuget.org/v3/index.json" value="https://api.nuget.org/v3/index.json" />
     <add key="mycompany" value="http://mycompany.com/feed" />
-    <add key="C:\Users\midenn\.aspire\hives\pr-11275" value="C:\Users\midenn\.aspire\hives\pr-11275" />
   </packageSources>
   <packageSourceMapping>
     <packageSource key="https://api.nuget.org/v3/index.json">
@@ -14,9 +13,6 @@
       <package pattern="Microsoft.Extensions.HelperStuff*" />
       <package pattern="Aspire*" />
     </packageSource>
-    <packageSource key="C:\Users\midenn\.aspire\hives\pr-11275">
-      <package pattern="Microsoft.Extensions.ServiceDiscovery*" />
-    </packageSource>
     <packageSource key="mycompany">
       <package pattern="*" />
     </packageSource>

tests/Aspire.Cli.Tests/Snapshots/Merge_ExtraPatternOnDailyFeedWhenOnPrFeedGetsConsolidatedWithOtherPatterns_ProducesExpectedXml.pr-1234.verified.xml

@@ -4,7 +4,6 @@
     <add key="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" />
     <add key="https://api.nuget.org/v3/index.json" value="https://api.nuget.org/v3/index.json" />
     <add key="mycompany" value="http://mycompany.com/feed" />
-    <add key="C:\Users\midenn\.aspire\hives\pr-11275" value="C:\Users\midenn\.aspire\hives\pr-11275" />
     <add key="{PR_HIVE}" value="{PR_HIVE}" />
   </packageSources>
   <packageSourceMapping>
@@ -14,9 +13,6 @@
     <packageSource key="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json">
       <package pattern="Microsoft.Extensions.HelperStuff*" />
     </packageSource>
-    <packageSource key="C:\Users\midenn\.aspire\hives\pr-11275">
-      <package pattern="Microsoft.Extensions.ServiceDiscovery*" />
-    </packageSource>
     <packageSource key="{PR_HIVE}">
       <package pattern="Aspire*" />
       <package pattern="*" />

tests/Aspire.Cli.Tests/Snapshots/Merge_ExtraPatternOnDailyFeedWhenOnPrFeedGetsConsolidatedWithOtherPatterns_ProducesExpectedXml.stable.verified.xml

@@ -4,7 +4,6 @@
     <add key="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" />
     <add key="https://api.nuget.org/v3/index.json" value="https://api.nuget.org/v3/index.json" />
     <add key="mycompany" value="http://mycompany.com/feed" />
-    <add key="C:\Users\midenn\.aspire\hives\pr-11275" value="C:\Users\midenn\.aspire\hives\pr-11275" />
   </packageSources>
   <packageSourceMapping>
     <packageSource key="https://api.nuget.org/v3/index.json">
@@ -13,9 +12,6 @@
     <packageSource key="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json">
       <package pattern="Microsoft.Extensions.HelperStuff*" />
     </packageSource>
-    <packageSource key="C:\Users\midenn\.aspire\hives\pr-11275">
-      <package pattern="Microsoft.Extensions.ServiceDiscovery*" />
-    </packageSource>
     <packageSource key="mycompany">
       <package pattern="*" />
     </packageSource>

tests/Aspire.Cli.Tests/Snapshots/Merge_WithBrokenSdkState_ProducesExpectedXml.daily.verified.xml

@@ -3,15 +3,11 @@
     <clear />
     <add key="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" />
     <add key="https://api.nuget.org/v3/index.json" value="https://api.nuget.org/v3/index.json" />
-    <add key="C:\Users\davifowl\.aspire\hives\pr-11227" value="C:\Users\davifowl\.aspire\hives\pr-11227" />
   </packageSources>
   <packageSourceMapping>
     <packageSource key="https://api.nuget.org/v3/index.json">
       <package pattern="*" />
     </packageSource>
-    <packageSource key="C:\Users\davifowl\.aspire\hives\pr-11227">
-      <package pattern="Microsoft.Extensions.ServiceDiscovery*" />
-    </packageSource>
     <packageSource key="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json">
       <package pattern="Aspire*" />
     </packageSource>

tests/Aspire.Cli.Tests/Snapshots/Merge_WithBrokenSdkState_ProducesExpectedXml.pr-1234.verified.xml

@@ -2,16 +2,12 @@
   <packageSources>
     <clear />
     <add key="https://api.nuget.org/v3/index.json" value="https://api.nuget.org/v3/index.json" />
-    <add key="C:\Users\davifowl\.aspire\hives\pr-11227" value="C:\Users\davifowl\.aspire\hives\pr-11227" />
     <add key="{PR_HIVE}" value="{PR_HIVE}" />
   </packageSources>
   <packageSourceMapping>
     <packageSource key="https://api.nuget.org/v3/index.json">
       <package pattern="*" />
     </packageSource>
-    <packageSource key="C:\Users\davifowl\.aspire\hives\pr-11227">
-      <package pattern="Microsoft.Extensions.ServiceDiscovery*" />
-    </packageSource>
     <packageSource key="{PR_HIVE}">
       <package pattern="Aspire*" />
       <package pattern="*" />

tests/Aspire.Cli.Tests/Snapshots/Merge_WithBrokenSdkState_ProducesExpectedXml.stable.verified.xml

@@ -2,14 +2,10 @@
   <packageSources>
     <clear />
     <add key="https://api.nuget.org/v3/index.json" value="https://api.nuget.org/v3/index.json" />
-    <add key="C:\Users\davifowl\.aspire\hives\pr-11227" value="C:\Users\davifowl\.aspire\hives\pr-11227" />
   </packageSources>
   <packageSourceMapping>
     <packageSource key="https://api.nuget.org/v3/index.json">
       <package pattern="*" />
     </packageSource>
-    <packageSource key="C:\Users\davifowl\.aspire\hives\pr-11227">
-      <package pattern="Microsoft.Extensions.ServiceDiscovery*" />
-    </packageSource>
   </packageSourceMapping>
 </configuration>

tests/Aspire.Cli.Tests/Snapshots/Merge_WithDailyFeedWithExtraMappingsIsPreserved_ProducesExpectedXml.daily.verified.xml

@@ -8,7 +8,6 @@
   <packageSourceMapping>
     <packageSource key="dotnet9">
       <package pattern="Aspire*" />
-      <package pattern="Microsoft.Extensions.ServiceDiscovery*" />
       <package pattern="Microsoft.Extensions.SpecialPackage*" />
     </packageSource>
     <packageSource key="NuGet">