[release/9.4] Fix GitHubModels health check dependency on IHttpClientFactory (#10626)

* Initial plan

* Apply PR #10624 changes to fix GitHubModels health check dependency on IHttpClientFactory

Co-authored-by: sebastienros <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: sebastienros <[email protected]>

Author: Copilot

src/Aspire.Hosting.GitHub.Models/GitHubModelsExtensions.cs

@@ -129,6 +129,9 @@ public static IResourceBuilder<GitHubModelResource> WithHealthCheck(this IResour
         var healthCheckKey = $"{builder.Resource.Name}_check";
         GitHubModelsHealthCheck? healthCheck = null;
 
+        // Ensure IHttpClientFactory is available by registering HTTP client services
+        builder.ApplicationBuilder.Services.AddHttpClient();
+
         // Register the health check
         builder.ApplicationBuilder.Services.AddHealthChecks()
             .Add(new HealthCheckRegistration(

tests/Aspire.Hosting.GitHub.Models.Tests/GitHubModelsExtensionTests.cs

@@ -3,6 +3,7 @@
 
 using Aspire.Hosting.ApplicationModel;
 using Aspire.Hosting.Utils;
+using Microsoft.Extensions.DependencyInjection;
 using Xunit;
 
 namespace Aspire.Hosting.GitHub.Models.Tests;
@@ -288,4 +289,41 @@ public void WithHealthCheckAddsHealthCheckAnnotation()
         Assert.Single(healthCheckAnnotations);
         Assert.Equal("github_check", healthCheckAnnotations[0].Key);
     }
+
+    [Fact]
+    public void WithHealthCheckEnsuresIHttpClientFactoryIsRegistered()
+    {
+        using var builder = TestDistributedApplicationBuilder.Create();
+        builder.Configuration["Parameters:github-gh-apikey"] = "test-api-key";
+
+        // Add the health check without explicitly calling AddHttpClient
+        var github = builder.AddGitHubModel("github", "openai/gpt-4o-mini").WithHealthCheck();
+
+        // Build the service provider to test dependency resolution
+        var services = builder.Services.BuildServiceProvider();
+
+        // This should not throw because WithHealthCheck should ensure IHttpClientFactory is registered
+        var httpClientFactory = services.GetService<IHttpClientFactory>();
+        Assert.NotNull(httpClientFactory);
+    }
+
+    [Fact]
+    public void WithHealthCheckWorksWhenAddHttpClientIsCalledManually()
+    {
+        using var builder = TestDistributedApplicationBuilder.Create();
+        builder.Configuration["Parameters:github-gh-apikey"] = "test-api-key";
+
+        // Manually call AddHttpClient (should not conflict with automatic registration in WithHealthCheck)
+        builder.Services.AddHttpClient();
+
+        // Add the health check
+        var github = builder.AddGitHubModel("github", "openai/gpt-4o-mini").WithHealthCheck();
+
+        // Build the service provider to test dependency resolution
+        var services = builder.Services.BuildServiceProvider();
+
+        // This should work fine since AddHttpClient can be called multiple times safely
+        var httpClientFactory = services.GetService<IHttpClientFactory>();
+        Assert.NotNull(httpClientFactory);
+    }
 }