dotnet
diff --git a/‎.github/skills/ci-test-failures/SKILL.md‎
Lines changed: 277 additions & 0 deletions b/‎.github/skills/ci-test-failures/SKILL.md‎
Lines changed: 277 additions & 0 deletions
diff --git a/‎.github/workflows/build-bundle.yml‎
Lines changed: 110 additions & 0 deletions b/‎.github/workflows/build-bundle.yml‎
Lines changed: 110 additions & 0 deletions
@@ -0,0 +1,277 @@
+---
+name: ci-test-failures
+description: Guide for diagnosing and fixing CI test failures using the DownloadFailingJobLogs tool. Use this when asked to investigate GitHub Actions test failures, download failure logs, or debug CI issues.
+---
+
+# CI Test Failure Diagnosis
+
+This skill provides patterns and practices for diagnosing GitHub Actions test failures in the Aspire repository using the `DownloadFailingJobLogs` tool.
+
+## Overview
+
+When CI tests fail, use the `DownloadFailingJobLogs.cs` tool to automatically download logs and artifacts for failed jobs. This tool eliminates manual log hunting and provides structured access to test failures.
+
+**Location**: `tools/scripts/DownloadFailingJobLogs.cs`
+
+## Quick Start
+
+### Step 1: Find the Run ID
+
+Get the run ID from the GitHub Actions URL or use the `gh` CLI:
+
+```bash
+# From URL: https://github.com/dotnet/aspire/actions/runs/19846215629
+#                                                        ^^^^^^^^^^
+#                                                        run ID
+
+# Or find the latest run on a branch
+gh run list --repo dotnet/aspire --branch <branch-name> --limit 1 --json databaseId --jq '.[0].databaseId'
+
+# Or for a PR
+gh pr checks <pr-number> --repo dotnet/aspire
+```
+
+### Step 2: Run the Tool
+
+```bash
+cd tools/scripts
+dotnet run DownloadFailingJobLogs.cs -- <run-id>
+```
+
+**Example:**
+```bash
+dotnet run DownloadFailingJobLogs.cs -- 19846215629
+```
+
+### Step 3: Analyze Output
+
+The tool creates files in your current directory:
+
+| File Pattern | Contents |
+|--------------|----------|
+| `failed_job_<n>_<job-name>.log` | Raw job logs from GitHub Actions |
+| `artifact_<n>_<testname>_<os>.zip` | Downloaded artifact zip files |
+| `artifact_<n>_<testname>_<os>/` | Extracted directory with .trx files, logs, binlogs |
+
+## What the Tool Does
+
+1. **Finds all failed jobs** in a GitHub Actions workflow run
+2. **Downloads job logs** for each failed job
+3. **Extracts test failures and errors** from logs using regex patterns
+4. **Determines artifact names** from job names (pattern: `logs-{testShortName}-{os}`)
+5. **Downloads test artifacts** containing .trx files and test logs
+6. **Extracts artifacts** to local directories for inspection
+
+## Example Workflow
+
+```bash
+# 1. Check failed jobs on a PR
+gh pr checks 14105 --repo dotnet/aspire 2>&1 | Where-Object { $_ -match "fail" }
+
+# 2. Get the run ID
+$runId = gh run list --repo dotnet/aspire --branch davidfowl/my-branch --limit 1 --json databaseId --jq '.[0].databaseId'
+
+# 3. Download failure logs
+cd tools/scripts
+dotnet run DownloadFailingJobLogs.cs -- $runId
+
+# 4. Search for errors in downloaded logs
+Get-Content "failed_job_0_*.log" | Select-String -Pattern "error|Error:" -Context 2,3 | Select-Object -First 20
+
+# 5. Check .trx files for test failures
+Get-ChildItem -Recurse -Filter "*.trx" | ForEach-Object {
+    [xml]$xml = Get-Content $_.FullName
+    $xml.TestRun.Results.UnitTestResult | Where-Object { $_.outcome -eq "Failed" }
+}
+```
+
+## Understanding Job Log Output
+
+The tool prints a summary for each failed job:
+
+```
+=== Failed Job 1/1 ===
+Name: Tests / Integrations macos (Hosting.Azure) / Hosting.Azure (macos-latest)
+ID: 56864254427
+URL: https://github.com/dotnet/aspire/actions/runs/19846215629/job/56864254427
+Downloading job logs...
+Saved job logs to: failed_job_0_Tests___Integrations_macos__Hosting_Azure____Hosting_Azure__macos-latest_.log
+
+Errors found (2):
+  - System.InvalidOperationException: Step 'provision-api-service' failed...
+```
+
+## Searching Downloaded Logs
+
+### Find Errors in Job Logs
+
+```powershell
+# PowerShell
+Get-Content "failed_job_*.log" | Select-String -Pattern "error|Error:" -Context 2,3
+
+# Bash
+grep -i "error" failed_job_*.log | head -50
+```
+
+### Find Build Failures
+
+```powershell
+Get-Content "failed_job_*.log" | Select-String -Pattern "Build FAILED|error MSB|error CS"
+```
+
+### Find Test Failures
+
+```powershell
+Get-Content "failed_job_*.log" | Select-String -Pattern "Failed!" -Context 5,0
+```
+
+### Check for Disk Space Issues
+
+```powershell
+Get-Content "failed_job_*.log" | Select-String -Pattern "No space left|disk space"
+```
+
+### Check for Timeout Issues
+
+```powershell
+Get-Content "failed_job_*.log" | Select-String -Pattern "timeout|timed out|Timeout"
+```
+
+## Using GitHub API for Annotations
+
+Sometimes job logs aren't available (404). Use annotations instead:
+
+```bash
+gh api repos/dotnet/aspire/check-runs/<job-id>/annotations
+```
+
+This returns structured error information even when full logs aren't downloadable.
+
+## Common Failure Patterns
+
+### Disk Space Exhaustion
+
+**Symptom:** `No space left on device` in annotations or logs
+
+**Diagnosis:**
+```powershell
+gh api repos/dotnet/aspire/check-runs/<job-id>/annotations 2>&1
+```
+
+**Common fixes:**
+- Add disk cleanup step before build
+- Use larger runner (e.g., `8-core-ubuntu-latest`)
+- Skip unnecessary build steps (e.g., `/p:BuildTests=false`)
+
+### Command Not Found
+
+**Symptom:** `exit code 127` or `command not found`
+
+**Diagnosis:**
+```powershell
+Get-Content "failed_job_*.log" | Select-String -Pattern "command not found|exit code 127" -Context 3,1
+```
+
+**Common fixes:**
+- Ensure PATH includes required tools
+- Use full path to executables
+- Install missing dependencies
+
+### Test Timeout
+
+**Symptom:** Test hangs, then fails with timeout
+
+**Diagnosis:**
+```powershell
+Get-Content "failed_job_*.log" | Select-String -Pattern "Test host process exited|Timeout|timed out"
+```
+
+**Common fixes:**
+- Increase test timeout
+- Check for deadlocks in test code
+- Review Heartbeat.cs output for resource exhaustion
+
+### Build Failure
+
+**Symptom:** `Build FAILED` or MSBuild errors
+
+**Diagnosis:**
+```powershell
+Get-Content "failed_job_*.log" | Select-String -Pattern "error CS|error MSB|Build FAILED" -Context 0,3
+```
+
+**Common fixes:**
+- Check for missing project references
+- Verify package versions
+- Download and analyze .binlog from artifacts
+
+## Artifact Contents
+
+Downloaded artifacts typically contain:
+
+```
+artifact_0_TestName_os/
+├── testresults/
+│   ├── TestName_net10.0_timestamp.trx    # Test results XML
+│   ├── Aspire.*.Tests_*.log              # Console output
+│   └── recordings/                        # Asciinema recordings (CLI E2E tests)
+├── *.crash.dmp                            # Crash dump (if test crashed)
+└── test.binlog                            # MSBuild binary log
+```
+
+## Parsing .trx Files
+
+```powershell
+# Find all failed tests in .trx files
+Get-ChildItem -Path "artifact_*" -Recurse -Filter "*.trx" | ForEach-Object {
+    Write-Host "=== $($_.Name) ==="
+    [xml]$xml = Get-Content $_.FullName
+    $xml.TestRun.Results.UnitTestResult | Where-Object { $_.outcome -eq "Failed" } | ForEach-Object {
+        Write-Host "FAILED: $($_.testName)"
+        Write-Host $_.Output.ErrorInfo.Message
+        Write-Host "---"
+    }
+}
+```
+
+## Tips
+
+### Clean Up Before Running
+
+```powershell
+Remove-Item *.log -Force -ErrorAction SilentlyContinue
+Remove-Item *.zip -Force -ErrorAction SilentlyContinue
+Remove-Item -Recurse artifact_* -Force -ErrorAction SilentlyContinue
+```
+
+### Run From tools/scripts Directory
+
+The tool creates files in the current directory, so run it from `tools/scripts` to keep things organized:
+
+```bash
+cd tools/scripts
+dotnet run DownloadFailingJobLogs.cs -- <run-id>
+```
+
+### Don't Commit Log Files
+
+The downloaded log files can be large. Don't commit them to the repository:
+
+```bash
+# Before committing
+rm tools/scripts/*.log
+rm tools/scripts/*.zip
+rm -rf tools/scripts/artifact_*
+```
+
+## Prerequisites
+
+- .NET 10 SDK or later
+- GitHub CLI (`gh`) installed and authenticated
+- Access to the dotnet/aspire repository
+
+## See Also
+
+- `tools/scripts/README.md` - Full documentation
+- `tools/scripts/Heartbeat.cs` - System monitoring tool for diagnosing hangs
+- `.github/skills/cli-e2e-testing/SKILL.md` - CLI E2E test troubleshooting
@@ -0,0 +1,110 @@
+name: Build Bundle (Reusable)
+
+# This workflow creates the Aspire CLI bundle by:
+# 1. Downloading the native CLI from the CLI archives workflow
+# 2. Building/publishing managed components (Dashboard, NuGetHelper, AppHostServer)
+# 3. Assembling everything into a bundle using CreateLayout
+
+on:
+  workflow_call:
+    inputs:
+      versionOverrideArg:
+        required: false
+        type: string
+
+jobs:
+  build_bundle:
+    name: Build bundle (${{ matrix.targets.rid }})
+    runs-on: ${{ matrix.targets.runner }}
+    strategy:
+      matrix:
+        targets:
+          - rid: linux-x64
+            runner: 8-core-ubuntu-latest  # Larger runner for bundle disk space
+            archive_ext: tar.gz
+          - rid: win-x64
+            runner: windows-latest
+            archive_ext: zip
+          - rid: osx-arm64
+            runner: macos-latest
+            archive_ext: tar.gz
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683  # v4.2.2
+
+      # Download CLI archive from previous workflow - this avoids rebuilding native CLI
+      - name: Download CLI archive
+        uses: actions/download-artifact@cc203385981b70ca67e1cc392babf9cc229d5806  # v4.1.9
+        with:
+          name: cli-native-archives-${{ matrix.targets.rid }}
+          path: artifacts/packages
+
+      # Download RID-specific NuGet packages (for DCP)
+      - name: Download RID-specific NuGets
+        uses: actions/download-artifact@cc203385981b70ca67e1cc392babf9cc229d5806  # v4.1.9
+        with:
+          name: built-nugets-for-${{ matrix.targets.rid }}
+          path: artifacts/packages/Release/Shipping
+
+      # Extract CLI archive to expected location so CreateLayout can find it
+      - name: Extract CLI archive
+        shell: pwsh
+        run: |
+          $rid = "${{ matrix.targets.rid }}"
+          $ext = if ($rid -eq "win-x64") { "zip" } else { "tar.gz" }
+          $destDir = "artifacts/bin/Aspire.Cli/Release/net10.0/$rid/native"
+          New-Item -ItemType Directory -Path $destDir -Force | Out-Null
+          
+          $archive = Get-ChildItem -Path artifacts/packages -Recurse -Filter "aspire-cli-$rid-*.$ext" | Select-Object -First 1
+          if (-not $archive) {
+            Write-Error "CLI archive not found for $rid"
+            exit 1
+          }
+          Write-Host "Extracting $($archive.FullName) to $destDir"
+          
+          if ($ext -eq "zip") {
+            Expand-Archive -Path $archive.FullName -DestinationPath $destDir -Force
+          } else {
+            tar -xzf $archive.FullName -C $destDir
+          }
+          Get-ChildItem $destDir
+
+      # Build bundle directly via MSBuild - skips native CLI build, uses pre-extracted CLI
+      - name: Build bundle
+        shell: pwsh
+        run: |
+          $dotnetCmd = if ($IsWindows) { "./dotnet.cmd" } else { "./dotnet.sh" }
+          & $dotnetCmd msbuild eng/Bundle.proj `
+            /restore `
+            /p:Configuration=Release `
+            /p:TargetRid=${{ matrix.targets.rid }} `
+            /p:SkipNativeBuild=true `
+            /p:ContinuousIntegrationBuild=true `
+            /bl:${{ github.workspace }}/artifacts/log/Release/Bundle.binlog `
+            ${{ inputs.versionOverrideArg }}
+
+      - name: Upload bundle
+        if: success()
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1  # v4.6.1
+        with:
+          name: aspire-bundle-${{ matrix.targets.rid }}
+          path: artifacts/bundle/${{ matrix.targets.rid }}
+          retention-days: 15
+          if-no-files-found: error
+
+      - name: Upload bundle archive
+        if: success()
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1  # v4.6.1
+        with:
+          name: aspire-bundle-archive-${{ matrix.targets.rid }}
+          path: artifacts/bundle/*.${{ matrix.targets.archive_ext }}
+          retention-days: 15
+          if-no-files-found: warn
+
+      - name: Upload logs
+        if: always()
+        uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1  # v4.6.1
+        with:
+          name: bundle-logs-${{ matrix.targets.rid }}
+          path: artifacts/log/**