fixup test script

Author: radical

eng/scripts/get-aspire-cli.sh

@@ -30,7 +30,7 @@ DEFAULT_QUALITY="release"
 
 # Function to show help
 show_help() {
-    cat << 'EOF'
+    cat << EOF
 Aspire CLI Download Script
 
 DESCRIPTION:

eng/scripts/tests/test-get-aspire-cli.ps1

@@ -80,7 +80,12 @@ initialize_test_framework() {
     # Create a top-level temporary directory for all test operations
     local test_id
     test_id=$(date +%s%N | cut -b1-13)  # Use timestamp for uniqueness
-    TOP_LEVEL_TEST_DIR=$(mktemp -d -t "aspire-cli-tests-${test_id}")
+    # Use a cross-platform mktemp pattern:
+    # macOS: mktemp -d -t prefix           (suffix with random chars automatically)
+    # GNU coreutils: requires at least 3 X's in the template. The form -t expects a template
+    # that includes the X's (it does NOT auto-append like BSD). So we append -XXXXXX to satisfy GNU.
+    # Using a unified pattern works on both platforms.
+    TOP_LEVEL_TEST_DIR=$(mktemp -d -t "aspire-cli-tests-${test_id}-XXXXXX")
 
     if [[ "$TEST_VERBOSE" == "true" ]]; then
         write_colored_output "Test framework initialized with verbose output" "BLUE"
@@ -122,13 +127,14 @@ write_test_result() {
     local status="$2"
     local details="${3:-}"
 
-    ((TESTS_TOTAL++))
+    # Use prefix increment so arithmetic command exits with status 0 under set -e
+    ((++TESTS_TOTAL))
 
     if [[ "$status" == "PASS" ]]; then
-        ((TESTS_PASSED++))
+    ((++TESTS_PASSED))
         write_colored_output "✓ PASS: $test_name" "GREEN"
     else
-        ((TESTS_FAILED++))
+    ((++TESTS_FAILED))
         write_colored_output "✗ FAIL: $test_name" "RED"
     fi