Increase az aks update timeout from 3 to 5 minutes in AKS E2E tests #14409
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The az aks update --attach-acr command can take 3-6 minutes due to Azure addon reconciliation. The 3-minute timeout caused flaky failures in nightly CI (issue #14397). Increase to 5 minutes in both AKS test files.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14409Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14409" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces flakiness in the AKS deployment end-to-end tests by increasing the WaitForSuccessPrompt timeout for the az aks update --attach-acr step, addressing intermittent Azure-side latency during addon reconciliation.
Changes:
- Increase the
az aks update --attach-acrstep timeout from 3 minutes to 5 minutes in the AKS starter deployment E2E test. - Increase the same step timeout from 3 minutes to 5 minutes in the AKS starter + Redis deployment E2E test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Aspire.Deployment.EndToEnd.Tests/AksStarterWithRedisDeploymentTests.cs | Extends the az aks update --attach-acr wait timeout to reduce flakiness in the Redis AKS deployment E2E flow. |
| tests/Aspire.Deployment.EndToEnd.Tests/AksStarterDeploymentTests.cs | Extends the az aks update --attach-acr wait timeout to reduce flakiness in the starter AKS deployment E2E flow. |
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #21821649495 |
Member
Author
|
/deployment-tests |
Member
Author
|
/deployment-test |
Contributor
|
🚀 Deployment tests starting on PR #14409... This will deploy to real Azure infrastructure. Results will be posted here when complete. |
Contributor
|
❌ Deployment E2E Tests failed Summary: 13 passed, 1 failed, 0 cancelled Passed Tests
Failed Tests
🎬 Terminal Recordings
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Increases the
WaitForSuccessPrompttimeout for theaz aks update --attach-acrstep from 3 minutes to 5 minutes in both AKS deployment E2E tests.Root Cause
The nightly deployment E2E test
AksStarterWithRedisDeploymentTests.DeployStarterTemplateWithRedisToAksfailed on 2026-02-08 (workflow run) with:The
az aks update --attach-acrcommand was still reconciling addons (ReconcilingAddons ..spinner) when the 3-minute timeout expired. This Azure operation can realistically take 3–6 minutes depending on Azure-side latency. The next nightly run (2026-02-09) passed, confirming this is a flaky timing issue.Changes
AksStarterWithRedisDeploymentTests.cs: 3min → 5min timeout on step 6AksStarterDeploymentTests.cs: 3min → 5min timeout on step 6 (same vulnerability)Fixes #14397