Support for .fsproj, .vbproj project files next to .csproj #12087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12087Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12087" |
yreynhout
commented
Oct 16, 2025
yreynhout
force-pushed
the
restore-fsproj-support
branch
from
58b60e3 to
9fd2606
Compare
yreynhout
force-pushed
the
restore-fsproj-support
branch
from
9fd2606 to
d8d2580
Compare
JamesNK
reviewed
Oct 16, 2025
| return projectFile; | ||
| } | ||
| // Handle .fsproj files | ||
| else if (projectFile.Extension.Equals(".fsproj", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Rather than duplicating the csproj branch, how about having a collection of project file extensions (csproj, fsproj, vbproj) and check whether the extension matches any of them.
There was a problem hiding this comment.
Test adjusted, support for the mentioned extensions added.
yreynhout
changed the title
JamesNK
reviewed
Oct 20, 2025
JamesNK
approved these changes
Oct 21, 2025
mitchdenny
reviewed
Oct 21, 2025
|
|
||
| internal sealed class ProjectLocator(ILogger<ProjectLocator> logger, IDotNetCliRunner runner, CliExecutionContext executionContext, IInteractionService interactionService, IConfigurationService configurationService, AspireCliTelemetry telemetry, IFeatures features) : IProjectLocator | ||
| { | ||
| private static readonly HashSet<string> s_supportedProjectFileExtensions = new HashSet<string>(StringComparer.OrdinalIgnoreCase) { ".csproj", ".fsproj", ".vbproj" }; |
There was a problem hiding this comment.
We might need to introduce a FileExtensionHelper.IsSupportedMsBuildFile(...) which encapsulates the check. That way we can reuse it. There are a few other places in the CLI where we make assumptions about using *.csproj files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, up until Aspire 9.4 IIRC, one could use F# to author an AppHost. I presume, when support for single file C# applications was integrated, support for
.fsprojaccidentally got broken. Perhaps there are explicit reasons to not support F# projects for this purpose. If so, I'd like to learn about the motivation for that.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate