Skip to content

[CI] Outerloop/Quarantined workflows - build only the required bits #12142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2025
Merged

[CI] Outerloop/Quarantined workflows - build only the required bits #12142

merged 3 commits into from
Oct 18, 2025

Conversation

Copy link
Contributor

Copilot AI commented Oct 18, 2025 •
edited by radical
Loading

The build solution step in the Generate runsheet job was running out of space. The agent starts with around 22G free.

This PR introduces the BuildTestsOnly property to limit the build to only test projects during runsheet generation.

Results:

  • Disk has 5.3G free after the build (previously exhausted)
  • Build time reduced from ~7 mins to ~4 mins
  • Projects built reduced from 335 to 88 (only test projects)

Changes:

  1. eng/Build.props:

    • Added BuildTestsOnly property documentation
    • Split ItemGroups to separate test and non-test projects

  2. .github/workflows/specialized-test-runner.yml:

    • Added /p:BuildTestsOnly=true to build step
    • Added disk usage monitoring steps (before/after build)
    • Set /p:InstallBrowsersForPlaywright=false unconditionally

Fixes #12143

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2025 •
edited
Loading

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12142

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12142"

Copilot AI changed the title [WIP] Add BuildTestsOnly property to Build.props and update workflows Add BuildTestsOnly property to reduce disk space usage in specialized test workflows Oct 18, 2025
Copilot finished work on behalf of radical October 18, 2025 02:43
Copilot AI requested a review from radical October 18, 2025 02:43
@radical
[CI] Outerloop/Quarantined workflows - build only the required bits
f60dcb6 
The `build solution` step in `Generate runsheet` job was running out of
space. The agent starts with around 22G free.

After the changes here to limit the build to only the test jobs:

- the disk has 5.3G free after the build
- The build time goes down from ~7 mins to ~4 mins.

Fixes #12143
@radical radical force-pushed the copilot/add-buildtestsonly-property branch from 195c018 to f60dcb6 Compare October 18, 2025 05:34
@radical
Copy link
Member

radical commented Oct 18, 2025

@copilot update the PR title and description based on the commits.

Copy link
Contributor Author

Copilot AI commented Oct 18, 2025

@copilot update the PR title and description based on the commits.

Based on the commit f60dcb6, here's the updated PR information:

Title: [CI] Outerloop/Quarantined workflows - build only the required bits

Description:

The build solution step in the Generate runsheet job was running out of space. The agent starts with around 22G free.

This PR introduces the BuildTestsOnly property to limit the build to only test projects during runsheet generation.

Results:

  • Disk has 5.3G free after the build (previously exhausted)
  • Build time reduced from ~7 mins to ~4 mins
  • Projects built reduced from 335 to 88 (only test projects)

Changes:

  1. eng/Build.props:

    • Added BuildTestsOnly property documentation
    • Split ItemGroups to separate test and non-test projects

  2. .github/workflows/specialized-test-runner.yml:

    • Added /p:BuildTestsOnly=true to build step
    • Added disk usage monitoring steps (before/after build)
    • Set /p:InstallBrowsersForPlaywright=false unconditionally

Fixes #12143

Copilot AI changed the title Add BuildTestsOnly property to reduce disk space usage in specialized test workflows [CI] Outerloop/Quarantined workflows - build only the required bits Oct 18, 2025
Copilot finished work on behalf of radical October 18, 2025 05:41
@radical radical marked this pull request as ready for review October 18, 2025 05:42
Copilot AI reviewed Oct 18, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Purpose: Limit build scope during runsheet generation to only test projects to reduce disk usage and build time.

  • Introduces BuildTestsOnly property to exclude non-test projects.
  • Adjusts workflow to pass /p:BuildTestsOnly=true and adds disk usage diagnostics.
  • Splits project inclusion logic into separate ItemGroups for test and non-test projects.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
eng/Build.props Adds BuildTestsOnly property and restructures ItemGroups to separate test/non-test projects.
.github/workflows/specialized-test-runner.yml Applies BuildTestsOnly in CI workflow and adds disk usage reporting steps.

@radical radical enabled auto-merge (squash) October 18, 2025 06:30
@radical radical merged commit 6733971 into main Oct 18, 2025
302 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 13.0 milestone Oct 18, 2025
@radical radical deleted the copilot/add-buildtestsonly-property branch October 20, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@radical radical Awaiting requested review from radical

@davidfowl davidfowl Awaiting requested review from davidfowl

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees

@radical radical

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

13.0

Development

Successfully merging this pull request may close these issues.

[CI] Outerloop/Quarantined tests workflows failing due to running out of space

3 participants

@radical @mitchdenny